You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@harmony.apache.org by Paulex Yang <pa...@gmail.com> on 2006/08/30 05:15:04 UTC
[classlib][logging]yet another non-bug difference with RI(Re: [jira]
Created: (HARMONY-1300) [classlib][logging] XMLFormatter.format returns a
String contains "" while RI doesn't when log message and pattern
is null.)
From the DTD for j.u.logging.XMLFormatter[1], message is required by
record, so I consider this is RI's bug, and I suggest to follow spec in
this case, because it is hard to believe this difference with RI will
make application fail, while there is possibilities for some
applications to validate logging record using the DTD, it may fail on
RI. If no one objects, I will mark this issue as "non-bug difference
with RI".
[1]
...
<!-- Each logging call is described by a record element. -->
<!ELEMENT record (date, millis, sequence, logger?, level,class?,
method?, thread?, message, key?, catalog?, param*, exception?)>
...
Andrew Zhang (JIRA) wrote:
> [classlib][logging] XMLFormatter.format returns a String contains "<message/>" while RI doesn't when log message and pattern is null.
> ---------------------------------------------------------------------------------------------------------------------------------------
>
> Key: HARMONY-1300
> URL: http://issues.apache.org/jira/browse/HARMONY-1300
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Reporter: Andrew Zhang
>
>
> Following test reproduces the bug:
> public void test_format() {
> formatter = new XMLFormatter();
> LogRecord lr = new LogRecord(Level.SEVERE, null);
> String output = formatter.format(lr);
> assertFalse(output.indexOf("message") > 0);
> }
> The test passes against RI while fails against Harmony.
>
> I'll upload a patch to fix this problem soon.
>
> Best regards,
> Andrew
>
>
--
Paulex Yang
China Software Development Lab
IBM
---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org
Re: [classlib][logging]yet another non-bug difference with RI(Re:
[jira] Created: (HARMONY-1300) [classlib][logging] XMLFormatter.format returns
a String contains "" while RI doesn't when log message and pattern
is null.)
Posted by "Geir Magnusson Jr." <ge...@pobox.com>.
agreed
Paulex Yang wrote:
> From the DTD for j.u.logging.XMLFormatter[1], message is required by
> record, so I consider this is RI's bug, and I suggest to follow spec in
> this case, because it is hard to believe this difference with RI will
> make application fail, while there is possibilities for some
> applications to validate logging record using the DTD, it may fail on
> RI. If no one objects, I will mark this issue as "non-bug difference
> with RI".
>
> [1]
> ...
> <!-- Each logging call is described by a record element. -->
> <!ELEMENT record (date, millis, sequence, logger?, level,class?,
> method?, thread?, message, key?, catalog?, param*, exception?)>
> ...
>
> Andrew Zhang (JIRA) wrote:
>> [classlib][logging] XMLFormatter.format returns a String contains
>> "<message/>" while RI doesn't when log message and pattern is null.
>> ---------------------------------------------------------------------------------------------------------------------------------------
>>
>>
>> Key: HARMONY-1300
>> URL: http://issues.apache.org/jira/browse/HARMONY-1300
>> Project: Harmony
>> Issue Type: Bug
>> Components: Classlib
>> Reporter: Andrew Zhang
>>
>>
>> Following test reproduces the bug:
>> public void test_format() {
>> formatter = new XMLFormatter();
>> LogRecord lr = new LogRecord(Level.SEVERE, null);
>> String output = formatter.format(lr);
>> assertFalse(output.indexOf("message") > 0);
>> }
>> The test passes against RI while fails against Harmony.
>> I'll upload a patch to fix this problem soon.
>>
>> Best regards,
>> Andrew
>>
>>
>
>
---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org
Re: [classlib][logging]yet another non-bug difference with RI(Re: [jira] Created: (HARMONY-1300) [classlib][logging] XMLFormatter.format returns a String contains "" while RI doesn't when log message and pattern is null.)
Posted by Andrew Zhang <zh...@gmail.com>.
On 8/30/06, Paulex Yang <pa...@gmail.com> wrote:
> From the DTD for j.u.logging.XMLFormatter[1], message is required by
> record, so I consider this is RI's bug, and I suggest to follow spec in
> this case, because it is hard to believe this difference with RI will
> make application fail, while there is possibilities for some
> applications to validate logging record using the DTD, it may fail on
> RI. If no one objects, I will mark this issue as "non-bug difference
> with RI".
Agreed.
Paulex, please don't apply harmony-1300 patch, and close it as "non-bug
difference with RI".
[1]
> ...
> <!-- Each logging call is described by a record element. -->
> <!ELEMENT record (date, millis, sequence, logger?, level,class?,
> method?, thread?, message, key?, catalog?, param*, exception?)>
> ...
>
> Andrew Zhang (JIRA) wrote:
> > [classlib][logging] XMLFormatter.format returns a String contains
> "<message/>" while RI doesn't when log message and pattern is null.
> >
> ---------------------------------------------------------------------------------------------------------------------------------------
> >
> > Key: HARMONY-1300
> > URL: http://issues.apache.org/jira/browse/HARMONY-1300
> > Project: Harmony
> > Issue Type: Bug
> > Components: Classlib
> > Reporter: Andrew Zhang
> >
> >
> > Following test reproduces the bug:
> > public void test_format() {
> > formatter = new XMLFormatter();
> > LogRecord lr = new LogRecord(Level.SEVERE, null);
> > String output = formatter.format(lr);
> > assertFalse(output.indexOf("message") > 0);
> > }
> > The test passes against RI while fails against Harmony.
> >
> > I'll upload a patch to fix this problem soon.
> >
> > Best regards,
> > Andrew
> >
> >
>
>
> --
> Paulex Yang
> China Software Development Lab
> IBM
>
>
>
> ---------------------------------------------------------------------
> Terms of use : http://incubator.apache.org/harmony/mailing.html
> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
>
>
--
Andrew Zhang
China Software Development Lab, IBM