You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by astroshim <gi...@git.apache.org> on 2017/02/07 15:02:15 UTC
[GitHub] zeppelin pull request #1985: [ZEPPELIN-2075] Can't stop infinite `while` sta...
GitHub user astroshim opened a pull request:
https://github.com/apache/zeppelin/pull/1985
[ZEPPELIN-2075] Can't stop infinite `while` statement in pyspark Interpreter.
### What is this PR for?
If following code runs with Pyspark Interpreter, there is no way to cancel except Zeppelin Server restart.
```
%spark.pyspark
import time
while True:
time.sleep(1)
print("running..")
```
### What type of PR is it?
Bug Fix | Improvement
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-2075
### How should this be tested?
Run above code with Pyspark Interpreter and try to cancel.
### Screenshots (if appropriate)
- before
- after
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/astroshim/zeppelin ZEPPELIN-2075
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1985.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1985
----
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1985: [ZEPPELIN-2075] Can't stop infinite `while` statement ...
Posted by astroshim <gi...@git.apache.org>.
Github user astroshim commented on the issue:
https://github.com/apache/zeppelin/pull/1985
@FireArrow I think it seems not can be possible to know if impersonation mode or not in Interpreter side(I couldn't find it) and checking `cancel` paragraph for impersonation is also not good idea (Interpreter sever can be launched itself not the same system with ZeppelinServer)
So I think that the canceling job can run only by user who launched interpreter process can be one option. and In this way, the other user can't stop the job in shared mode.
What do you think?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1985: [ZEPPELIN-2075] Can't stop infinite `while` sta...
Posted by astroshim <gi...@git.apache.org>.
GitHub user astroshim reopened a pull request:
https://github.com/apache/zeppelin/pull/1985
[ZEPPELIN-2075] Can't stop infinite `while` statement in pyspark Interpreter.
### What is this PR for?
If following code runs with Pyspark Interpreter, there is no way to cancel except Zeppelin Server restart.
```
%spark.pyspark
import time
while True:
time.sleep(1)
print("running..")
```
### What type of PR is it?
Bug Fix | Improvement
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-2075
### How should this be tested?
Run above code with Pyspark Interpreter and try to cancel.
### Screenshots (if appropriate)
- before
- after
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/astroshim/zeppelin ZEPPELIN-2075
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1985.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1985
----
commit 6731e5628c5c139bd9f7189416a0312313cfda7a
Author: astroshim <hs...@zepl.com>
Date: 2017-02-07T14:47:45Z
add signal to cancel job
commit 65d8cc697179d1e12f18e95cc04e30a43608e7cb
Author: astroshim <hs...@zepl.com>
Date: 2017-02-07T14:54:23Z
init python pid variable
commit 678c183000ce194cfd17c8a6979ccedf6611a83f
Author: astroshim <hs...@zepl.com>
Date: 2017-02-08T04:23:58Z
remove signal handler
commit c0cac4ee0df9bf3140c3465da5a4679dca87f6c1
Author: astroshim <hs...@zepl.com>
Date: 2017-02-08T04:36:03Z
fix logging
commit f26eacf5041eb266d04c237df50be42fdd86f87b
Author: astroshim <hs...@zepl.com>
Date: 2017-02-12T03:30:22Z
add test-case for canceling.
commit b60d89a5ba4aae0fb983dcfea2bed1b03e1349b6
Author: astroshim <hs...@zepl.com>
Date: 2017-02-15T06:06:57Z
Merge branch 'master' into ZEPPELIN-2075
commit bc12eaaec6dcfe06911359ed5cae7f9d663d66e0
Author: astroshim <hs...@zepl.com>
Date: 2017-02-15T08:11:14Z
pass pid to java
commit 84bf09ae2eec0efefaa4c0a34fda21345ccbf06c
Author: astroshim <hs...@zepl.com>
Date: 2017-02-18T15:36:45Z
fix testcase
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1985: [ZEPPELIN-2075] Can't stop infinite `while` statement ...
Posted by zjffdu <gi...@git.apache.org>.
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/1985
Sorry, it's my misunderstanding. It just interrupt the process rather than kill it. The behavior is consistent with jupyter. It's awesome.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1985: [ZEPPELIN-2075] Can't stop infinite `while` sta...
Posted by astroshim <gi...@git.apache.org>.
Github user astroshim closed the pull request at:
https://github.com/apache/zeppelin/pull/1985
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1985: [ZEPPELIN-2075] Can't stop infinite `while` statement ...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/1985
CI test failure is not related (fixed by #2033).
LGTM and merge to master if no further discussions.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1985: [ZEPPELIN-2075] Can't stop infinite `while` statement ...
Posted by astroshim <gi...@git.apache.org>.
Github user astroshim commented on the issue:
https://github.com/apache/zeppelin/pull/1985
Hello. Sorry for late response.
@Leemoonsoo Let me fix CI error.
@karuppayya Let me fix `scala` too in another PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1985: [ZEPPELIN-2075] Can't stop infinite `while` statement ...
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/1985
Will merge it
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1985: [ZEPPELIN-2075] Can't stop infinite `while` statement ...
Posted by zjffdu <gi...@git.apache.org>.
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/1985
Even in the impersonation mode, it is the process owner to interrupt the process. Here it is the interpreter process owner interrupt the process instead of the zeppelin server owner. But I can not verify it in impersonation mode. It seems the impersonation mode is broken. I got the following error, can anyone else verify the impersonation mode ?
```
ERROR [2017-02-28 09:20:18,882] ({pool-2-thread-2} Job.java[run]:194) - Job failed
org.apache.zeppelin.interpreter.InterpreterException: org.apache.hadoop.security.authorize.AuthorizationException: User: user1 is not allowed to impersonate user1
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1985: [ZEPPELIN-2075] Can't stop infinite `while` statement ...
Posted by astroshim <gi...@git.apache.org>.
Github user astroshim commented on the issue:
https://github.com/apache/zeppelin/pull/1985
@FireArrow Note has permission in the zeppelin so if user doesn't have `write` permission on that note, user can't cancel job.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1985: [ZEPPELIN-2075] Can't stop infinite `while` statement ...
Posted by zjffdu <gi...@git.apache.org>.
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/1985
> User zeppelin have permission to execute paswordless sudo to local users allowed to log into Zeppelin
> Interpreters will with this run as the user starting the process, and the zeppelin user will not have permission to send any signal to them.
I think @FireArrow 's concern is that zeppelin user can kill the process. Actually it is not the user zeppelin send the signal, it is the interpreter process owner. So I think don't think there's any permission issue here. @FireArrow Please help confirm.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1985: [ZEPPELIN-2075] Can't stop infinite `while` statement ...
Posted by FireArrow <gi...@git.apache.org>.
Github user FireArrow commented on the issue:
https://github.com/apache/zeppelin/pull/1985
Sorry for the late comment.
This solution wouldn't work with impersonation, as the zeppelin user wouldn't have permission to interrupt another users process (unless zeppelin run as root, which comes with a whole set of other problems). I suggest you read in the impersonation command, if there is one, and use that to send of the `kill -SIGINT <pid>`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1985: [ZEPPELIN-2075] Can't stop infinite `while` statement ...
Posted by zjffdu <gi...@git.apache.org>.
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/1985
@astroshim It looks like the python process will be killed, does it mean the interpreter is closed and the state of all the previous paragraphs is lost ? I try the cancel function in jupyter, it seems jupyter just cancel the current cell but keep the python process alive, the previous cell's state is still in the python process. Maybe there's a better approach for this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1985: [ZEPPELIN-2075] Can't stop infinite `while` sta...
Posted by astroshim <gi...@git.apache.org>.
Github user astroshim closed the pull request at:
https://github.com/apache/zeppelin/pull/1985
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1985: [ZEPPELIN-2075] Can't stop infinite `while` statement ...
Posted by karuppayya <gi...@git.apache.org>.
Github user karuppayya commented on the issue:
https://github.com/apache/zeppelin/pull/1985
@astroshim This would be a problem in case of scala snippet also(a loop with a print in other words , that which runs only within driver). Is there a possible fix such that all interpreters(scala, python) can benefit.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1985: [ZEPPELIN-2075] Can't stop infinite `while` statement ...
Posted by astroshim <gi...@git.apache.org>.
Github user astroshim commented on the issue:
https://github.com/apache/zeppelin/pull/1985
@FireArrow Yea, right. I understood. Let me fix it.
Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1985: [ZEPPELIN-2075] Can't stop infinite `while` statement ...
Posted by FireArrow <gi...@git.apache.org>.
Github user FireArrow commented on the issue:
https://github.com/apache/zeppelin/pull/1985
@astroshim That's not what I'm talking about. Assume the following:
Zeppelin run as user "zeppelin"
In `zeppelin-env.sh`: `export ZEPPELIN_IMPERSONATE_CMD='sudo -H -i -u ${ZEPPELIN_IMPERSONATE_USER} bash -c '`
User `zeppelin` have permission to execute paswordless sudo to local users allowed to log into Zeppelin
Interpreters will with this run as the user starting the process, and the zeppelin user will not have permission to send any signal to them.
My suggestion is to execute the `kill` with `$ZEPPELIN_IMPERSONATE_CMD` to make sure the `kill` is executed in the same way as the interpreter was started in the first place.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1985: [ZEPPELIN-2075] Can't stop infinite `while` statement ...
Posted by FireArrow <gi...@git.apache.org>.
Github user FireArrow commented on the issue:
https://github.com/apache/zeppelin/pull/1985
Terribly sorry for late answer! Not sure why I didn't get any notifications about your answers :confused:
@zjffdu I haven't looked into who actually sends the signal, but if it is as you say, with the user owning the interpreter process sending the signal, it should be fine.
My worry was that it was sent by the user running the server, and that if that user isn't root (which would be a terrible idea for other reasons) the OS wouldn't allow sending signals to another users process.
And it is tricky to set up impersonation, but as far as I know it is not broken. I only have my production environment with this set up right now. I suggest not using spark to test with. The `sudo` approach clashes with the spark impersonation, so if you really want to try that you have to set `export ZEPPELIN_IMPERSONATE_SPARK_PROXY_USER=false`, and find a way to make sure the user starting the interpreter has a kerberos ticket (if you need that)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1985: [ZEPPELIN-2075] Can't stop infinite `while` sta...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/1985
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1985: [ZEPPELIN-2075] Can't stop infinite `while` statement ...
Posted by astroshim <gi...@git.apache.org>.
Github user astroshim commented on the issue:
https://github.com/apache/zeppelin/pull/1985
@zjffdu I tested impersonation mode followed http://zeppelin.apache.org/docs/0.7.0/manual/userimpersonation.html and worked well.
BTW for now anybody can interrupt to interpreter process. and that is @FireArrow's worrying. Am i right?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1985: [ZEPPELIN-2075] Can't stop infinite `while` statement ...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/1985
@astroshim can you take a look CI error ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1985: [ZEPPELIN-2075] Can't stop infinite `while` sta...
Posted by astroshim <gi...@git.apache.org>.
Github user astroshim closed the pull request at:
https://github.com/apache/zeppelin/pull/1985
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1985: [ZEPPELIN-2075] Can't stop infinite `while` statement ...
Posted by FireArrow <gi...@git.apache.org>.
Github user FireArrow commented on the issue:
https://github.com/apache/zeppelin/pull/1985
I have basically only set up zeppelin in isolated mode with impersonation, so I'm not sure what is the "expected" behavior is outside of that. Someone else will have to pitch in here.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1985: [ZEPPELIN-2075] Can't stop infinite `while` statement ...
Posted by astroshim <gi...@git.apache.org>.
Github user astroshim commented on the issue:
https://github.com/apache/zeppelin/pull/1985
@FireArrow ping.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1985: [ZEPPELIN-2075] Can't stop infinite `while` sta...
Posted by astroshim <gi...@git.apache.org>.
GitHub user astroshim reopened a pull request:
https://github.com/apache/zeppelin/pull/1985
[ZEPPELIN-2075] Can't stop infinite `while` statement in pyspark Interpreter.
### What is this PR for?
If following code runs with Pyspark Interpreter, there is no way to cancel except Zeppelin Server restart.
```
%spark.pyspark
import time
while True:
time.sleep(1)
print("running..")
```
### What type of PR is it?
Bug Fix | Improvement
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-2075
### How should this be tested?
Run above code with Pyspark Interpreter and try to cancel.
### Screenshots (if appropriate)
- before
- after
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/astroshim/zeppelin ZEPPELIN-2075
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1985.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1985
----
commit 6731e5628c5c139bd9f7189416a0312313cfda7a
Author: astroshim <hs...@zepl.com>
Date: 2017-02-07T14:47:45Z
add signal to cancel job
commit 65d8cc697179d1e12f18e95cc04e30a43608e7cb
Author: astroshim <hs...@zepl.com>
Date: 2017-02-07T14:54:23Z
init python pid variable
commit 678c183000ce194cfd17c8a6979ccedf6611a83f
Author: astroshim <hs...@zepl.com>
Date: 2017-02-08T04:23:58Z
remove signal handler
commit c0cac4ee0df9bf3140c3465da5a4679dca87f6c1
Author: astroshim <hs...@zepl.com>
Date: 2017-02-08T04:36:03Z
fix logging
commit f26eacf5041eb266d04c237df50be42fdd86f87b
Author: astroshim <hs...@zepl.com>
Date: 2017-02-12T03:30:22Z
add test-case for canceling.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1985: [ZEPPELIN-2075] Can't stop infinite `while` statement ...
Posted by astroshim <gi...@git.apache.org>.
Github user astroshim commented on the issue:
https://github.com/apache/zeppelin/pull/1985
@Leemoonsoo @zjffdu @felixcheung @karuppayya Could you guys help to review about the impersonation mode?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1985: [ZEPPELIN-2075] Can't stop infinite `while` statement ...
Posted by astroshim <gi...@git.apache.org>.
Github user astroshim commented on the issue:
https://github.com/apache/zeppelin/pull/1985
@zjffdu yes, this PR is not kill the python process.
Thank you for reviewing!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1985: [ZEPPELIN-2075] Can't stop infinite `while` sta...
Posted by astroshim <gi...@git.apache.org>.
GitHub user astroshim reopened a pull request:
https://github.com/apache/zeppelin/pull/1985
[ZEPPELIN-2075] Can't stop infinite `while` statement in pyspark Interpreter.
### What is this PR for?
If following code runs with Pyspark Interpreter, there is no way to cancel except Zeppelin Server restart.
```
%spark.pyspark
import time
while True:
time.sleep(1)
print("running..")
```
### What type of PR is it?
Bug Fix | Improvement
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-2075
### How should this be tested?
Run above code with Pyspark Interpreter and try to cancel.
### Screenshots (if appropriate)
- before
- after
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/astroshim/zeppelin ZEPPELIN-2075
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1985.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1985
----
commit 6731e5628c5c139bd9f7189416a0312313cfda7a
Author: astroshim <hs...@zepl.com>
Date: 2017-02-07T14:47:45Z
add signal to cancel job
commit 65d8cc697179d1e12f18e95cc04e30a43608e7cb
Author: astroshim <hs...@zepl.com>
Date: 2017-02-07T14:54:23Z
init python pid variable
commit 678c183000ce194cfd17c8a6979ccedf6611a83f
Author: astroshim <hs...@zepl.com>
Date: 2017-02-08T04:23:58Z
remove signal handler
commit c0cac4ee0df9bf3140c3465da5a4679dca87f6c1
Author: astroshim <hs...@zepl.com>
Date: 2017-02-08T04:36:03Z
fix logging
commit f26eacf5041eb266d04c237df50be42fdd86f87b
Author: astroshim <hs...@zepl.com>
Date: 2017-02-12T03:30:22Z
add test-case for canceling.
commit b60d89a5ba4aae0fb983dcfea2bed1b03e1349b6
Author: astroshim <hs...@zepl.com>
Date: 2017-02-15T06:06:57Z
Merge branch 'master' into ZEPPELIN-2075
commit bc12eaaec6dcfe06911359ed5cae7f9d663d66e0
Author: astroshim <hs...@zepl.com>
Date: 2017-02-15T08:11:14Z
pass pid to java
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1985: [ZEPPELIN-2075] Can't stop infinite `while` statement ...
Posted by astroshim <gi...@git.apache.org>.
Github user astroshim commented on the issue:
https://github.com/apache/zeppelin/pull/1985
@FireArrow Thank you for confirm your idea and thank @zjffdu help to review!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---