You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Justin Judd (JIRA)" <ji...@apache.org> on 2012/11/06 01:14:12 UTC

[jira] [Created] (THRIFT-1747) Generated Python code incorrect when declaring constants of a struct type declared in an included thrift file

Justin Judd created THRIFT-1747:
-----------------------------------

             Summary: Generated Python code incorrect when declaring constants of a struct type declared in an included thrift file
                 Key: THRIFT-1747
                 URL: https://issues.apache.org/jira/browse/THRIFT-1747
             Project: Thrift
          Issue Type: Bug
          Components: Python - Compiler
            Reporter: Justin Judd
         Attachments: python_structs.patch

The python code produced when a constant is declared of a struct type that was declared in another thrift file does not contain the namespace information.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (THRIFT-1747) Generated Python code incorrect when declaring constants of a struct type declared in an included thrift file

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/THRIFT-1747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13498491#comment-13498491 ] 

Hudson commented on THRIFT-1747:
--------------------------------

Integrated in Thrift #582 (See [https://builds.apache.org/job/Thrift/582/])
    THRIFT-1747 Generated Python code incorrect when declaring constants of a struct type declared in an included thrift file 
Patch: Justin Judd (Revision 1410038)

     Result = SUCCESS
roger : http://svn.apache.org/viewvc/?view=rev&rev=1410038
Files : 
* /thrift/trunk/compiler/cpp/src/generate/t_py_generator.cc

                
> Generated Python code incorrect when declaring constants of a struct type declared in an included thrift file
> -------------------------------------------------------------------------------------------------------------
>
>                 Key: THRIFT-1747
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1747
>             Project: Thrift
>          Issue Type: Bug
>          Components: Python - Compiler
>            Reporter: Justin Judd
>         Attachments: python_structs.patch
>
>
> The python code produced when a constant is declared of a struct type that was declared in another thrift file does not contain the namespace information.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Resolved] (THRIFT-1747) Generated Python code incorrect when declaring constants of a struct type declared in an included thrift file

Posted by "Roger Meier (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/THRIFT-1747?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Roger Meier resolved THRIFT-1747.
---------------------------------

    Resolution: Fixed

Thanks Justin
                
> Generated Python code incorrect when declaring constants of a struct type declared in an included thrift file
> -------------------------------------------------------------------------------------------------------------
>
>                 Key: THRIFT-1747
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1747
>             Project: Thrift
>          Issue Type: Bug
>          Components: Python - Compiler
>            Reporter: Justin Judd
>         Attachments: python_structs.patch
>
>
> The python code produced when a constant is declared of a struct type that was declared in another thrift file does not contain the namespace information.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (THRIFT-1747) Generated Python code incorrect when declaring constants of a struct type declared in an included thrift file

Posted by "Justin Judd (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/THRIFT-1747?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Justin Judd updated THRIFT-1747:
--------------------------------

    Attachment: python_structs.patch

resolves the namespace for structs to be used in the generated constants file.
                
> Generated Python code incorrect when declaring constants of a struct type declared in an included thrift file
> -------------------------------------------------------------------------------------------------------------
>
>                 Key: THRIFT-1747
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1747
>             Project: Thrift
>          Issue Type: Bug
>          Components: Python - Compiler
>            Reporter: Justin Judd
>         Attachments: python_structs.patch
>
>
> The python code produced when a constant is declared of a struct type that was declared in another thrift file does not contain the namespace information.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira