You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2019/12/02 02:57:03 UTC

[GitHub] [incubator-doris] wuyunfeng commented on a change in pull request #2237: Optimize Doris On Elasticsearch performance

wuyunfeng commented on a change in pull request #2237: Optimize Doris On Elasticsearch performance
URL: https://github.com/apache/incubator-doris/pull/2237#discussion_r352403415
 
 

 ##########
 File path: be/src/exec/es/es_scroll_parser.cpp
 ##########
 @@ -233,17 +262,18 @@ int ScrollParser::get_total() {
 
 
 Status ScrollParser::fill_tuple(const TupleDescriptor* tuple_desc, 
-            Tuple* tuple, MemPool* tuple_pool, bool* line_eof) {
+            Tuple* tuple, MemPool* tuple_pool, bool* line_eof, const std::map<std::string, std::string>& docvalue_context) {
     *line_eof = true;
     if (_size <= 0 || _line_index >= _size) {
         return Status::OK();
     }
 
     const rapidjson::Value& obj = _inner_hits_node[_line_index++];
-    const rapidjson::Value& line = obj[FIELD_SOURCE];
-    if (!line.IsObject()) {
-        return Status::InternalError("Parse inner hits failed");
+    bool pure_doc_value = false;
 
 Review comment:
   Maybe need two function part if checked once

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org