You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by "Christopher Tubbs (JIRA)" <ji...@apache.org> on 2017/09/08 23:26:01 UTC
[jira] [Resolved] (ACCUMULO-4701) Shade Guava dependency
[ https://issues.apache.org/jira/browse/ACCUMULO-4701?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Christopher Tubbs resolved ACCUMULO-4701.
-----------------------------------------
Resolution: Won't Fix
I think this would create more problems than it solves. Dependency management/dependency convergence is a hard problem, but it is currently a problem left to downstream. The class path is ultimately the responsibility for the users deploying the software. I do not think Accumulo can, or should, take on the responsibility to handle all the bugs and compatibility issues which could arise in any one of our dependencies, which we've bundled into our project. It would also cause problems for users who are already doing their own dependency convergence, because then they would have to de-bundle.
I'm closing this issue for now, but my thoughts here are only my own. We have not discussed this much on the mailing lists. Feel free to open a dialogue at dev@accumulo.apache.org if you wish to discuss it further, as this would be a change with big implications, and would need to have some serious discussion/debate.
In the meantime, please also feel free to continue to comment here, with suggestions for mitigations. If you have a patch to do the shading, or some other workaround for dependency convergence, posting here could be useful for other users in this circumstance, even if we don't reopen the issue and apply it upstream.
> Shade Guava dependency
> ----------------------
>
> Key: ACCUMULO-4701
> URL: https://issues.apache.org/jira/browse/ACCUMULO-4701
> Project: Accumulo
> Issue Type: Improvement
> Components: build
> Affects Versions: 1.7.3
> Reporter: Piotr Findeisen
> Assignee: Christopher Tubbs
>
> [{{presto-accumulo}}|https://github.com/prestodb/presto/tree/master/presto-accumulo] connector embeds Accumulo client {{org.apache.accumulo:accumulo-core}}. Accumulo uses Guava. Since Guava APIs are not strictly backwards compatible, it's necessary to shade guava dependency or library users need to use same Guava version (i.e. cannot upgrade/downgrade at will).
> Please shade Guava dependency.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)