You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by "Isabelle Giguere (Jira)" <ji...@apache.org> on 2021/01/29 19:46:01 UTC

[jira] [Comment Edited] (SOLR-7642) Should launching Solr in cloud mode using a ZooKeeper chroot create the chroot znode if it doesn't exist?

    [ https://issues.apache.org/jira/browse/SOLR-7642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17275287#comment-17275287 ] 

Isabelle Giguere edited comment on SOLR-7642 at 1/29/21, 7:45 PM:
------------------------------------------------------------------

New patch, addressing [~janhoy] comments.

The patch needs refguide docs. 
- done

Should it also be documented in bin/solr -h? 
- done

Should "/solr" be an always-whitelisted path? 
- Not useful if -DcreateZkRoot=true, because any path will be ceated

Nipick: Consider terminology - is it zkRoot or zkChRoot? 
- Keeping 'createZkRoot' in the new patch.  It at least avoids changing scripts on our side ;)
- I'm not a fan of "chroot".  Doesn't 'ch' mean "change" ?  So "createZKChRoot" would mean "create the zookeeper change root" ?
- It could be createZkNode ?  createZkPath ?


I can't find the test class TestZkChroot.java in master branch, so, no unit test this time.


was (Author: igiguere):
New patch, adressing Jan's comments.

The patch needs refguide docs. 
- done

Should it also be documented in bin/solr -h? 
- done

Should "/solr" be an always-whitelisted path? 
- Not useful if -DcreateZkRoot=true, because any path will be ceated

Nipick: Consider terminology - is it zkRoot or zkChRoot? 
- Keeping 'createZkRoot' in the new patch.  It at least avoids changing scripts on our side ;)
- I'm not a fan of "chroot".  Doesn't 'ch' mean "change" ?  So "createZKChRoot" would mean "create the zookeeper change root" ?
- It could be createZkNode ?  createZkPath ?


I can't find the test class TestZkChroot.java in master branch, so, no unit test this time.

> Should launching Solr in cloud mode using a ZooKeeper chroot create the chroot znode if it doesn't exist?
> ---------------------------------------------------------------------------------------------------------
>
>                 Key: SOLR-7642
>                 URL: https://issues.apache.org/jira/browse/SOLR-7642
>             Project: Solr
>          Issue Type: Improvement
>            Reporter: Timothy Potter
>            Priority: Minor
>         Attachments: SOLR-7642.patch, SOLR-7642.patch, SOLR-7642.patch, SOLR-7642.patch, SOLR-7642_tag_7.5.0.patch, SOLR-7642_tag_7.5.0_proposition.patch
>
>
> If you launch Solr for the first time in cloud mode using a ZooKeeper connection string that includes a chroot leads to the following initialization error:
> {code}
> ERROR - 2015-06-05 17:15:50.410; [   ] org.apache.solr.common.SolrException; null:org.apache.solr.common.cloud.ZooKeeperException: A chroot was specified in ZkHost but the znode doesn't exist. localhost:2181/lan
>         at org.apache.solr.core.ZkContainer.initZooKeeper(ZkContainer.java:113)
>         at org.apache.solr.core.CoreContainer.load(CoreContainer.java:339)
>         at org.apache.solr.servlet.SolrDispatchFilter.createCoreContainer(SolrDispatchFilter.java:140)
>         at org.apache.solr.servlet.SolrDispatchFilter.init(SolrDispatchFilter.java:110)
>         at org.eclipse.jetty.servlet.FilterHolder.initialize(FilterHolder.java:138)
>         at org.eclipse.jetty.servlet.ServletHandler.initialize(ServletHandler.java:852)
>         at org.eclipse.jetty.servlet.ServletContextHandler.startContext(ServletContextHandler.java:298)
>         at org.eclipse.jetty.webapp.WebAppContext.startWebapp(WebAppContext.java:1349)
>         at org.eclipse.jetty.webapp.WebAppContext.startContext(WebAppContext.java:1342)
>         at org.eclipse.jetty.server.handler.ContextHandler.doStart(ContextHandler.java:741)
>         at org.eclipse.jetty.webapp.WebAppContext.doStart(WebAppContext.java:505)
> {code}
> The work-around for this is to use the scripts/cloud-scripts/zkcli.sh script to create the chroot znode (bootstrap action does this).
> I'm wondering if we shouldn't just create the znode if it doesn't exist? Or is that some violation of using a chroot?



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org