You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2022/02/09 07:42:08 UTC

[GitHub] [iceberg] amogh-jahagirdar opened a new pull request #4076: Nessie: Some minor cleanup. Consistent naming in LOG and fixing typo in UpdateableClassReference

amogh-jahagirdar opened a new pull request #4076:
URL: https://github.com/apache/iceberg/pull/4076


   Some minor code cleanup. We were using a mixed naming convention for logger, decided to use LOG (same as the other Iceberg modules). Renamed class name from UpdateableClassReference to UpdatableClassReference. This class does not look exposed in a public API and seems to be internal, so it seems okay to change, but let me know if I am missing something.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org

[GitHub] [iceberg] jackye1995 merged pull request #4076: Nessie: minor cleanup. Consistent naming in LOG and fixing typo in UpdateableClassReference

Posted by GitBox <gi...@apache.org>.
jackye1995 merged pull request #4076:
URL: https://github.com/apache/iceberg/pull/4076


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org

[GitHub] [iceberg] amogh-jahagirdar commented on pull request #4076: Nessie: minor cleanup. Consistent naming in LOG and fixing typo in UpdateableClassReference

Posted by GitBox <gi...@apache.org>.
amogh-jahagirdar commented on pull request #4076:
URL: https://github.com/apache/iceberg/pull/4076#issuecomment-1034012785


   > the LOG renaming changes LGTM, but I believe both spellings are correct/common. Either way I don't have any strong opinions on either spelling, so I'll let somebody else decide :)
   
   Sounds good! Yeah just something I noticed, I don't have a strong preference either, more so that it is consistent. Thanks for the quick look! 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org

[GitHub] [iceberg] amogh-jahagirdar edited a comment on pull request #4076: Nessie: minor cleanup. Consistent naming in LOG and fixing typo in UpdateableClassReference

Posted by GitBox <gi...@apache.org>.
amogh-jahagirdar edited a comment on pull request #4076:
URL: https://github.com/apache/iceberg/pull/4076#issuecomment-1034012785


   > the LOG renaming changes LGTM, but I believe both spellings are correct/common. Either way I don't have any strong opinions on either spelling, so I'll let somebody else decide :)
   
   Sounds good! Yeah just something I noticed, I don't have a strong preference either, more so that it is consistent.
   Did not know this about Updatable vs Updateable :) so I am also okay with either, whatever the community prefers. Thanks for the quick look! 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org

[GitHub] [iceberg] amogh-jahagirdar commented on pull request #4076: Nessie: minor cleanup. Consistent naming in LOG and fixing typo in UpdateableClassReference

Posted by GitBox <gi...@apache.org>.
amogh-jahagirdar commented on pull request #4076:
URL: https://github.com/apache/iceberg/pull/4076#issuecomment-1035085119


   Cool, removed the spelling change and just kept the logger change. Let me know what you think @nastra @jackye1995 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org