You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tomee.apache.org by db...@apache.org on 2008/04/04 11:39:54 UTC
svn commit: r644655 -
/openejb/trunk/openejb3/container/openejb-core/src/main/java/org/apache/openejb/core/transaction/TransactionPolicy.java
Author: dblevins
Date: Fri Apr 4 02:39:48 2008
New Revision: 644655
URL: http://svn.apache.org/viewvc?rev=644655&view=rev
Log:
Can't use initCause on a javax.transaction.TransactionRolledbackException.
Modified:
openejb/trunk/openejb3/container/openejb-core/src/main/java/org/apache/openejb/core/transaction/TransactionPolicy.java
Modified: openejb/trunk/openejb3/container/openejb-core/src/main/java/org/apache/openejb/core/transaction/TransactionPolicy.java
URL: http://svn.apache.org/viewvc/openejb/trunk/openejb3/container/openejb-core/src/main/java/org/apache/openejb/core/transaction/TransactionPolicy.java?rev=644655&r1=644654&r2=644655&view=diff
==============================================================================
--- openejb/trunk/openejb3/container/openejb-core/src/main/java/org/apache/openejb/core/transaction/TransactionPolicy.java (original)
+++ openejb/trunk/openejb3/container/openejb-core/src/main/java/org/apache/openejb/core/transaction/TransactionPolicy.java Fri Apr 4 02:39:48 2008
@@ -142,7 +142,8 @@
} catch (RollbackException e) {
txLogger.info("The transaction has been rolled back rather than commited: " + e.getMessage());
- Throwable txe = new javax.transaction.TransactionRolledbackException("Transaction was rolled back, presumably because setRollbackOnly was called during a synchronization").initCause(e);
+ // TODO can't set initCause on a TransactionRolledbackException, update the convertException and related code to handle something else
+ Throwable txe = new javax.transaction.TransactionRolledbackException("Transaction was rolled back, presumably because setRollbackOnly was called during a synchronization: "+e.getMessage());
throw new ApplicationException(txe);
} catch (HeuristicMixedException e) {
@@ -154,7 +155,7 @@
txLogger.info("A heuristic decision was made while commiting the transaction, some relevant updates have been rolled back: " + e.getMessage());
throw new ApplicationException(new RemoteException("A heuristic decision was made while commiting the transaction, some relevant updates have been rolled back").initCause(e));
-
+
} catch (SecurityException e) {
txLogger.error("The current thread is not allowed to commit the transaction: " + e.getMessage());
Re: svn commit: r644655 - /openejb/trunk/openejb3/container/openejb-core/src/main/java/org/apache/openejb/core/transaction/TransactionPolicy.java
Posted by Dain Sundstrom <da...@iq80.com>.
On Apr 4, 2008, at 3:24 AM, Jacek Laskowski wrote:
> On Fri, Apr 4, 2008 at 11:39 AM, <db...@apache.org> wrote:
>> Author: dblevins
>> Date: Fri Apr 4 02:39:48 2008
>> New Revision: 644655
>>
>> URL: http://svn.apache.org/viewvc?rev=644655&view=rev
>> Log:
>> Can't use initCause on a
>> javax.transaction.TransactionRolledbackException.
>
> Why?!
It's in the Java docs of remote exception (http://java.sun.com/j2se/1.5.0/docs/api/java/rmi/RemoteException.html
). The code should be changed to use the public "detail" field.
-dain
Re: svn commit: r644655 - /openejb/trunk/openejb3/container/openejb-core/src/main/java/org/apache/openejb/core/transaction/TransactionPolicy.java
Posted by Jacek Laskowski <ja...@laskowski.net.pl>.
On Fri, Apr 4, 2008 at 11:39 AM, <db...@apache.org> wrote:
> Author: dblevins
> Date: Fri Apr 4 02:39:48 2008
> New Revision: 644655
>
> URL: http://svn.apache.org/viewvc?rev=644655&view=rev
> Log:
> Can't use initCause on a javax.transaction.TransactionRolledbackException.
Why?!
Jacek
--
Jacek Laskowski
http://www.JacekLaskowski.pl