You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "89799969 (via GitHub)" <gi...@apache.org> on 2026/09/16 11:56:19 UTC
[PR] fix(topic): mark unknown consumer lag as metrics unavailable [rocketmq-dashboard]
89799969 opened a new pull request, #4371:
URL: https://github.com/apache/rocketmq-dashboard/pull/4371
## Summary
Fixes #4293
When any queue reports `ConsumerLagResolver.UNKNOWN`, `getTopicConsumersPage` published `diffTotal=-1` while leaving `metricsAvailable=true`. The topic page then rendered ??? as `-1` instead of ???.
Set `metricsAvailable(false)` when the sentinel is used, consistent with the exception path in the same method.
## Testing
- Extended `RocketMQMetadataProviderTest#getTopicConsumersKeepsUnknownWhenAnyQueueLagIsUnknown`
- `RocketMQMetadataProviderTest` + related alert/util tests: 55 passed locally
## AI disclosure
Implemented with the assistance of an AI coding agent.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(topic): mark unknown consumer lag as metrics unavailable [rocketmq-dashboard]
Posted by "89799969 (via GitHub)" <gi...@apache.org>.
89799969 commented on PR #4371:
URL: https://github.com/apache/rocketmq-dashboard/pull/4371#issuecomment-5886013484
Keep-alive: still interested in this fix and ready to rebase or adjust after review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(topic): mark unknown consumer lag as metrics unavailable [rocketmq-dashboard]
Posted by "89799969 (via GitHub)" <gi...@apache.org>.
89799969 commented on PR #4371:
URL: https://github.com/apache/rocketmq-dashboard/pull/4371#issuecomment-5864751452
Friendly ping — PR is up to date and ready for review. Please let me know if any changes are needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(topic): mark unknown consumer lag as metrics unavailable [rocketmq-dashboard]
Posted by "89799969 (via GitHub)" <gi...@apache.org>.
89799969 commented on PR #4371:
URL: https://github.com/apache/rocketmq-dashboard/pull/4371#issuecomment-6096367003
Keep-alive: rebased state unchanged and the fix is still current against master. Ready for review when a maintainer has time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(topic): mark unknown consumer lag as metrics unavailable [rocketmq-dashboard]
Posted by "89799969 (via GitHub)" <gi...@apache.org>.
89799969 commented on PR #4371:
URL: https://github.com/apache/rocketmq-dashboard/pull/4371#issuecomment-5809199036
Checking in — still relevant and ready for review. Happy to rebase or adjust if maintainers prefer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(topic): mark unknown consumer lag as metrics unavailable [rocketmq-dashboard]
Posted by "89799969 (via GitHub)" <gi...@apache.org>.
89799969 commented on PR #4371:
URL: https://github.com/apache/rocketmq-dashboard/pull/4371#issuecomment-5959272217
Keep-alive: rebased state unchanged and the fix is still current against master. Ready for review when a maintainer has time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org