You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@calcite.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/03/02 16:20:00 UTC

[jira] [Commented] (CALCITE-2199) AvaticaResultSet.getStatement() signature is missing SQLException

    [ https://issues.apache.org/jira/browse/CALCITE-2199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16383773#comment-16383773 ] 

ASF GitHub Bot commented on CALCITE-2199:
-----------------------------------------

GitHub user bcogrel opened a pull request:

    https://github.com/apache/calcite-avatica/pull/25

    [CALCITE-2199] AvaticaResultSet.getStatement() can now throw a SQLException

    See https://issues.apache.org/jira/browse/CALCITE-2199

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/bcogrel/calcite-avatica CALCITE-2199

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/calcite-avatica/pull/25.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #25
    
----
commit ece01794cb26c70bf5ebb072c2f809a262266402
Author: Benjamin Cogrel <be...@...>
Date:   2018-03-02T16:16:11Z

    [CALCITE-2199] AvaticaResultSet.getStatement() can now throw a SQLException.

----


> AvaticaResultSet.getStatement() signature is missing SQLException
> -----------------------------------------------------------------
>
>                 Key: CALCITE-2199
>                 URL: https://issues.apache.org/jira/browse/CALCITE-2199
>             Project: Calcite
>          Issue Type: Improvement
>          Components: avatica
>            Reporter: Benjamin Cogrel
>            Priority: Trivial
>
> Extensions of the AvaticaResultSet cannot throw a SQLException from the getStatement() method because this checked exception is not part of its signature.
> This forced the Dremio developers to wrapped their SQLException into a runtime exception:
> https://github.com/dremio/dremio-oss/blob/master/client/jdbc/src/main/java/com/dremio/jdbc/impl/DremioResultSetImpl.java#L1153
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)