You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by Joe Bowser <bo...@gmail.com> on 2014/05/20 20:03:48 UTC

[Android] 4.x branch

Hey

So, the more I look at what's happening in Android, the more things
that I see that we have to break, the more I want to create a 4.x
branch.  The reasons for this are obvious:

- LinearLayout vs RelativeLayout
- Pluggable Weviews
- Changing the App plugin to something else (CoreEvents, similar to Windows)
- Abstracting custom URIs OUT of WebViewClient/WebChromeClient for
shared logic (see the SMS/hangout bug)
- etc, etc

Basically, we're going to need to make some changes to Android.  We're
going to pass mobile spec and the JUnit tests, and everything will be
fine, but I think we really need to start putting these fixes in the
4.x branch and assume that we're going to land this in 4.0.

I'm thinking that we might want to do this with JS as well for those
changes as well, but I'm not sure.

Thoughts??

Joe

Re: [Android] 4.x branch

Posted by Andrew Grieve <ag...@chromium.org>.
Sounds good! Thanks Joe.


On Fri, May 23, 2014 at 5:27 PM, Joe Bowser <bo...@gmail.com> wrote:

> OK, I created the 4.x branch for the following work:
>
> - Pluggable Webview
> - Moving the App plugin
> - Abstracting the URI handling
>
> Basically the idea is to do changes on 4.x and then figure out how to
> ease them into master without breaking master.  Once we're getting
> ready for a major release, we can rebase this onto master and sync the
> two up.  I know we're supposed to do dev on master, but ideally this
> will let us do the prep-work without breaking things.
>
>
> On Fri, May 23, 2014 at 2:07 PM, Marc Weiner <mh...@gmail.com>
> wrote:
> > Very cool! Excited for 4.0. Can't wait! Much thanks to everyone involved.
> >
> > Marc
> >
> >
> > On Fri, May 23, 2014 at 1:56 PM, Joe Bowser <bo...@gmail.com> wrote:
> >
> >> On Fri, May 23, 2014 at 10:45 AM, Marc Weiner <mh...@gmail.com>
> >> wrote:
> >> > I'm not a committing member (yet), but +1 on this (I'm new to this
> list).
> >> > Makes sense to keep separate, if you're breaking things and changing
> the
> >> > API a lot. I'm really excited about pluggable webviews, (like, really
> >> > really excited). Just want to confirm, that means it would only work
> on
> >> > Android 4.0+, correct?
> >>
> >> No, it means that this will be on Cordova 4.x. We still test on
> >> Android 2.3, but not every WebView will have support for that.
> >>
>

Re: [Android] 4.x branch

Posted by Joe Bowser <bo...@gmail.com>.
OK, I created the 4.x branch for the following work:

- Pluggable Webview
- Moving the App plugin
- Abstracting the URI handling

Basically the idea is to do changes on 4.x and then figure out how to
ease them into master without breaking master.  Once we're getting
ready for a major release, we can rebase this onto master and sync the
two up.  I know we're supposed to do dev on master, but ideally this
will let us do the prep-work without breaking things.


On Fri, May 23, 2014 at 2:07 PM, Marc Weiner <mh...@gmail.com> wrote:
> Very cool! Excited for 4.0. Can't wait! Much thanks to everyone involved.
>
> Marc
>
>
> On Fri, May 23, 2014 at 1:56 PM, Joe Bowser <bo...@gmail.com> wrote:
>
>> On Fri, May 23, 2014 at 10:45 AM, Marc Weiner <mh...@gmail.com>
>> wrote:
>> > I'm not a committing member (yet), but +1 on this (I'm new to this list).
>> > Makes sense to keep separate, if you're breaking things and changing the
>> > API a lot. I'm really excited about pluggable webviews, (like, really
>> > really excited). Just want to confirm, that means it would only work on
>> > Android 4.0+, correct?
>>
>> No, it means that this will be on Cordova 4.x. We still test on
>> Android 2.3, but not every WebView will have support for that.
>>

Re: [Android] 4.x branch

Posted by Marc Weiner <mh...@gmail.com>.
Very cool! Excited for 4.0. Can't wait! Much thanks to everyone involved.

Marc


On Fri, May 23, 2014 at 1:56 PM, Joe Bowser <bo...@gmail.com> wrote:

> On Fri, May 23, 2014 at 10:45 AM, Marc Weiner <mh...@gmail.com>
> wrote:
> > I'm not a committing member (yet), but +1 on this (I'm new to this list).
> > Makes sense to keep separate, if you're breaking things and changing the
> > API a lot. I'm really excited about pluggable webviews, (like, really
> > really excited). Just want to confirm, that means it would only work on
> > Android 4.0+, correct?
>
> No, it means that this will be on Cordova 4.x. We still test on
> Android 2.3, but not every WebView will have support for that.
>

Re: [Android] 4.x branch

Posted by "Naik, Archana" <na...@lab126.com>.
Joe,

I am really excited to see this pluggable web view too. Is there a writeup
about it? I would like to know more and see if I can do similar for
amazon-fireos.

Archana

On 5/23/14 11:08 AM, "Michal Mocny" <mm...@chromium.org> wrote:

>Of *course* lets do it asap.  With the one caveat that we shouldn't ship
>until we are confident the API won't change *again* within a month and
>piss
>off devs, I think we should put all effort into this and ship asap.
>
>Also, the whole "4.0" thing is not a big deal any more.  Shipping one
>platform to 4.0 before the others is a good opportunity to signal our
>version/branding decoupling.
>
>-Michal
>
>
>On Fri, May 23, 2014 at 1:56 PM, Joe Bowser <bo...@gmail.com> wrote:
>
>> On Fri, May 23, 2014 at 10:45 AM, Marc Weiner <mh...@gmail.com>
>> wrote:
>> > I'm not a committing member (yet), but +1 on this (I'm new to this
>>list).
>> > Makes sense to keep separate, if you're breaking things and changing
>>the
>> > API a lot. I'm really excited about pluggable webviews, (like, really
>> > really excited). Just want to confirm, that means it would only work
>>on
>> > Android 4.0+, correct?
>>
>> No, it means that this will be on Cordova 4.x. We still test on
>> Android 2.3, but not every WebView will have support for that.
>>


Re: [Android] 4.x branch

Posted by Michal Mocny <mm...@chromium.org>.
Of *course* lets do it asap.  With the one caveat that we shouldn't ship
until we are confident the API won't change *again* within a month and piss
off devs, I think we should put all effort into this and ship asap.

Also, the whole "4.0" thing is not a big deal any more.  Shipping one
platform to 4.0 before the others is a good opportunity to signal our
version/branding decoupling.

-Michal


On Fri, May 23, 2014 at 1:56 PM, Joe Bowser <bo...@gmail.com> wrote:

> On Fri, May 23, 2014 at 10:45 AM, Marc Weiner <mh...@gmail.com>
> wrote:
> > I'm not a committing member (yet), but +1 on this (I'm new to this list).
> > Makes sense to keep separate, if you're breaking things and changing the
> > API a lot. I'm really excited about pluggable webviews, (like, really
> > really excited). Just want to confirm, that means it would only work on
> > Android 4.0+, correct?
>
> No, it means that this will be on Cordova 4.x. We still test on
> Android 2.3, but not every WebView will have support for that.
>

Re: [Android] 4.x branch

Posted by Joe Bowser <bo...@gmail.com>.
On Fri, May 23, 2014 at 10:45 AM, Marc Weiner <mh...@gmail.com> wrote:
> I'm not a committing member (yet), but +1 on this (I'm new to this list).
> Makes sense to keep separate, if you're breaking things and changing the
> API a lot. I'm really excited about pluggable webviews, (like, really
> really excited). Just want to confirm, that means it would only work on
> Android 4.0+, correct?

No, it means that this will be on Cordova 4.x. We still test on
Android 2.3, but not every WebView will have support for that.

Re: [Android] 4.x branch

Posted by Marc Weiner <mh...@gmail.com>.
I'm not a committing member (yet), but +1 on this (I'm new to this list).
Makes sense to keep separate, if you're breaking things and changing the
API a lot. I'm really excited about pluggable webviews, (like, really
really excited). Just want to confirm, that means it would only work on
Android 4.0+, correct? I'm already only targeting 4.0+ for my builds anyway
(we'll see how long that lasts). Also, somewhat unrelated, really excited
about the pretense that Apple might be improving Safari...hopefully that
means less bugs and better -webkit-overflow: touch support. Would be nice...

Marc


On Fri, May 23, 2014 at 1:16 PM, Joe Bowser <bo...@gmail.com> wrote:

> BUMP!
>
> Would like some more info/discussion before I create a new branch.
>
> On Wed, May 21, 2014 at 12:12 PM, Joe Bowser <bo...@gmail.com> wrote:
> > On Tue, May 20, 2014 at 11:43 AM, Ian Clelland <ic...@chromium.org>
> wrote:
> >> +1
> >>
> >> I think it's the right time to do this. I'm certainly motivated by
> >> pluggable webviews, and if we're going to break things, then lets do
> them
> >> all at once. (And write a good upgrade guide :) )
> >>
> >> We can create a 4.x branch at the same point as the 3.6.x branch, and
> merge
> >> upstream changes in until it's ready for release as 4.0.0.
> >>
> >
> > Sounds good for the most part.  I'm worried about changes to
> > CordovaWebView, CordovaChromeClient and CordovaWebViewClient, since
> > every webview needs to implement their own logic.  Perhaps we should
> > work on having helper classes for certain things like custom URIs.
> >
> >> JS is a good question -- we had to make a lot of coordinated changes
> >> between the platforms and the common JS code for Cordova 3.0; is there a
> >> similar call for JS changes with 4.0? That is, are there cross-platform
> >> concerns with a 4.0 release; interfaces that all platforms will need to
> >> conform to?
> >>
> >
> > I know that there's a change that Android needs to make to the built
> > in app plugin.  This is a big API change, since this changes how the
> > back button works, and apparently it's impossible to do this without
> > it breaking everything.  I think this has to do with Browserify, but
> > I'm not sure.  If someone can comment on this, that'd be great.
> >
> >> Along those lines, are there other cross-platform features that we want
> to
> >> start working on, that would prompt a 4.0 release of other platforms as
> >> well? Or is this where we start getting serious about
> >> independently-released platforms?
> >>
> >
> > Good question.  I have no idea.
> >
> >
> >>
> >> On Tue, May 20, 2014 at 2:03 PM, Joe Bowser <bo...@gmail.com> wrote:
> >>
> >>> Hey
> >>>
> >>> So, the more I look at what's happening in Android, the more things
> >>> that I see that we have to break, the more I want to create a 4.x
> >>> branch.  The reasons for this are obvious:
> >>>
> >>> - LinearLayout vs RelativeLayout
> >>> - Pluggable Weviews
> >>> - Changing the App plugin to something else (CoreEvents, similar to
> >>> Windows)
> >>> - Abstracting custom URIs OUT of WebViewClient/WebChromeClient for
> >>> shared logic (see the SMS/hangout bug)
> >>> - etc, etc
> >>>
> >>> Basically, we're going to need to make some changes to Android.  We're
> >>> going to pass mobile spec and the JUnit tests, and everything will be
> >>> fine, but I think we really need to start putting these fixes in the
> >>> 4.x branch and assume that we're going to land this in 4.0.
> >>>
> >>> I'm thinking that we might want to do this with JS as well for those
> >>> changes as well, but I'm not sure.
> >>>
> >>> Thoughts??
> >>>
> >>> Joe
> >>>
>

Re: [Android] 4.x branch

Posted by Joe Bowser <bo...@gmail.com>.
BUMP!

Would like some more info/discussion before I create a new branch.

On Wed, May 21, 2014 at 12:12 PM, Joe Bowser <bo...@gmail.com> wrote:
> On Tue, May 20, 2014 at 11:43 AM, Ian Clelland <ic...@chromium.org> wrote:
>> +1
>>
>> I think it's the right time to do this. I'm certainly motivated by
>> pluggable webviews, and if we're going to break things, then lets do them
>> all at once. (And write a good upgrade guide :) )
>>
>> We can create a 4.x branch at the same point as the 3.6.x branch, and merge
>> upstream changes in until it's ready for release as 4.0.0.
>>
>
> Sounds good for the most part.  I'm worried about changes to
> CordovaWebView, CordovaChromeClient and CordovaWebViewClient, since
> every webview needs to implement their own logic.  Perhaps we should
> work on having helper classes for certain things like custom URIs.
>
>> JS is a good question -- we had to make a lot of coordinated changes
>> between the platforms and the common JS code for Cordova 3.0; is there a
>> similar call for JS changes with 4.0? That is, are there cross-platform
>> concerns with a 4.0 release; interfaces that all platforms will need to
>> conform to?
>>
>
> I know that there's a change that Android needs to make to the built
> in app plugin.  This is a big API change, since this changes how the
> back button works, and apparently it's impossible to do this without
> it breaking everything.  I think this has to do with Browserify, but
> I'm not sure.  If someone can comment on this, that'd be great.
>
>> Along those lines, are there other cross-platform features that we want to
>> start working on, that would prompt a 4.0 release of other platforms as
>> well? Or is this where we start getting serious about
>> independently-released platforms?
>>
>
> Good question.  I have no idea.
>
>
>>
>> On Tue, May 20, 2014 at 2:03 PM, Joe Bowser <bo...@gmail.com> wrote:
>>
>>> Hey
>>>
>>> So, the more I look at what's happening in Android, the more things
>>> that I see that we have to break, the more I want to create a 4.x
>>> branch.  The reasons for this are obvious:
>>>
>>> - LinearLayout vs RelativeLayout
>>> - Pluggable Weviews
>>> - Changing the App plugin to something else (CoreEvents, similar to
>>> Windows)
>>> - Abstracting custom URIs OUT of WebViewClient/WebChromeClient for
>>> shared logic (see the SMS/hangout bug)
>>> - etc, etc
>>>
>>> Basically, we're going to need to make some changes to Android.  We're
>>> going to pass mobile spec and the JUnit tests, and everything will be
>>> fine, but I think we really need to start putting these fixes in the
>>> 4.x branch and assume that we're going to land this in 4.0.
>>>
>>> I'm thinking that we might want to do this with JS as well for those
>>> changes as well, but I'm not sure.
>>>
>>> Thoughts??
>>>
>>> Joe
>>>

Re: [Android] 4.x branch

Posted by Joe Bowser <bo...@gmail.com>.
On Tue, May 20, 2014 at 11:43 AM, Ian Clelland <ic...@chromium.org> wrote:
> +1
>
> I think it's the right time to do this. I'm certainly motivated by
> pluggable webviews, and if we're going to break things, then lets do them
> all at once. (And write a good upgrade guide :) )
>
> We can create a 4.x branch at the same point as the 3.6.x branch, and merge
> upstream changes in until it's ready for release as 4.0.0.
>

Sounds good for the most part.  I'm worried about changes to
CordovaWebView, CordovaChromeClient and CordovaWebViewClient, since
every webview needs to implement their own logic.  Perhaps we should
work on having helper classes for certain things like custom URIs.

> JS is a good question -- we had to make a lot of coordinated changes
> between the platforms and the common JS code for Cordova 3.0; is there a
> similar call for JS changes with 4.0? That is, are there cross-platform
> concerns with a 4.0 release; interfaces that all platforms will need to
> conform to?
>

I know that there's a change that Android needs to make to the built
in app plugin.  This is a big API change, since this changes how the
back button works, and apparently it's impossible to do this without
it breaking everything.  I think this has to do with Browserify, but
I'm not sure.  If someone can comment on this, that'd be great.

> Along those lines, are there other cross-platform features that we want to
> start working on, that would prompt a 4.0 release of other platforms as
> well? Or is this where we start getting serious about
> independently-released platforms?
>

Good question.  I have no idea.


>
> On Tue, May 20, 2014 at 2:03 PM, Joe Bowser <bo...@gmail.com> wrote:
>
>> Hey
>>
>> So, the more I look at what's happening in Android, the more things
>> that I see that we have to break, the more I want to create a 4.x
>> branch.  The reasons for this are obvious:
>>
>> - LinearLayout vs RelativeLayout
>> - Pluggable Weviews
>> - Changing the App plugin to something else (CoreEvents, similar to
>> Windows)
>> - Abstracting custom URIs OUT of WebViewClient/WebChromeClient for
>> shared logic (see the SMS/hangout bug)
>> - etc, etc
>>
>> Basically, we're going to need to make some changes to Android.  We're
>> going to pass mobile spec and the JUnit tests, and everything will be
>> fine, but I think we really need to start putting these fixes in the
>> 4.x branch and assume that we're going to land this in 4.0.
>>
>> I'm thinking that we might want to do this with JS as well for those
>> changes as well, but I'm not sure.
>>
>> Thoughts??
>>
>> Joe
>>

Re: [Android] 4.x branch

Posted by Ian Clelland <ic...@chromium.org>.
+1

I think it's the right time to do this. I'm certainly motivated by
pluggable webviews, and if we're going to break things, then lets do them
all at once. (And write a good upgrade guide :) )

We can create a 4.x branch at the same point as the 3.6.x branch, and merge
upstream changes in until it's ready for release as 4.0.0.

JS is a good question -- we had to make a lot of coordinated changes
between the platforms and the common JS code for Cordova 3.0; is there a
similar call for JS changes with 4.0? That is, are there cross-platform
concerns with a 4.0 release; interfaces that all platforms will need to
conform to?

Along those lines, are there other cross-platform features that we want to
start working on, that would prompt a 4.0 release of other platforms as
well? Or is this where we start getting serious about
independently-released platforms?


On Tue, May 20, 2014 at 2:03 PM, Joe Bowser <bo...@gmail.com> wrote:

> Hey
>
> So, the more I look at what's happening in Android, the more things
> that I see that we have to break, the more I want to create a 4.x
> branch.  The reasons for this are obvious:
>
> - LinearLayout vs RelativeLayout
> - Pluggable Weviews
> - Changing the App plugin to something else (CoreEvents, similar to
> Windows)
> - Abstracting custom URIs OUT of WebViewClient/WebChromeClient for
> shared logic (see the SMS/hangout bug)
> - etc, etc
>
> Basically, we're going to need to make some changes to Android.  We're
> going to pass mobile spec and the JUnit tests, and everything will be
> fine, but I think we really need to start putting these fixes in the
> 4.x branch and assume that we're going to land this in 4.0.
>
> I'm thinking that we might want to do this with JS as well for those
> changes as well, but I'm not sure.
>
> Thoughts??
>
> Joe
>