You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2022/09/07 21:10:01 UTC

[kudu-CR] [scripts] add HTTP address option for start kudu.sh

Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18948


Change subject: [scripts] add HTTP address option for start_kudu.sh
......................................................................

[scripts] add HTTP address option for start_kudu.sh

This patch adds a new option to customize the IP address of the Kudu's
embedded HTTP server.  A couple of usage examples:

   ../../src/kudu/scripts/start_kudu.sh --webhost 192.168.1.37
   ../../src/kudu/scripts/start_kudu.sh -W 192.168.1.37

I also took the liberty to update the description of some flags and
update the naming of the flags to specify the port numbers for the RPC
and the HTTP endpoints, while keeping the script backwards-compatible
(i.e. it still understands the prior naming of the corresponding flags):

  * rpc-master  --> rpc-port-master
  * rpc-tserver --> rpc-port-tserver

Change-Id: I468499c5df56e958f926053d485b7d0a08c63905
---
M src/kudu/scripts/start_kudu.sh
1 file changed, 21 insertions(+), 13 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/48/18948/1
-- 
To view, visit http://gerrit.cloudera.org:8080/18948
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I468499c5df56e958f926053d485b7d0a08c63905
Gerrit-Change-Number: 18948
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>

[kudu-CR] [scripts] add HTTP address option for start kudu.sh

Posted by "Yifan Zhang (Code Review)" <ge...@cloudera.org>.
Yifan Zhang has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18948 )

Change subject: [scripts] add HTTP address option for start_kudu.sh
......................................................................

[scripts] add HTTP address option for start_kudu.sh

This patch adds a new option to customize the IP address of the Kudu's
embedded HTTP server.  A couple of usage examples:

   ../../src/kudu/scripts/start_kudu.sh --webhost 192.168.1.37
   ../../src/kudu/scripts/start_kudu.sh -W 192.168.1.37

I also took the liberty to update the description of the flags to add
default values for each and update the naming of the flags that specify
the port numbers for the RPC and the HTTP endpoints while keeping the
script backwards-compatible
(i.e. it still understands the prior naming of the corresponding flags):

  * rpc-master  --> rpc-port-master
  * rpc-tserver --> rpc-port-tserver

Change-Id: I468499c5df56e958f926053d485b7d0a08c63905
Reviewed-on: http://gerrit.cloudera.org:8080/18948
Tested-by: Kudu Jenkins
Reviewed-by: Yifan Zhang <ch...@163.com>
---
M src/kudu/scripts/start_kudu.sh
1 file changed, 50 insertions(+), 31 deletions(-)

Approvals:
  Kudu Jenkins: Verified
  Yifan Zhang: Looks good to me, approved

-- 
To view, visit http://gerrit.cloudera.org:8080/18948
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I468499c5df56e958f926053d485b7d0a08c63905
Gerrit-Change-Number: 18948
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>

[kudu-CR] [scripts] add HTTP address option for start kudu.sh

Posted by "Yifan Zhang (Code Review)" <ge...@cloudera.org>.
Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/18948 )

Change subject: [scripts] add HTTP address option for start_kudu.sh
......................................................................


Patch Set 1: Code-Review+2

(1 comment)

http://gerrit.cloudera.org:8080/#/c/18948/1/src/kudu/scripts/start_kudu.sh
File src/kudu/scripts/start_kudu.sh:

http://gerrit.cloudera.org:8080/#/c/18948/1/src/kudu/scripts/start_kudu.sh@43
PS1, Line 43: -c, --clusterdir    Path to place Masters' and Tablet Servers' data and logs
nit: Maybe the default value of builddir and clusterdir also need to add?



-- 
To view, visit http://gerrit.cloudera.org:8080/18948
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I468499c5df56e958f926053d485b7d0a08c63905
Gerrit-Change-Number: 18948
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Comment-Date: Thu, 08 Sep 2022 03:41:37 +0000
Gerrit-HasComments: Yes

[kudu-CR] [scripts] add HTTP address option for start kudu.sh

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18948 )

Change subject: [scripts] add HTTP address option for start_kudu.sh
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/18948/1/src/kudu/scripts/start_kudu.sh
File src/kudu/scripts/start_kudu.sh:

http://gerrit.cloudera.org:8080/#/c/18948/1/src/kudu/scripts/start_kudu.sh@43
PS1, Line 43: -c, --clusterdir    Path to place Masters' and Tablet Servers' data and logs
> nit: Maybe the default value of builddir and clusterdir also need to add?
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/18948
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I468499c5df56e958f926053d485b7d0a08c63905
Gerrit-Change-Number: 18948
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Comment-Date: Thu, 08 Sep 2022 20:08:17 +0000
Gerrit-HasComments: Yes

[kudu-CR] [scripts] add HTTP address option for start kudu.sh

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Yifan Zhang, Kudu Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/18948

to look at the new patch set (#2).

Change subject: [scripts] add HTTP address option for start_kudu.sh
......................................................................

[scripts] add HTTP address option for start_kudu.sh

This patch adds a new option to customize the IP address of the Kudu's
embedded HTTP server.  A couple of usage examples:

   ../../src/kudu/scripts/start_kudu.sh --webhost 192.168.1.37
   ../../src/kudu/scripts/start_kudu.sh -W 192.168.1.37

I also took the liberty to update the description of the flags to add
default values for each and update the naming of the flags that specify
the port numbers for the RPC and the HTTP endpoints while keeping the
script backwards-compatible
(i.e. it still understands the prior naming of the corresponding flags):

  * rpc-master  --> rpc-port-master
  * rpc-tserver --> rpc-port-tserver

Change-Id: I468499c5df56e958f926053d485b7d0a08c63905
---
M src/kudu/scripts/start_kudu.sh
1 file changed, 50 insertions(+), 31 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/48/18948/2
-- 
To view, visit http://gerrit.cloudera.org:8080/18948
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I468499c5df56e958f926053d485b7d0a08c63905
Gerrit-Change-Number: 18948
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>

[kudu-CR] [scripts] add HTTP address option for start kudu.sh

Posted by "Yifan Zhang (Code Review)" <ge...@cloudera.org>.
Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/18948 )

Change subject: [scripts] add HTTP address option for start_kudu.sh
......................................................................


Patch Set 2: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/18948
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I468499c5df56e958f926053d485b7d0a08c63905
Gerrit-Change-Number: 18948
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Comment-Date: Fri, 09 Sep 2022 01:34:27 +0000
Gerrit-HasComments: No