You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Bert Huijben <be...@qqmail.nl> on 2014/01/27 00:48:56 UTC

RE: svn commit: r1561570 - /subversion/trunk/subversion/libsvn_ra_svn/marshal.c


> -----Original Message-----
> From: stefan2@apache.org [mailto:stefan2@apache.org]
> Sent: maandag 27 januari 2014 00:00
> To: commits@subversion.apache.org
> Subject: svn commit: r1561570 -
> /subversion/trunk/subversion/libsvn_ra_svn/marshal.c
> 
> Author: stefan2
> Date: Sun Jan 26 22:59:29 2014
> New Revision: 1561570
> 
> URL: http://svn.apache.org/r1561570
> Log:
> Remove false protocol limit checks from the ra_svn marshaller.
> 
> * subversion/libsvn_ra_svn/marshal.c
>   (svn_ra_svn__read_data_log_changed_entry): Remove upper limit
>    check for variable length elements as they may be extended by
>    later releases.

I don't think we can change these entries without a time machine if these limits were coded in previously released versions?

Were these checks added for 1.9?

	Bert

Re: svn commit: r1561570 - /subversion/trunk/subversion/libsvn_ra_svn/marshal.c

Posted by Stefan Fuhrmann <st...@wandisco.com>.
On Mon, Jan 27, 2014 at 12:48 AM, Bert Huijben <be...@qqmail.nl> wrote:

>
>
> > -----Original Message-----
> > From: stefan2@apache.org [mailto:stefan2@apache.org]
> > Sent: maandag 27 januari 2014 00:00
> > To: commits@subversion.apache.org
> > Subject: svn commit: r1561570 -
> > /subversion/trunk/subversion/libsvn_ra_svn/marshal.c
> >
> > Author: stefan2
> > Date: Sun Jan 26 22:59:29 2014
> > New Revision: 1561570
> >
> > URL: http://svn.apache.org/r1561570
> > Log:
> > Remove false protocol limit checks from the ra_svn marshaller.
> >
> > * subversion/libsvn_ra_svn/marshal.c
> >   (svn_ra_svn__read_data_log_changed_entry): Remove upper limit
> >    check for variable length elements as they may be extended by
> >    later releases.
>
> I don't think we can change these entries without a time machine if these
> limits were coded in previously released versions?
>
> Were these checks added for 1.9?
>

Yes, they had and those checks were too strict. The protocol
allows for adding an unlimited number of optional elements.

-- Stefan^2.