You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2020/07/08 15:43:08 UTC
[GitHub] [trafficcontrol] rob05c commented on a change in pull request #4842: Extract grove dependency
rob05c commented on a change in pull request #4842:
URL: https://github.com/apache/trafficcontrol/pull/4842#discussion_r451643206
##########
File path: traffic_ops/client/session.go
##########
@@ -369,12 +368,18 @@ func (to *Session) RawRequest(method, path string, body []byte, header http.Head
if err != nil {
return nil, remoteAddr, err
}
+ if header != nil {
Review comment:
Nitpick: these nil checks aren't necessary, because `http.Header.Clone` is defined to:
> Clone returns a copy of h or nil if h is nil.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org