[GitHub] [cassandra] michaelsembwever commented on pull request #1891: Cassandra 14227 trunk

["michaelsembwever (via GitHub)" <gi...@apache.org>]

michaelsembwever commented on PR #1891:
URL: https://github.com/apache/cassandra/pull/1891#issuecomment-1479777744

   >  I think VERSION_41 was briefly added to 4.1 but never really used, so it has been removed in 5.0.
   
   Correct. There was a change in the tests that introduced _41, but it was agreed that _41 could be removed (that we didn't need to provide compatibility between test runs within a development cycle).
   
   
   > However, I see that VERSION_41 is [still present on cassandra-4.1](https://github.com/apache/cassandra/blob/cassandra-4.1.1/src/java/org/apache/cassandra/net/MessagingService.java#L211), and [also in cassandra-4.1.1](https://github.com/apache/cassandra/blob/cassandra-4.1.1/src/java/org/apache/cassandra/net/MessagingService.java#L211). @michaelsembwever shouldn't we remove it also from cassandra-4.1?
   
   Both links are same. But yes, _41 should be removed from 4.1 too (my bad), you can see (in the same class) that it's not actually used.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org