You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2022/03/08 04:43:05 UTC

[GitHub] [cloudstack] Pearl1594 opened a new pull request #6069: Adapt script to bash version 3

Pearl1594 opened a new pull request #6069:
URL: https://github.com/apache/cloudstack/pull/6069


   ### Description
   
   This PR fixes: https://github.com/apache/cloudstack/issues/6060
   Bash version 3 does not have support for associative arrays. Hence during the packaging phase the metadata.ini file created (on osx) isn't in proper format as the script used to generate it i.e., templateConfig.sh made use of associative arrays - which is supported from bash v4 onward. This eventually leads failure to deploy DB on OSX.
   
   This PR modifies the script to work on systems using bash v3. 
   <!--- Describe your changes in DETAIL - And how has behaviour functionally changed. -->
   
   <!-- For new features, provide link to FS, dev ML discussion etc. -->
   <!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
   
   <!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
   <!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
   <!-- Fixes: # -->
   
   <!--- ********************************************************************************* -->
   <!--- NOTE: AUTOMATATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. -->
   <!--- PLEASE PUT AN 'X' in only **ONE** box -->
   <!--- ********************************************************************************* -->
   
   ### Types of changes
   
   - [ ] Breaking change (fix or feature that would cause existing functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [X] Bug fix (non-breaking change which fixes an issue)
   - [ ] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ### Feature/Enhancement Scale or Bug Severity
   
   #### Bug Severity
   
   - [ ] BLOCKER
   - [ ] Critical
   - [ ] Major
   - [X] Minor
   - [ ] Trivial
   
   
   ### Screenshots (if appropriate):
   
   
   ### How Has This Been Tested?
   
   
   
   <!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] rohityadavcloud commented on pull request #6069: Adapt script to bash version 3

Posted by GitBox <gi...@apache.org>.

rohityadavcloud commented on pull request #6069:
URL: https://github.com/apache/cloudstack/pull/6069#issuecomment-1061575224


   @blueorangutan test


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] rohityadavcloud commented on pull request #6069: Adapt script to bash version 3

Posted by GitBox <gi...@apache.org>.

rohityadavcloud commented on pull request #6069:
URL: https://github.com/apache/cloudstack/pull/6069#issuecomment-1062168990


   Failures unrelated. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] rohityadavcloud merged pull request #6069: Adapt script to bash version 3

Posted by GitBox <gi...@apache.org>.

rohityadavcloud merged pull request #6069:
URL: https://github.com/apache/cloudstack/pull/6069


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #6069: Adapt script to bash version 3

Posted by GitBox <gi...@apache.org>.

blueorangutan commented on pull request #6069:
URL: https://github.com/apache/cloudstack/pull/6069#issuecomment-1061570794


   Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 2793


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #6069: Adapt script to bash version 3

Posted by GitBox <gi...@apache.org>.

blueorangutan commented on pull request #6069:
URL: https://github.com/apache/cloudstack/pull/6069#issuecomment-1061577007


   @rohityadavcloud a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] rohityadavcloud commented on pull request #6069: Adapt script to bash version 3

Posted by GitBox <gi...@apache.org>.

rohityadavcloud commented on pull request #6069:
URL: https://github.com/apache/cloudstack/pull/6069#issuecomment-1061602554


   Tested full build, deploydb (against simulator) and UI/dev workflow on osx. With this script, OSX may now be used as a build-dev-test env.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #6069: Adapt script to bash version 3

Posted by GitBox <gi...@apache.org>.

blueorangutan commented on pull request #6069:
URL: https://github.com/apache/cloudstack/pull/6069#issuecomment-1061541730


   @Pearl1594 a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] Pearl1594 commented on pull request #6069: Adapt script to bash version 3

Posted by GitBox <gi...@apache.org>.

Pearl1594 commented on pull request #6069:
URL: https://github.com/apache/cloudstack/pull/6069#issuecomment-1061541315


   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #6069: Adapt script to bash version 3

Posted by GitBox <gi...@apache.org>.

blueorangutan commented on pull request #6069:
URL: https://github.com/apache/cloudstack/pull/6069#issuecomment-1062167726


   <b>Trillian test result (tid-3525)</b>
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 37250 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6069-t3525-kvm-centos7.zip
   Smoke tests completed. 90 look OK, 2 have errors
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_01_vpc_site2site_vpn_multiple_options | `Failure` | 518.53 | test_vpc_vpn.py
   test_01_invalid_upgrade_kubernetes_cluster | `Failure` | 53.01 | test_kubernetes_clusters.py
   ContextSuite context=TestKubernetesCluster>:teardown | `Error` | 90.61 | test_kubernetes_clusters.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org