You are viewing a plain text version of this content. The canonical link for it is here.
Posted to java-dev@axis.apache.org by "Sergey Vladimirov (JIRA)" <ji...@apache.org> on 2008/06/16 17:55:45 UTC
[jira] Created: (AXIS2-3862) ListenerManager::startedTransports is
not visible to child classes
ListenerManager::startedTransports is not visible to child classes
------------------------------------------------------------------
Key: AXIS2-3862
URL: https://issues.apache.org/jira/browse/AXIS2-3862
Project: Axis 2.0 (Axis2)
Issue Type: Bug
Reporter: Sergey Vladimirov
Field ListenerManager::startedTransports is not visible to child classes - not possible to override start() method.
Should be protected
In fact, "stopped" also should be public to override stop() method.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: axis-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-dev-help@ws.apache.org
[jira] Updated: (AXIS2-3862) ListenerManager::startedTransports is
not visible to child classes
Posted by "Sergey Vladimirov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AXIS2-3862?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sergey Vladimirov updated AXIS2-3862:
-------------------------------------
Attachment: patch.txt
Also, startTransports() method is extracted in different method - I need to overload start() method to disable (or change) shutdown hook - and don't want to copy the whole method.
> ListenerManager::startedTransports is not visible to child classes
> ------------------------------------------------------------------
>
> Key: AXIS2-3862
> URL: https://issues.apache.org/jira/browse/AXIS2-3862
> Project: Axis 2.0 (Axis2)
> Issue Type: Bug
> Reporter: Sergey Vladimirov
> Attachments: patch.txt
>
>
> Field ListenerManager::startedTransports is not visible to child classes - not possible to override start() method.
> Should be protected
> In fact, "stopped" also should be public to override stop() method.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: axis-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-dev-help@ws.apache.org
[jira] Resolved: (AXIS2-3862) ListenerManager::startedTransports is
not visible to child classes
Posted by "Andreas Veithen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AXIS2-3862?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andreas Veithen resolved AXIS2-3862.
------------------------------------
Resolution: Invalid
> ListenerManager::startedTransports is not visible to child classes
> ------------------------------------------------------------------
>
> Key: AXIS2-3862
> URL: https://issues.apache.org/jira/browse/AXIS2-3862
> Project: Axis 2.0 (Axis2)
> Issue Type: Bug
> Reporter: Sergey Vladimirov
> Attachments: patch.txt
>
>
> Field ListenerManager::startedTransports is not visible to child classes - not possible to override start() method.
> Should be protected
> In fact, "stopped" also should be public to override stop() method.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (AXIS2-3862) ListenerManager::startedTransports
is not visible to child classes
Posted by "Andreas Veithen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AXIS2-3862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12605452#action_12605452 ]
Andreas Veithen commented on AXIS2-3862:
----------------------------------------
This should not be required if the shutdown hook is removed in ListenerManager#stop (see AXIS2-3861).
> ListenerManager::startedTransports is not visible to child classes
> ------------------------------------------------------------------
>
> Key: AXIS2-3862
> URL: https://issues.apache.org/jira/browse/AXIS2-3862
> Project: Axis 2.0 (Axis2)
> Issue Type: Bug
> Reporter: Sergey Vladimirov
> Attachments: patch.txt
>
>
> Field ListenerManager::startedTransports is not visible to child classes - not possible to override start() method.
> Should be protected
> In fact, "stopped" also should be public to override stop() method.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: axis-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-dev-help@ws.apache.org
[jira] Commented: (AXIS2-3862) ListenerManager::startedTransports
is not visible to child classes
Posted by "Andreas Veithen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AXIS2-3862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12606283#action_12606283 ]
Andreas Veithen commented on AXIS2-3862:
----------------------------------------
Making startedTransports protected mean exposing an internal data structure to subclasses. Many people consider this as a bad practice, unless there are very good reasons to do so. Also having protected members means that you can't modify the related code without the risk of breaking other people's code.
> ListenerManager::startedTransports is not visible to child classes
> ------------------------------------------------------------------
>
> Key: AXIS2-3862
> URL: https://issues.apache.org/jira/browse/AXIS2-3862
> Project: Axis 2.0 (Axis2)
> Issue Type: Bug
> Reporter: Sergey Vladimirov
> Attachments: patch.txt
>
>
> Field ListenerManager::startedTransports is not visible to child classes - not possible to override start() method.
> Should be protected
> In fact, "stopped" also should be public to override stop() method.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: axis-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-dev-help@ws.apache.org
[jira] Commented: (AXIS2-3862) ListenerManager::startedTransports
is not visible to child classes
Posted by "Sergey Vladimirov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AXIS2-3862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12606272#action_12606272 ]
Sergey Vladimirov commented on AXIS2-3862:
------------------------------------------
But it won't be bad, will it?
> ListenerManager::startedTransports is not visible to child classes
> ------------------------------------------------------------------
>
> Key: AXIS2-3862
> URL: https://issues.apache.org/jira/browse/AXIS2-3862
> Project: Axis 2.0 (Axis2)
> Issue Type: Bug
> Reporter: Sergey Vladimirov
> Attachments: patch.txt
>
>
> Field ListenerManager::startedTransports is not visible to child classes - not possible to override start() method.
> Should be protected
> In fact, "stopped" also should be public to override stop() method.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: axis-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-dev-help@ws.apache.org