You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tomee.apache.org by ge...@apache.org on 2011/05/26 05:37:03 UTC

svn commit: r1127769 - /openejb/trunk/openejb3/container/openejb-core/src/main/java/org/apache/openejb/config/rules/CheckCallbacks.java

Author: genspring
Date: Thu May 26 03:37:02 2011
New Revision: 1127769

URL: http://svn.apache.org/viewvc?rev=1127769&view=rev
Log:
OPENEJB-1554 PostConstruct callback should be allowed in stateful session bean.

Modified:
    openejb/trunk/openejb3/container/openejb-core/src/main/java/org/apache/openejb/config/rules/CheckCallbacks.java

Modified: openejb/trunk/openejb3/container/openejb-core/src/main/java/org/apache/openejb/config/rules/CheckCallbacks.java
URL: http://svn.apache.org/viewvc/openejb/trunk/openejb3/container/openejb-core/src/main/java/org/apache/openejb/config/rules/CheckCallbacks.java?rev=1127769&r1=1127768&r2=1127769&view=diff
==============================================================================
--- openejb/trunk/openejb3/container/openejb-core/src/main/java/org/apache/openejb/config/rules/CheckCallbacks.java (original)
+++ openejb/trunk/openejb3/container/openejb-core/src/main/java/org/apache/openejb/config/rules/CheckCallbacks.java Thu May 26 03:37:02 2011
@@ -324,13 +324,11 @@ public class CheckCallbacks extends Vali
                     if (!callback.getMethodName().equals("ejbPassivate"))
                         fail(bean.getEjbName(), "callback.sessionbean.invalidusage", type, callback.getMethodName(), ejbClass);
                 } else if ("PostConstruct".equals(type)) {
-                    if (sb.getSessionType().equals(SessionType.STATELESS)) {
-                        if (!callback.getMethodName().equals("ejbCreate")) {
-                            fail(bean.getEjbName(), "callback.sessionbean.invalidusage", type, callback.getMethodName(), ejbClass);
-                        }
-                    } else {
+
+                    if (!callback.getMethodName().equals("ejbCreate")) {
                         fail(bean.getEjbName(), "callback.sessionbean.invalidusage", type, callback.getMethodName(), ejbClass);
                     }
+
                 }
                 // @AfterCompletion, @BeforeCompletion and @AfterBegin are assumed to be allowed to be used on Stateful bean implementing javax.ejb.SessionBean
             }