You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "Chesnay Schepler (JIRA)" <ji...@apache.org> on 2019/07/18 10:01:00 UTC

[jira] [Closed] (FLINK-13281) Fix the verify logic of AdaptedRestartPipelinedRegionStrategyNGAbortPendingCheckpointsTest

     [ https://issues.apache.org/jira/browse/FLINK-13281?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Chesnay Schepler closed FLINK-13281.
------------------------------------
       Resolution: Fixed
    Fix Version/s: 1.9.0

master: 59a4d2c1b52f8cceb5e4e287ee3a94e129d505e7

1.9: ca837bd8d467975df9101f6ea5c19cb48cef5ac5 

> Fix the verify logic of AdaptedRestartPipelinedRegionStrategyNGAbortPendingCheckpointsTest
> ------------------------------------------------------------------------------------------
>
>                 Key: FLINK-13281
>                 URL: https://issues.apache.org/jira/browse/FLINK-13281
>             Project: Flink
>          Issue Type: Bug
>          Components: Tests
>    Affects Versions: 1.9.0
>            Reporter: Yun Tang
>            Assignee: Yun Tang
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.9.0
>
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> FLINK-13060 ensure FailoverStrategies should respect restart constraints. However, this change did not cover the {{AdaptedRestartPipelinedRegionStrategyNGAbortPendingCheckpointsTest}} which should also set as {{FixedDelayRestartStrategy}}. Currently, as the pending checkpoint would still be discarded due to [failUnacknowledgedPendingCheckpoints|https://github.com/apache/flink/blob/a7bdbb9aff734fc586e74c95984c7f956dbf576c/flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointCoordinator.java#L977] within {{CheckpointCoordinator}}, {{AdaptedRestartPipelinedRegionStrategyNGAbortPendingCheckpointsTest}} could pass the test.
> This is actually not what we want the test did, we should actually verify that when region failover, pending checkpoints would be discarded.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)