[GitHub] [lucene-solr] dweiss commented on pull request #2462: SOLR-14759 fix tests that need on lucene test-src

[GitBox <gi...@apache.org>]

dweiss commented on pull request #2462:
URL: https://github.com/apache/lucene-solr/pull/2462#issuecomment-792772167


   I'll remove it in this PR:
   https://github.com/apache/lucene-solr/pull/2448
   
   On Mon, Mar 8, 2021 at 2:53 PM Christine Poerschke <no...@github.com>
   wrote:
   
   > *@cpoerschke* commented on this pull request.
   > ------------------------------
   >
   > In solr/core/src/test/org/apache/solr/search/TestXmlQParser.java
   > <https://github.com/apache/lucene-solr/pull/2462#discussion_r589436382>:
   >
   > >  import org.slf4j.Logger;
   >  import org.slf4j.LoggerFactory;
   >
   > -
   > -public class TestXmlQParser extends TestCoreParser {
   > +@Ignore("Was relying on Lucene test sources. Should copy?")
   >
   > Just opened #2465 <https://github.com/apache/lucene-solr/pull/2465> for
   > the removal before seeing your comment here (but the JIRA ticket).
   >
   > —
   > You are receiving this because you modified the open/close state.
   > Reply to this email directly, view it on GitHub
   > <https://github.com/apache/lucene-solr/pull/2462#discussion_r589436382>,
   > or unsubscribe
   > <https://github.com/notifications/unsubscribe-auth/AABQWLSE6ZB4CEDKUBUG5BDTCTJGXANCNFSM4YVZTSIQ>
   > .
   >
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org