[GitHub] [spark] iRakson commented on a change in pull request #27836: [SPARK-31009][SQL] Support json_object_keys function

[GitBox <gi...@apache.org>]

iRakson commented on a change in pull request #27836: [SPARK-31009][SQL] Support json_object_keys function
URL: https://github.com/apache/spark/pull/27836#discussion_r396629078
 
 

 ##########
 File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/jsonExpressions.scala
 ##########
 @@ -796,3 +797,63 @@ case class SchemaOfJson(
 
   override def prettyName: String = "schema_of_json"
 }
+
+/**
+ * A function which returns all the keys of outer JSON object.
+ */
+@ExpressionDescription(
+  usage = "_FUNC_(json_object) - returns all the keys of outer JSON object.",
+  arguments = """
+    Arguments:
+      * json_object - A JSON object is required as argument. `Null` is returned, if an invalid JSON
+          string is given. `Runtime Exception` is thrown, if null string or JSON array is given.
 
 Review comment:
   I checked the other json functions. `IllegalArgumentException` is thrown by `from_json` for invalid inputs and it is better than `RuntimeException`. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org