You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2022/08/23 06:08:05 UTC

[GitHub] [iotdb] 23931017wu opened a new pull request, #7088: [IOTDB-4130] Implement sync module in the sender in the ASTVisitor to IConfigTaskExecutor section and development of SHOW PIPESINKTYPE

23931017wu opened a new pull request, #7088:
URL: https://github.com/apache/iotdb/pull/7088

   ## Description
   
   ### 1、Task
   ShowPipeSinkTask
   showPipeTask
   CreatePipeSinkTask
   CreatePipeTask
   DropPipeSinkTask
   DropPipeTask
   StartPipeTask
   StopPipeTask
   
   ### 2、SHOW PIPESINKTYPE
   
   ## AFTER
   ![图片](https://user-images.githubusercontent.com/71131924/186082832-99ce96f9-a8bb-498c-b2ca-d5a482ccd6b5.png)
   
   ![图片](https://user-images.githubusercontent.com/71131924/186082746-28abf4ec-39b5-4160-adcc-adf0f4dc4350.png)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] neuyilan commented on a diff in pull request #7088: [IOTDB-4130] Implement sync module in the sender in the ASTVisitor to IConfigTaskExecutor section and development of SHOW PIPESINKTYPE

Posted by GitBox <gi...@apache.org>.
neuyilan commented on code in PR #7088:
URL: https://github.com/apache/iotdb/pull/7088#discussion_r953263159


##########
server/src/main/java/org/apache/iotdb/db/mpp/plan/execution/config/sys/DropPipeSinkTask.java:
##########
@@ -0,0 +1,42 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.iotdb.db.mpp.plan.execution.config.sys;
+
+import org.apache.iotdb.db.mpp.plan.execution.config.ConfigTaskResult;
+import org.apache.iotdb.db.mpp.plan.execution.config.IConfigTask;
+import org.apache.iotdb.db.mpp.plan.execution.config.executor.IConfigTaskExecutor;
+import org.apache.iotdb.db.mpp.plan.statement.sys.DropPipeSinkStatement;
+
+import com.google.common.util.concurrent.ListenableFuture;
+
+public class DropPipeSinkTask implements IConfigTask {
+

Review Comment:
   I think we can move the Pipe task to `server/src/main/java/org/apache/iotdb/db/mpp/plan/execution/config/sys/pipe `package?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] neuyilan commented on pull request #7088: [IOTDB-4130] Implement sync module in the sender in the ASTVisitor to IConfigTaskExecutor section and development of SHOW PIPESINKTYPE

Posted by GitBox <gi...@apache.org>.
neuyilan commented on PR #7088:
URL: https://github.com/apache/iotdb/pull/7088#issuecomment-1225096034

   @Cpaulyz please take a review~


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] 23931017wu commented on a diff in pull request #7088: [IOTDB-4130] Implement sync module in the sender in the ASTVisitor to IConfigTaskExecutor section and development of SHOW PIPESINKTYPE

Posted by GitBox <gi...@apache.org>.
23931017wu commented on code in PR #7088:
URL: https://github.com/apache/iotdb/pull/7088#discussion_r953283432


##########
server/src/main/java/org/apache/iotdb/db/mpp/plan/execution/config/sys/DropPipeSinkTask.java:
##########
@@ -0,0 +1,42 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.iotdb.db.mpp.plan.execution.config.sys;
+
+import org.apache.iotdb.db.mpp.plan.execution.config.ConfigTaskResult;
+import org.apache.iotdb.db.mpp.plan.execution.config.IConfigTask;
+import org.apache.iotdb.db.mpp.plan.execution.config.executor.IConfigTaskExecutor;
+import org.apache.iotdb.db.mpp.plan.statement.sys.DropPipeSinkStatement;
+
+import com.google.common.util.concurrent.ListenableFuture;
+
+public class DropPipeSinkTask implements IConfigTask {
+

Review Comment:
   OK ，wait a second ！



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] neuyilan merged pull request #7088: [IOTDB-4130] Implement sync module in the sender in the ASTVisitor to IConfigTaskExecutor section and development of SHOW PIPESINKTYPE

Posted by GitBox <gi...@apache.org>.
neuyilan merged PR #7088:
URL: https://github.com/apache/iotdb/pull/7088


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] Cpaulyz commented on a diff in pull request #7088: [IOTDB-4130] Implement sync module in the sender in the ASTVisitor to IConfigTaskExecutor section and development of SHOW PIPESINKTYPE

Posted by GitBox <gi...@apache.org>.
Cpaulyz commented on code in PR #7088:
URL: https://github.com/apache/iotdb/pull/7088#discussion_r953265019


##########
server/src/main/java/org/apache/iotdb/db/mpp/plan/execution/config/sys/DropPipeSinkTask.java:
##########
@@ -0,0 +1,42 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.iotdb.db.mpp.plan.execution.config.sys;
+
+import org.apache.iotdb.db.mpp.plan.execution.config.ConfigTaskResult;
+import org.apache.iotdb.db.mpp.plan.execution.config.IConfigTask;
+import org.apache.iotdb.db.mpp.plan.execution.config.executor.IConfigTaskExecutor;
+import org.apache.iotdb.db.mpp.plan.statement.sys.DropPipeSinkStatement;
+
+import com.google.common.util.concurrent.ListenableFuture;
+
+public class DropPipeSinkTask implements IConfigTask {
+

Review Comment:
   Agree. We can move Task and Statement about sync to `org.apache.....sys.sync`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org