You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/10/18 03:31:22 UTC
[GitHub] [flink] xintongsong opened a new pull request #13673: [FLINK-19689][yarn][test] Fix TaskExecutorProcessSpecContainerResourcePriorityAdapterTest for Hadoop 2.10+.
xintongsong opened a new pull request #13673:
URL: https://github.com/apache/flink/pull/13673
## What is the purpose of the change
This PR fixes the test failure of `TaskExecutorProcessSpecContainerResourcePriorityAdapterTest` when running with Hadoop 2.10+.
## Verifying this change
Verified with Hadoop 2.4.1, 2.10.0, 3.1.3 and 3.3.0.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] xintongsong commented on pull request #13673: [FLINK-19689][yarn][test] Fix TaskExecutorProcessSpecContainerResourcePriorityAdapterTest for Hadoop 2.10+.
Posted by GitBox <gi...@apache.org>.
xintongsong commented on pull request #13673:
URL: https://github.com/apache/flink/pull/13673#issuecomment-711111491
@KarmaGYZ Could you help take a look?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13673: [FLINK-19689][yarn][test] Fix TaskExecutorProcessSpecContainerResourcePriorityAdapterTest for Hadoop 2.10+.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13673:
URL: https://github.com/apache/flink/pull/13673#issuecomment-711112023
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "b5e00b966be2e1295430a64ccbaf75ce5547c6d5",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7796",
"triggerID" : "b5e00b966be2e1295430a64ccbaf75ce5547c6d5",
"triggerType" : "PUSH"
}, {
"hash" : "b5e00b966be2e1295430a64ccbaf75ce5547c6d5",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7802",
"triggerID" : "711128305",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* b5e00b966be2e1295430a64ccbaf75ce5547c6d5 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7796) Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7802)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13673: [FLINK-19689][yarn][test] Fix TaskExecutorProcessSpecContainerResourcePriorityAdapterTest for Hadoop 2.10+.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13673:
URL: https://github.com/apache/flink/pull/13673#issuecomment-711112023
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "b5e00b966be2e1295430a64ccbaf75ce5547c6d5",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7796",
"triggerID" : "b5e00b966be2e1295430a64ccbaf75ce5547c6d5",
"triggerType" : "PUSH"
}, {
"hash" : "b5e00b966be2e1295430a64ccbaf75ce5547c6d5",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7802",
"triggerID" : "711128305",
"triggerType" : "MANUAL"
}, {
"hash" : "b5e00b966be2e1295430a64ccbaf75ce5547c6d5",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7796",
"triggerID" : "711128305",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* b5e00b966be2e1295430a64ccbaf75ce5547c6d5 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7802) Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7796)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13673: [FLINK-19689][yarn][test] Fix TaskExecutorProcessSpecContainerResourcePriorityAdapterTest for Hadoop 2.10+.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13673:
URL: https://github.com/apache/flink/pull/13673#issuecomment-711112023
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "b5e00b966be2e1295430a64ccbaf75ce5547c6d5",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7796",
"triggerID" : "b5e00b966be2e1295430a64ccbaf75ce5547c6d5",
"triggerType" : "PUSH"
}, {
"hash" : "b5e00b966be2e1295430a64ccbaf75ce5547c6d5",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7802",
"triggerID" : "711128305",
"triggerType" : "MANUAL"
}, {
"hash" : "b5e00b966be2e1295430a64ccbaf75ce5547c6d5",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7796",
"triggerID" : "711128305",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* b5e00b966be2e1295430a64ccbaf75ce5547c6d5 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7802) Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7796)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #13673: [FLINK-19689][yarn][test] Fix TaskExecutorProcessSpecContainerResourcePriorityAdapterTest for Hadoop 2.10+.
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13673:
URL: https://github.com/apache/flink/pull/13673#issuecomment-711111630
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit b5e00b966be2e1295430a64ccbaf75ce5547c6d5 (Sun Oct 18 03:34:25 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] xintongsong closed pull request #13673: [FLINK-19689][yarn][test] Fix TaskExecutorProcessSpecContainerResourcePriorityAdapterTest for Hadoop 2.10+.
Posted by GitBox <gi...@apache.org>.
xintongsong closed pull request #13673:
URL: https://github.com/apache/flink/pull/13673
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13673: [FLINK-19689][yarn][test] Fix TaskExecutorProcessSpecContainerResourcePriorityAdapterTest for Hadoop 2.10+.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13673:
URL: https://github.com/apache/flink/pull/13673#issuecomment-711112023
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "b5e00b966be2e1295430a64ccbaf75ce5547c6d5",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7796",
"triggerID" : "b5e00b966be2e1295430a64ccbaf75ce5547c6d5",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* b5e00b966be2e1295430a64ccbaf75ce5547c6d5 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7796)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] KarmaGYZ commented on a change in pull request #13673: [FLINK-19689][yarn][test] Fix TaskExecutorProcessSpecContainerResourcePriorityAdapterTest for Hadoop 2.10+.
Posted by GitBox <gi...@apache.org>.
KarmaGYZ commented on a change in pull request #13673:
URL: https://github.com/apache/flink/pull/13673#discussion_r507352226
##########
File path: flink-yarn/src/test/resources/resource-types.xml
##########
@@ -0,0 +1,28 @@
+<?xml version="1.0" encoding="UTF-8" ?>
+
+<!--
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+-->
+
+<configuration>
+ <property>
+ <name>yarn.resource-types</name>
+ <value>testing-external-resource</value>
+ </property>
+</configuration>
Review comment:
nit: need newline at end of file.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] xintongsong commented on pull request #13673: [FLINK-19689][yarn][test] Fix TaskExecutorProcessSpecContainerResourcePriorityAdapterTest for Hadoop 2.10+.
Posted by GitBox <gi...@apache.org>.
xintongsong commented on pull request #13673:
URL: https://github.com/apache/flink/pull/13673#issuecomment-711128305
@flinkbot run azure
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #13673: [FLINK-19689][yarn][test] Fix TaskExecutorProcessSpecContainerResourcePriorityAdapterTest for Hadoop 2.10+.
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13673:
URL: https://github.com/apache/flink/pull/13673#issuecomment-711112023
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "b5e00b966be2e1295430a64ccbaf75ce5547c6d5",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "b5e00b966be2e1295430a64ccbaf75ce5547c6d5",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* b5e00b966be2e1295430a64ccbaf75ce5547c6d5 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org