You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/10/10 10:22:01 UTC
[jira] [Commented] (DBUTILS-124) Introduce SPI to add more column,
property handlers
[ https://issues.apache.org/jira/browse/DBUTILS-124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16198473#comment-16198473 ]
ASF GitHub Bot commented on DBUTILS-124:
----------------------------------------
GitHub user hdevalke opened a pull request:
https://github.com/apache/commons-dbutils/pull/3
Fixes a thread safety problem introduced by DBUTILS-124.
ColumnHandlers and PropertyHandlers are preloaded in a list as the ServiceLoader instances are not thread safe
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/hdevalke/commons-dbutils master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/commons-dbutils/pull/3.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3
----
commit 59d114082708ade64c9f05b13128d0c0eb39bc7f
Author: Hannes De Valkeneer <ha...@de-valkeneer.be>
Date: 2017-10-05T14:05:18Z
Fixes a thread safety problem introduced by DBUTILS-124.
ColumnHandlers and PropertyHandlers are preloaded in a list as the ServiceLoader instances are not thread safe
----
> Introduce SPI to add more column, property handlers
> ---------------------------------------------------
>
> Key: DBUTILS-124
> URL: https://issues.apache.org/jira/browse/DBUTILS-124
> Project: Commons DbUtils
> Issue Type: New Feature
> Reporter: Carl Hall
> Assignee: Carl Hall
> Fix For: 1.7
>
>
> The column types and property types handled by {{BeanProcessor}} are hard coded to the processor. We already use a common return type, so we could add a services approach using the spi built into the jdk. This should also allow other types to be handled outside of {{commons-dbutils}}.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)