You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by br...@apache.org on 2018/12/11 22:43:56 UTC

[cordova-node-xcode] branch brodybits-introduce-eslint updated: [TODO] WORKAROUND to get a green build

This is an automated email from the ASF dual-hosted git repository.

brodybits pushed a commit to branch brodybits-introduce-eslint
in repository https://gitbox.apache.org/repos/asf/cordova-node-xcode.git


The following commit(s) were added to refs/heads/brodybits-introduce-eslint by this push:
     new 653d3d2  [TODO] WORKAROUND to get a green build
653d3d2 is described below

commit 653d3d22a8e9fcf75ee9e150781a9c8224b3c9e8
Author: Christopher J. Brody <ch...@gmail.com>
AuthorDate: Tue Dec 11 17:40:50 2018 -0500

    [TODO] WORKAROUND to get a green build
    
    by only running eslint on Node.js 10
    
    TODO: This workaround should go away once we drop Node.js pre-6.0.
---
 .travis.yml  | 1 +
 package.json | 2 +-
 2 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/.travis.yml b/.travis.yml
index c5cdcf5..db83927 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -24,3 +24,4 @@ install:
 
 script:
   - npm test
+  - 'if [ "${TRAVIS_NODE_VERSION}" = "10" ] ; then npm run eslint ; fi'
diff --git a/package.json b/package.json
index b46b8a2..6f000cc 100644
--- a/package.json
+++ b/package.json
@@ -28,7 +28,7 @@
   "scripts": {
     "eslint": "eslint lib test",
     "pegjs": "node_modules/.bin/pegjs lib/parser/pbxproj.pegjs",
-    "test": "node_modules/.bin/nodeunit test/parser test && npm run eslint"
+    "test": "node_modules/.bin/nodeunit test/parser test"
   },
   "license": "Apache-2.0",
   "contributors": [


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org