You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/02/07 07:18:22 UTC
[GitHub] [flink] PChou opened a new pull request #14891: [FLINK-21289][deployment] FIX missing load pipeline.classpaths in app…
PChou opened a new pull request #14891:
URL: https://github.com/apache/flink/pull/14891
…lication mode, for both k8s and yarn
## What is the purpose of the change
Makes application mode support `-C` option correctly
## Brief change log
ClassPathPackagedProgramRetriever support merge *pipeline.classpaths* and userClassPath, that let pipeline.classpaths visible by the "user program" ClassLoader
kubernetes and yarn ClusterEntry for application mode fetch configuration of *pipeline.classpaths* and pass the URL collection to ClassPathPackagedProgramRetriever
## Verifying this change
Reproduce:
Submitting an application that dependencies need pass through `-C` should throw *ClassNotFoundException*. This usage works when old mode(user program execute in client), but failed in application mode(user program execute in jobmanager)
Fix:
After patched, that will be ok!
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: yes
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #14891: [FLINK-21289][deployment] FIX missing load pipeline.classpaths in app…
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14891:
URL: https://github.com/apache/flink/pull/14891#issuecomment-774628149
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "14b5a6087502e50efef5242eb44802ff45af4a47",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "14b5a6087502e50efef5242eb44802ff45af4a47",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 14b5a6087502e50efef5242eb44802ff45af4a47 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14891: [FLINK-21289][deployment] FIX missing load pipeline.classpaths in app…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14891:
URL: https://github.com/apache/flink/pull/14891#issuecomment-774628149
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "14b5a6087502e50efef5242eb44802ff45af4a47",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13051",
"triggerID" : "14b5a6087502e50efef5242eb44802ff45af4a47",
"triggerType" : "PUSH"
}, {
"hash" : "9c2009b345b3c138b83d25d2ca929a33f5918ab8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13081",
"triggerID" : "9c2009b345b3c138b83d25d2ca929a33f5918ab8",
"triggerType" : "PUSH"
}, {
"hash" : "29ddfd1a206cb8d33e1c5a0f0ca7c1097c77d327",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13088",
"triggerID" : "29ddfd1a206cb8d33e1c5a0f0ca7c1097c77d327",
"triggerType" : "PUSH"
}, {
"hash" : "1976f8fa0310d74fccbd2ccf0ccb6f7b904a60a6",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13430",
"triggerID" : "1976f8fa0310d74fccbd2ccf0ccb6f7b904a60a6",
"triggerType" : "PUSH"
}, {
"hash" : "c4db5e1f7e1adbb6b4c21c4dccf211728fbc2f78",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13483",
"triggerID" : "c4db5e1f7e1adbb6b4c21c4dccf211728fbc2f78",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1976f8fa0310d74fccbd2ccf0ccb6f7b904a60a6 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13430)
* c4db5e1f7e1adbb6b4c21c4dccf211728fbc2f78 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13483)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14891: [FLINK-21289][deployment] FIX missing load pipeline.classpaths in app…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14891:
URL: https://github.com/apache/flink/pull/14891#issuecomment-774628149
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14891: [FLINK-21289][deployment] FIX missing load pipeline.classpaths in app…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14891:
URL: https://github.com/apache/flink/pull/14891#issuecomment-774628149
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "14b5a6087502e50efef5242eb44802ff45af4a47",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13051",
"triggerID" : "14b5a6087502e50efef5242eb44802ff45af4a47",
"triggerType" : "PUSH"
}, {
"hash" : "9c2009b345b3c138b83d25d2ca929a33f5918ab8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13081",
"triggerID" : "9c2009b345b3c138b83d25d2ca929a33f5918ab8",
"triggerType" : "PUSH"
}, {
"hash" : "29ddfd1a206cb8d33e1c5a0f0ca7c1097c77d327",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13088",
"triggerID" : "29ddfd1a206cb8d33e1c5a0f0ca7c1097c77d327",
"triggerType" : "PUSH"
}, {
"hash" : "1976f8fa0310d74fccbd2ccf0ccb6f7b904a60a6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13430",
"triggerID" : "1976f8fa0310d74fccbd2ccf0ccb6f7b904a60a6",
"triggerType" : "PUSH"
}, {
"hash" : "c4db5e1f7e1adbb6b4c21c4dccf211728fbc2f78",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13483",
"triggerID" : "c4db5e1f7e1adbb6b4c21c4dccf211728fbc2f78",
"triggerType" : "PUSH"
}, {
"hash" : "ceba8ed8fb1209a1d2470c7d45cbce6b80e9cbb4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13628",
"triggerID" : "ceba8ed8fb1209a1d2470c7d45cbce6b80e9cbb4",
"triggerType" : "PUSH"
}, {
"hash" : "150a5be15d8605d4fe2214e2e02a97d9bd73bdf7",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13637",
"triggerID" : "150a5be15d8605d4fe2214e2e02a97d9bd73bdf7",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 150a5be15d8605d4fe2214e2e02a97d9bd73bdf7 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13637)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] PChou commented on pull request #14891: [FLINK-21289][deployment] FIX missing load pipeline.classpaths in app…
Posted by GitBox <gi...@apache.org>.
PChou commented on pull request #14891:
URL: https://github.com/apache/flink/pull/14891#issuecomment-784663867
@wangyang0918 thanks for reviewing, hope for fixing in the next release!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14891: [FLINK-21289][deployment] FIX missing load pipeline.classpaths in app…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14891:
URL: https://github.com/apache/flink/pull/14891#issuecomment-774628149
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "14b5a6087502e50efef5242eb44802ff45af4a47",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13051",
"triggerID" : "14b5a6087502e50efef5242eb44802ff45af4a47",
"triggerType" : "PUSH"
}, {
"hash" : "9c2009b345b3c138b83d25d2ca929a33f5918ab8",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13081",
"triggerID" : "9c2009b345b3c138b83d25d2ca929a33f5918ab8",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 14b5a6087502e50efef5242eb44802ff45af4a47 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13051)
* 9c2009b345b3c138b83d25d2ca929a33f5918ab8 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13081)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14891: [FLINK-21289][deployment] FIX missing load pipeline.classpaths in app…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14891:
URL: https://github.com/apache/flink/pull/14891#issuecomment-774628149
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "14b5a6087502e50efef5242eb44802ff45af4a47",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13051",
"triggerID" : "14b5a6087502e50efef5242eb44802ff45af4a47",
"triggerType" : "PUSH"
}, {
"hash" : "9c2009b345b3c138b83d25d2ca929a33f5918ab8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13081",
"triggerID" : "9c2009b345b3c138b83d25d2ca929a33f5918ab8",
"triggerType" : "PUSH"
}, {
"hash" : "29ddfd1a206cb8d33e1c5a0f0ca7c1097c77d327",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13088",
"triggerID" : "29ddfd1a206cb8d33e1c5a0f0ca7c1097c77d327",
"triggerType" : "PUSH"
}, {
"hash" : "1976f8fa0310d74fccbd2ccf0ccb6f7b904a60a6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13430",
"triggerID" : "1976f8fa0310d74fccbd2ccf0ccb6f7b904a60a6",
"triggerType" : "PUSH"
}, {
"hash" : "c4db5e1f7e1adbb6b4c21c4dccf211728fbc2f78",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13483",
"triggerID" : "c4db5e1f7e1adbb6b4c21c4dccf211728fbc2f78",
"triggerType" : "PUSH"
}, {
"hash" : "ceba8ed8fb1209a1d2470c7d45cbce6b80e9cbb4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13628",
"triggerID" : "ceba8ed8fb1209a1d2470c7d45cbce6b80e9cbb4",
"triggerType" : "PUSH"
}, {
"hash" : "150a5be15d8605d4fe2214e2e02a97d9bd73bdf7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13637",
"triggerID" : "150a5be15d8605d4fe2214e2e02a97d9bd73bdf7",
"triggerType" : "PUSH"
}, {
"hash" : "d520fe1077ed24965f8aa005113d2b81d5de02f1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25493",
"triggerID" : "d520fe1077ed24965f8aa005113d2b81d5de02f1",
"triggerType" : "PUSH"
}, {
"hash" : "1d879321a186ed21b45303b0fcd0c26ebdb63e93",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25850",
"triggerID" : "1d879321a186ed21b45303b0fcd0c26ebdb63e93",
"triggerType" : "PUSH"
}, {
"hash" : "b4cbaa42fa0bdd50d2ce02537b5653283c48c7be",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26142",
"triggerID" : "b4cbaa42fa0bdd50d2ce02537b5653283c48c7be",
"triggerType" : "PUSH"
}, {
"hash" : "4279b2e8b1e5f69f6a820b0ba3cb06df26b87142",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26231",
"triggerID" : "4279b2e8b1e5f69f6a820b0ba3cb06df26b87142",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 4279b2e8b1e5f69f6a820b0ba3cb06df26b87142 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26231)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14891: [FLINK-21289][deployment] FIX missing load pipeline.classpaths in app…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14891:
URL: https://github.com/apache/flink/pull/14891#issuecomment-774628149
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "14b5a6087502e50efef5242eb44802ff45af4a47",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13051",
"triggerID" : "14b5a6087502e50efef5242eb44802ff45af4a47",
"triggerType" : "PUSH"
}, {
"hash" : "9c2009b345b3c138b83d25d2ca929a33f5918ab8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13081",
"triggerID" : "9c2009b345b3c138b83d25d2ca929a33f5918ab8",
"triggerType" : "PUSH"
}, {
"hash" : "29ddfd1a206cb8d33e1c5a0f0ca7c1097c77d327",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13088",
"triggerID" : "29ddfd1a206cb8d33e1c5a0f0ca7c1097c77d327",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 29ddfd1a206cb8d33e1c5a0f0ca7c1097c77d327 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13088)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] tillrohrmann commented on a change in pull request #14891: [FLINK-21289][deployment] FIX missing load pipeline.classpaths in app…
Posted by GitBox <gi...@apache.org>.
tillrohrmann commented on a change in pull request #14891:
URL: https://github.com/apache/flink/pull/14891#discussion_r740955044
##########
File path: flink-clients/src/main/java/org/apache/flink/client/program/DefaultPackagedProgramRetriever.java
##########
@@ -217,4 +221,13 @@ public PackagedProgram getPackagedProgram() throws FlinkException {
.collect(Collectors.toList());
return Collections.unmodifiableList(relativeJarURLs);
}
+
+ private static List<URL> getPipelineClassPaths(@Nullable Configuration configuration)
Review comment:
I think the `configuration` is not `null`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] PChou commented on pull request #14891: [FLINK-21289][deployment] FIX missing load pipeline.classpaths in app…
Posted by GitBox <gi...@apache.org>.
PChou commented on pull request #14891:
URL: https://github.com/apache/flink/pull/14891#issuecomment-781018060
@wangyang0918 any update?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wangyang0918 commented on a change in pull request #14891: [FLINK-21289][deployment] FIX missing load pipeline.classpaths in app…
Posted by GitBox <gi...@apache.org>.
wangyang0918 commented on a change in pull request #14891:
URL: https://github.com/apache/flink/pull/14891#discussion_r580750152
##########
File path: flink-clients/src/main/java/org/apache/flink/client/deployment/application/ClassPathPackagedProgramRetriever.java
##########
@@ -276,9 +299,21 @@ public Builder setJarFile(File file) {
return this;
}
+ public Builder setConfiguration(Configuration configuration) {
+ this.configuration = configuration;
+ return this;
+ }
+
public ClassPathPackagedProgramRetriever build() throws IOException {
- return new ClassPathPackagedProgramRetriever(
- programArguments, jobClassName, jarsOnClassPath, userLibDirectory, jarFile);
+ ClassPathPackagedProgramRetriever classPathPackagedProgramRetriever =
Review comment:
Local variable `classPathPackagedProgramRetriever` is redundant.
##########
File path: flink-kubernetes/src/main/java/org/apache/flink/kubernetes/entrypoint/KubernetesApplicationClusterEntrypoint.java
##########
@@ -111,7 +111,8 @@ private static PackagedProgramRetriever getPackagedProgramRetriever(
final ClassPathPackagedProgramRetriever.Builder retrieverBuilder =
ClassPathPackagedProgramRetriever.newBuilder(programArguments)
.setUserLibDirectory(userLibDir)
- .setJobClassName(jobClassName);
+ .setJobClassName(jobClassName)
+ .setConfiguration(configuration);
Review comment:
We also need to `setConfiguration` for `StandaloneApplicationClusterEntryPoint`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14891: [FLINK-21289][deployment] FIX missing load pipeline.classpaths in app…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14891:
URL: https://github.com/apache/flink/pull/14891#issuecomment-774628149
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "14b5a6087502e50efef5242eb44802ff45af4a47",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13051",
"triggerID" : "14b5a6087502e50efef5242eb44802ff45af4a47",
"triggerType" : "PUSH"
}, {
"hash" : "9c2009b345b3c138b83d25d2ca929a33f5918ab8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13081",
"triggerID" : "9c2009b345b3c138b83d25d2ca929a33f5918ab8",
"triggerType" : "PUSH"
}, {
"hash" : "29ddfd1a206cb8d33e1c5a0f0ca7c1097c77d327",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13088",
"triggerID" : "29ddfd1a206cb8d33e1c5a0f0ca7c1097c77d327",
"triggerType" : "PUSH"
}, {
"hash" : "1976f8fa0310d74fccbd2ccf0ccb6f7b904a60a6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13430",
"triggerID" : "1976f8fa0310d74fccbd2ccf0ccb6f7b904a60a6",
"triggerType" : "PUSH"
}, {
"hash" : "c4db5e1f7e1adbb6b4c21c4dccf211728fbc2f78",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13483",
"triggerID" : "c4db5e1f7e1adbb6b4c21c4dccf211728fbc2f78",
"triggerType" : "PUSH"
}, {
"hash" : "ceba8ed8fb1209a1d2470c7d45cbce6b80e9cbb4",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13628",
"triggerID" : "ceba8ed8fb1209a1d2470c7d45cbce6b80e9cbb4",
"triggerType" : "PUSH"
}, {
"hash" : "150a5be15d8605d4fe2214e2e02a97d9bd73bdf7",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13637",
"triggerID" : "150a5be15d8605d4fe2214e2e02a97d9bd73bdf7",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c4db5e1f7e1adbb6b4c21c4dccf211728fbc2f78 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13483)
* ceba8ed8fb1209a1d2470c7d45cbce6b80e9cbb4 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13628)
* 150a5be15d8605d4fe2214e2e02a97d9bd73bdf7 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13637)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] PChou commented on pull request #14891: [FLINK-21289][deployment] FIX missing load pipeline.classpaths in app…
Posted by GitBox <gi...@apache.org>.
PChou commented on pull request #14891:
URL: https://github.com/apache/flink/pull/14891#issuecomment-781029670
@wangyang0918 OK. I agree that, if it was designed. I'd like to fix as the style
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14891: [FLINK-21289][deployment] FIX missing load pipeline.classpaths in app…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14891:
URL: https://github.com/apache/flink/pull/14891#issuecomment-774628149
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] tillrohrmann commented on a change in pull request #14891: [FLINK-21289][deployment] FIX missing load pipeline.classpaths in app…
Posted by GitBox <gi...@apache.org>.
tillrohrmann commented on a change in pull request #14891:
URL: https://github.com/apache/flink/pull/14891#discussion_r740955044
##########
File path: flink-clients/src/main/java/org/apache/flink/client/program/DefaultPackagedProgramRetriever.java
##########
@@ -217,4 +221,13 @@ public PackagedProgram getPackagedProgram() throws FlinkException {
.collect(Collectors.toList());
return Collections.unmodifiableList(relativeJarURLs);
}
+
+ private static List<URL> getPipelineClassPaths(@Nullable Configuration configuration)
Review comment:
I think the `configuration` is not `null`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] tillrohrmann closed pull request #14891: [FLINK-21289][deployment] FIX missing load pipeline.classpaths in app…
Posted by GitBox <gi...@apache.org>.
tillrohrmann closed pull request #14891:
URL: https://github.com/apache/flink/pull/14891
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14891: [FLINK-21289][deployment] FIX missing load pipeline.classpaths in app…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14891:
URL: https://github.com/apache/flink/pull/14891#issuecomment-774628149
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "14b5a6087502e50efef5242eb44802ff45af4a47",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13051",
"triggerID" : "14b5a6087502e50efef5242eb44802ff45af4a47",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 14b5a6087502e50efef5242eb44802ff45af4a47 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13051)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14891: [FLINK-21289][deployment] FIX missing load pipeline.classpaths in app…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14891:
URL: https://github.com/apache/flink/pull/14891#issuecomment-774628149
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "14b5a6087502e50efef5242eb44802ff45af4a47",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13051",
"triggerID" : "14b5a6087502e50efef5242eb44802ff45af4a47",
"triggerType" : "PUSH"
}, {
"hash" : "9c2009b345b3c138b83d25d2ca929a33f5918ab8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13081",
"triggerID" : "9c2009b345b3c138b83d25d2ca929a33f5918ab8",
"triggerType" : "PUSH"
}, {
"hash" : "29ddfd1a206cb8d33e1c5a0f0ca7c1097c77d327",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13088",
"triggerID" : "29ddfd1a206cb8d33e1c5a0f0ca7c1097c77d327",
"triggerType" : "PUSH"
}, {
"hash" : "1976f8fa0310d74fccbd2ccf0ccb6f7b904a60a6",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13430",
"triggerID" : "1976f8fa0310d74fccbd2ccf0ccb6f7b904a60a6",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1976f8fa0310d74fccbd2ccf0ccb6f7b904a60a6 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13430)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14891: [FLINK-21289][deployment] FIX missing load pipeline.classpaths in app…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14891:
URL: https://github.com/apache/flink/pull/14891#issuecomment-774628149
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "14b5a6087502e50efef5242eb44802ff45af4a47",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13051",
"triggerID" : "14b5a6087502e50efef5242eb44802ff45af4a47",
"triggerType" : "PUSH"
}, {
"hash" : "9c2009b345b3c138b83d25d2ca929a33f5918ab8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13081",
"triggerID" : "9c2009b345b3c138b83d25d2ca929a33f5918ab8",
"triggerType" : "PUSH"
}, {
"hash" : "29ddfd1a206cb8d33e1c5a0f0ca7c1097c77d327",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13088",
"triggerID" : "29ddfd1a206cb8d33e1c5a0f0ca7c1097c77d327",
"triggerType" : "PUSH"
}, {
"hash" : "1976f8fa0310d74fccbd2ccf0ccb6f7b904a60a6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13430",
"triggerID" : "1976f8fa0310d74fccbd2ccf0ccb6f7b904a60a6",
"triggerType" : "PUSH"
}, {
"hash" : "c4db5e1f7e1adbb6b4c21c4dccf211728fbc2f78",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13483",
"triggerID" : "c4db5e1f7e1adbb6b4c21c4dccf211728fbc2f78",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c4db5e1f7e1adbb6b4c21c4dccf211728fbc2f78 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13483)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] PChou commented on pull request #14891: [FLINK-21289][deployment] FIX missing load pipeline.classpaths in app…
Posted by GitBox <gi...@apache.org>.
PChou commented on pull request #14891:
URL: https://github.com/apache/flink/pull/14891#issuecomment-952562549
`ClassPathPackagedProgramRetriever` is replaced by `DefaultPackagedProgramRetriever` on master branch, and `DefaultPackagedProgramRetriever` has been support `Configuration` as parameter. So the last commit just change `DefaultPackagedProgramRetriever` to fix the problem.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14891: [FLINK-21289][deployment] FIX missing load pipeline.classpaths in app…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14891:
URL: https://github.com/apache/flink/pull/14891#issuecomment-774628149
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14891: [FLINK-21289][deployment] FIX missing load pipeline.classpaths in app…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14891:
URL: https://github.com/apache/flink/pull/14891#issuecomment-774628149
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "14b5a6087502e50efef5242eb44802ff45af4a47",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13051",
"triggerID" : "14b5a6087502e50efef5242eb44802ff45af4a47",
"triggerType" : "PUSH"
}, {
"hash" : "9c2009b345b3c138b83d25d2ca929a33f5918ab8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13081",
"triggerID" : "9c2009b345b3c138b83d25d2ca929a33f5918ab8",
"triggerType" : "PUSH"
}, {
"hash" : "29ddfd1a206cb8d33e1c5a0f0ca7c1097c77d327",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13088",
"triggerID" : "29ddfd1a206cb8d33e1c5a0f0ca7c1097c77d327",
"triggerType" : "PUSH"
}, {
"hash" : "1976f8fa0310d74fccbd2ccf0ccb6f7b904a60a6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13430",
"triggerID" : "1976f8fa0310d74fccbd2ccf0ccb6f7b904a60a6",
"triggerType" : "PUSH"
}, {
"hash" : "c4db5e1f7e1adbb6b4c21c4dccf211728fbc2f78",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13483",
"triggerID" : "c4db5e1f7e1adbb6b4c21c4dccf211728fbc2f78",
"triggerType" : "PUSH"
}, {
"hash" : "ceba8ed8fb1209a1d2470c7d45cbce6b80e9cbb4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13628",
"triggerID" : "ceba8ed8fb1209a1d2470c7d45cbce6b80e9cbb4",
"triggerType" : "PUSH"
}, {
"hash" : "150a5be15d8605d4fe2214e2e02a97d9bd73bdf7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13637",
"triggerID" : "150a5be15d8605d4fe2214e2e02a97d9bd73bdf7",
"triggerType" : "PUSH"
}, {
"hash" : "d520fe1077ed24965f8aa005113d2b81d5de02f1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25493",
"triggerID" : "d520fe1077ed24965f8aa005113d2b81d5de02f1",
"triggerType" : "PUSH"
}, {
"hash" : "1d879321a186ed21b45303b0fcd0c26ebdb63e93",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25850",
"triggerID" : "1d879321a186ed21b45303b0fcd0c26ebdb63e93",
"triggerType" : "PUSH"
}, {
"hash" : "b4cbaa42fa0bdd50d2ce02537b5653283c48c7be",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26142",
"triggerID" : "b4cbaa42fa0bdd50d2ce02537b5653283c48c7be",
"triggerType" : "PUSH"
}, {
"hash" : "4279b2e8b1e5f69f6a820b0ba3cb06df26b87142",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "4279b2e8b1e5f69f6a820b0ba3cb06df26b87142",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* b4cbaa42fa0bdd50d2ce02537b5653283c48c7be Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26142)
* 4279b2e8b1e5f69f6a820b0ba3cb06df26b87142 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14891: [FLINK-21289][deployment] FIX missing load pipeline.classpaths in app…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14891:
URL: https://github.com/apache/flink/pull/14891#issuecomment-774628149
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "14b5a6087502e50efef5242eb44802ff45af4a47",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13051",
"triggerID" : "14b5a6087502e50efef5242eb44802ff45af4a47",
"triggerType" : "PUSH"
}, {
"hash" : "9c2009b345b3c138b83d25d2ca929a33f5918ab8",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13081",
"triggerID" : "9c2009b345b3c138b83d25d2ca929a33f5918ab8",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 9c2009b345b3c138b83d25d2ca929a33f5918ab8 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13081)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14891: [FLINK-21289][deployment] FIX missing load pipeline.classpaths in app…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14891:
URL: https://github.com/apache/flink/pull/14891#issuecomment-774628149
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "14b5a6087502e50efef5242eb44802ff45af4a47",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13051",
"triggerID" : "14b5a6087502e50efef5242eb44802ff45af4a47",
"triggerType" : "PUSH"
}, {
"hash" : "9c2009b345b3c138b83d25d2ca929a33f5918ab8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13081",
"triggerID" : "9c2009b345b3c138b83d25d2ca929a33f5918ab8",
"triggerType" : "PUSH"
}, {
"hash" : "29ddfd1a206cb8d33e1c5a0f0ca7c1097c77d327",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13088",
"triggerID" : "29ddfd1a206cb8d33e1c5a0f0ca7c1097c77d327",
"triggerType" : "PUSH"
}, {
"hash" : "1976f8fa0310d74fccbd2ccf0ccb6f7b904a60a6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13430",
"triggerID" : "1976f8fa0310d74fccbd2ccf0ccb6f7b904a60a6",
"triggerType" : "PUSH"
}, {
"hash" : "c4db5e1f7e1adbb6b4c21c4dccf211728fbc2f78",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13483",
"triggerID" : "c4db5e1f7e1adbb6b4c21c4dccf211728fbc2f78",
"triggerType" : "PUSH"
}, {
"hash" : "ceba8ed8fb1209a1d2470c7d45cbce6b80e9cbb4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13628",
"triggerID" : "ceba8ed8fb1209a1d2470c7d45cbce6b80e9cbb4",
"triggerType" : "PUSH"
}, {
"hash" : "150a5be15d8605d4fe2214e2e02a97d9bd73bdf7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13637",
"triggerID" : "150a5be15d8605d4fe2214e2e02a97d9bd73bdf7",
"triggerType" : "PUSH"
}, {
"hash" : "d520fe1077ed24965f8aa005113d2b81d5de02f1",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25493",
"triggerID" : "d520fe1077ed24965f8aa005113d2b81d5de02f1",
"triggerType" : "PUSH"
}, {
"hash" : "1d879321a186ed21b45303b0fcd0c26ebdb63e93",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "1d879321a186ed21b45303b0fcd0c26ebdb63e93",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d520fe1077ed24965f8aa005113d2b81d5de02f1 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25493)
* 1d879321a186ed21b45303b0fcd0c26ebdb63e93 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14891: [FLINK-21289][deployment] FIX missing load pipeline.classpaths in app…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14891:
URL: https://github.com/apache/flink/pull/14891#issuecomment-774628149
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "14b5a6087502e50efef5242eb44802ff45af4a47",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13051",
"triggerID" : "14b5a6087502e50efef5242eb44802ff45af4a47",
"triggerType" : "PUSH"
}, {
"hash" : "9c2009b345b3c138b83d25d2ca929a33f5918ab8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13081",
"triggerID" : "9c2009b345b3c138b83d25d2ca929a33f5918ab8",
"triggerType" : "PUSH"
}, {
"hash" : "29ddfd1a206cb8d33e1c5a0f0ca7c1097c77d327",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13088",
"triggerID" : "29ddfd1a206cb8d33e1c5a0f0ca7c1097c77d327",
"triggerType" : "PUSH"
}, {
"hash" : "1976f8fa0310d74fccbd2ccf0ccb6f7b904a60a6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13430",
"triggerID" : "1976f8fa0310d74fccbd2ccf0ccb6f7b904a60a6",
"triggerType" : "PUSH"
}, {
"hash" : "c4db5e1f7e1adbb6b4c21c4dccf211728fbc2f78",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13483",
"triggerID" : "c4db5e1f7e1adbb6b4c21c4dccf211728fbc2f78",
"triggerType" : "PUSH"
}, {
"hash" : "ceba8ed8fb1209a1d2470c7d45cbce6b80e9cbb4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13628",
"triggerID" : "ceba8ed8fb1209a1d2470c7d45cbce6b80e9cbb4",
"triggerType" : "PUSH"
}, {
"hash" : "150a5be15d8605d4fe2214e2e02a97d9bd73bdf7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13637",
"triggerID" : "150a5be15d8605d4fe2214e2e02a97d9bd73bdf7",
"triggerType" : "PUSH"
}, {
"hash" : "d520fe1077ed24965f8aa005113d2b81d5de02f1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25493",
"triggerID" : "d520fe1077ed24965f8aa005113d2b81d5de02f1",
"triggerType" : "PUSH"
}, {
"hash" : "1d879321a186ed21b45303b0fcd0c26ebdb63e93",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25850",
"triggerID" : "1d879321a186ed21b45303b0fcd0c26ebdb63e93",
"triggerType" : "PUSH"
}, {
"hash" : "b4cbaa42fa0bdd50d2ce02537b5653283c48c7be",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26142",
"triggerID" : "b4cbaa42fa0bdd50d2ce02537b5653283c48c7be",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* b4cbaa42fa0bdd50d2ce02537b5653283c48c7be Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26142)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] PChou commented on pull request #14891: [FLINK-21289][deployment] FIX missing load pipeline.classpaths in app…
Posted by GitBox <gi...@apache.org>.
PChou commented on pull request #14891:
URL: https://github.com/apache/flink/pull/14891#issuecomment-775585080
@wangyang0918 `ClassPathPackagedProgramRetriever` is an implementation of `PackagedProgramRetrieve` which only define method `getPackagedProgram`, that means callers should only know about `getPackagedProgram`. Caller should only control the behavior of `ClassPathPackagedProgramRetriever` through `ClassPathPackagedProgramRetriever.Builder`. So i prefer doing changes in the `Builder`.
When "other mode" access the `ClassPathPackagedProgramRetriever`, `pipelineClassPath` is empty collection by default, that will not affect the mode's behavior
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #14891: [FLINK-21289][deployment] FIX missing load pipeline.classpaths in app…
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14891:
URL: https://github.com/apache/flink/pull/14891#issuecomment-774625913
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 14b5a6087502e50efef5242eb44802ff45af4a47 (Sun Feb 07 07:21:21 UTC 2021)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] PChou commented on a change in pull request #14891: [FLINK-21289][deployment] FIX missing load pipeline.classpaths in app…
Posted by GitBox <gi...@apache.org>.
PChou commented on a change in pull request #14891:
URL: https://github.com/apache/flink/pull/14891#discussion_r580771925
##########
File path: flink-clients/src/main/java/org/apache/flink/client/deployment/application/ClassPathPackagedProgramRetriever.java
##########
@@ -276,9 +299,21 @@ public Builder setJarFile(File file) {
return this;
}
+ public Builder setConfiguration(Configuration configuration) {
+ this.configuration = configuration;
+ return this;
+ }
+
public ClassPathPackagedProgramRetriever build() throws IOException {
- return new ClassPathPackagedProgramRetriever(
- programArguments, jobClassName, jarsOnClassPath, userLibDirectory, jarFile);
+ ClassPathPackagedProgramRetriever classPathPackagedProgramRetriever =
Review comment:
OK. i am going to fix it and add some test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14891: [FLINK-21289][deployment] FIX missing load pipeline.classpaths in app…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14891:
URL: https://github.com/apache/flink/pull/14891#issuecomment-774628149
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "14b5a6087502e50efef5242eb44802ff45af4a47",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13051",
"triggerID" : "14b5a6087502e50efef5242eb44802ff45af4a47",
"triggerType" : "PUSH"
}, {
"hash" : "9c2009b345b3c138b83d25d2ca929a33f5918ab8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13081",
"triggerID" : "9c2009b345b3c138b83d25d2ca929a33f5918ab8",
"triggerType" : "PUSH"
}, {
"hash" : "29ddfd1a206cb8d33e1c5a0f0ca7c1097c77d327",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13088",
"triggerID" : "29ddfd1a206cb8d33e1c5a0f0ca7c1097c77d327",
"triggerType" : "PUSH"
}, {
"hash" : "1976f8fa0310d74fccbd2ccf0ccb6f7b904a60a6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13430",
"triggerID" : "1976f8fa0310d74fccbd2ccf0ccb6f7b904a60a6",
"triggerType" : "PUSH"
}, {
"hash" : "c4db5e1f7e1adbb6b4c21c4dccf211728fbc2f78",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13483",
"triggerID" : "c4db5e1f7e1adbb6b4c21c4dccf211728fbc2f78",
"triggerType" : "PUSH"
}, {
"hash" : "ceba8ed8fb1209a1d2470c7d45cbce6b80e9cbb4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13628",
"triggerID" : "ceba8ed8fb1209a1d2470c7d45cbce6b80e9cbb4",
"triggerType" : "PUSH"
}, {
"hash" : "150a5be15d8605d4fe2214e2e02a97d9bd73bdf7",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13637",
"triggerID" : "150a5be15d8605d4fe2214e2e02a97d9bd73bdf7",
"triggerType" : "PUSH"
}, {
"hash" : "d520fe1077ed24965f8aa005113d2b81d5de02f1",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "d520fe1077ed24965f8aa005113d2b81d5de02f1",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 150a5be15d8605d4fe2214e2e02a97d9bd73bdf7 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13637)
* d520fe1077ed24965f8aa005113d2b81d5de02f1 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14891: [FLINK-21289][deployment] FIX missing load pipeline.classpaths in app…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14891:
URL: https://github.com/apache/flink/pull/14891#issuecomment-774628149
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "14b5a6087502e50efef5242eb44802ff45af4a47",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13051",
"triggerID" : "14b5a6087502e50efef5242eb44802ff45af4a47",
"triggerType" : "PUSH"
}, {
"hash" : "9c2009b345b3c138b83d25d2ca929a33f5918ab8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13081",
"triggerID" : "9c2009b345b3c138b83d25d2ca929a33f5918ab8",
"triggerType" : "PUSH"
}, {
"hash" : "29ddfd1a206cb8d33e1c5a0f0ca7c1097c77d327",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13088",
"triggerID" : "29ddfd1a206cb8d33e1c5a0f0ca7c1097c77d327",
"triggerType" : "PUSH"
}, {
"hash" : "1976f8fa0310d74fccbd2ccf0ccb6f7b904a60a6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13430",
"triggerID" : "1976f8fa0310d74fccbd2ccf0ccb6f7b904a60a6",
"triggerType" : "PUSH"
}, {
"hash" : "c4db5e1f7e1adbb6b4c21c4dccf211728fbc2f78",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13483",
"triggerID" : "c4db5e1f7e1adbb6b4c21c4dccf211728fbc2f78",
"triggerType" : "PUSH"
}, {
"hash" : "ceba8ed8fb1209a1d2470c7d45cbce6b80e9cbb4",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13628",
"triggerID" : "ceba8ed8fb1209a1d2470c7d45cbce6b80e9cbb4",
"triggerType" : "PUSH"
}, {
"hash" : "150a5be15d8605d4fe2214e2e02a97d9bd73bdf7",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13637",
"triggerID" : "150a5be15d8605d4fe2214e2e02a97d9bd73bdf7",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ceba8ed8fb1209a1d2470c7d45cbce6b80e9cbb4 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13628)
* 150a5be15d8605d4fe2214e2e02a97d9bd73bdf7 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13637)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] PChou commented on pull request #14891: [FLINK-21289][deployment] FIX missing load pipeline.classpaths in app…
Posted by GitBox <gi...@apache.org>.
PChou commented on pull request #14891:
URL: https://github.com/apache/flink/pull/14891#issuecomment-953564840
@wangyang0918 Is it possible to contact via WeChat? I have some issues about k8s native deployment that cannot be resolved. My WeChat: P_Chou
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14891: [FLINK-21289][deployment] FIX missing load pipeline.classpaths in app…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14891:
URL: https://github.com/apache/flink/pull/14891#issuecomment-774628149
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "14b5a6087502e50efef5242eb44802ff45af4a47",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13051",
"triggerID" : "14b5a6087502e50efef5242eb44802ff45af4a47",
"triggerType" : "PUSH"
}, {
"hash" : "9c2009b345b3c138b83d25d2ca929a33f5918ab8",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13081",
"triggerID" : "9c2009b345b3c138b83d25d2ca929a33f5918ab8",
"triggerType" : "PUSH"
}, {
"hash" : "29ddfd1a206cb8d33e1c5a0f0ca7c1097c77d327",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "29ddfd1a206cb8d33e1c5a0f0ca7c1097c77d327",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 9c2009b345b3c138b83d25d2ca929a33f5918ab8 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13081)
* 29ddfd1a206cb8d33e1c5a0f0ca7c1097c77d327 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14891: [FLINK-21289][deployment] FIX missing load pipeline.classpaths in app…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14891:
URL: https://github.com/apache/flink/pull/14891#issuecomment-774628149
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "14b5a6087502e50efef5242eb44802ff45af4a47",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13051",
"triggerID" : "14b5a6087502e50efef5242eb44802ff45af4a47",
"triggerType" : "PUSH"
}, {
"hash" : "9c2009b345b3c138b83d25d2ca929a33f5918ab8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13081",
"triggerID" : "9c2009b345b3c138b83d25d2ca929a33f5918ab8",
"triggerType" : "PUSH"
}, {
"hash" : "29ddfd1a206cb8d33e1c5a0f0ca7c1097c77d327",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13088",
"triggerID" : "29ddfd1a206cb8d33e1c5a0f0ca7c1097c77d327",
"triggerType" : "PUSH"
}, {
"hash" : "1976f8fa0310d74fccbd2ccf0ccb6f7b904a60a6",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13430",
"triggerID" : "1976f8fa0310d74fccbd2ccf0ccb6f7b904a60a6",
"triggerType" : "PUSH"
}, {
"hash" : "c4db5e1f7e1adbb6b4c21c4dccf211728fbc2f78",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "c4db5e1f7e1adbb6b4c21c4dccf211728fbc2f78",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1976f8fa0310d74fccbd2ccf0ccb6f7b904a60a6 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13430)
* c4db5e1f7e1adbb6b4c21c4dccf211728fbc2f78 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14891: [FLINK-21289][deployment] FIX missing load pipeline.classpaths in app…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14891:
URL: https://github.com/apache/flink/pull/14891#issuecomment-774628149
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "14b5a6087502e50efef5242eb44802ff45af4a47",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13051",
"triggerID" : "14b5a6087502e50efef5242eb44802ff45af4a47",
"triggerType" : "PUSH"
}, {
"hash" : "9c2009b345b3c138b83d25d2ca929a33f5918ab8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13081",
"triggerID" : "9c2009b345b3c138b83d25d2ca929a33f5918ab8",
"triggerType" : "PUSH"
}, {
"hash" : "29ddfd1a206cb8d33e1c5a0f0ca7c1097c77d327",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13088",
"triggerID" : "29ddfd1a206cb8d33e1c5a0f0ca7c1097c77d327",
"triggerType" : "PUSH"
}, {
"hash" : "1976f8fa0310d74fccbd2ccf0ccb6f7b904a60a6",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "1976f8fa0310d74fccbd2ccf0ccb6f7b904a60a6",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 29ddfd1a206cb8d33e1c5a0f0ca7c1097c77d327 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13088)
* 1976f8fa0310d74fccbd2ccf0ccb6f7b904a60a6 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14891: [FLINK-21289][deployment] FIX missing load pipeline.classpaths in app…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14891:
URL: https://github.com/apache/flink/pull/14891#issuecomment-774628149
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "14b5a6087502e50efef5242eb44802ff45af4a47",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13051",
"triggerID" : "14b5a6087502e50efef5242eb44802ff45af4a47",
"triggerType" : "PUSH"
}, {
"hash" : "9c2009b345b3c138b83d25d2ca929a33f5918ab8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13081",
"triggerID" : "9c2009b345b3c138b83d25d2ca929a33f5918ab8",
"triggerType" : "PUSH"
}, {
"hash" : "29ddfd1a206cb8d33e1c5a0f0ca7c1097c77d327",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13088",
"triggerID" : "29ddfd1a206cb8d33e1c5a0f0ca7c1097c77d327",
"triggerType" : "PUSH"
}, {
"hash" : "1976f8fa0310d74fccbd2ccf0ccb6f7b904a60a6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13430",
"triggerID" : "1976f8fa0310d74fccbd2ccf0ccb6f7b904a60a6",
"triggerType" : "PUSH"
}, {
"hash" : "c4db5e1f7e1adbb6b4c21c4dccf211728fbc2f78",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13483",
"triggerID" : "c4db5e1f7e1adbb6b4c21c4dccf211728fbc2f78",
"triggerType" : "PUSH"
}, {
"hash" : "ceba8ed8fb1209a1d2470c7d45cbce6b80e9cbb4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13628",
"triggerID" : "ceba8ed8fb1209a1d2470c7d45cbce6b80e9cbb4",
"triggerType" : "PUSH"
}, {
"hash" : "150a5be15d8605d4fe2214e2e02a97d9bd73bdf7",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13637",
"triggerID" : "150a5be15d8605d4fe2214e2e02a97d9bd73bdf7",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 150a5be15d8605d4fe2214e2e02a97d9bd73bdf7 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13637)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14891: [FLINK-21289][deployment] FIX missing load pipeline.classpaths in app…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14891:
URL: https://github.com/apache/flink/pull/14891#issuecomment-774628149
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "14b5a6087502e50efef5242eb44802ff45af4a47",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13051",
"triggerID" : "14b5a6087502e50efef5242eb44802ff45af4a47",
"triggerType" : "PUSH"
}, {
"hash" : "9c2009b345b3c138b83d25d2ca929a33f5918ab8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13081",
"triggerID" : "9c2009b345b3c138b83d25d2ca929a33f5918ab8",
"triggerType" : "PUSH"
}, {
"hash" : "29ddfd1a206cb8d33e1c5a0f0ca7c1097c77d327",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13088",
"triggerID" : "29ddfd1a206cb8d33e1c5a0f0ca7c1097c77d327",
"triggerType" : "PUSH"
}, {
"hash" : "1976f8fa0310d74fccbd2ccf0ccb6f7b904a60a6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13430",
"triggerID" : "1976f8fa0310d74fccbd2ccf0ccb6f7b904a60a6",
"triggerType" : "PUSH"
}, {
"hash" : "c4db5e1f7e1adbb6b4c21c4dccf211728fbc2f78",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13483",
"triggerID" : "c4db5e1f7e1adbb6b4c21c4dccf211728fbc2f78",
"triggerType" : "PUSH"
}, {
"hash" : "ceba8ed8fb1209a1d2470c7d45cbce6b80e9cbb4",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13628",
"triggerID" : "ceba8ed8fb1209a1d2470c7d45cbce6b80e9cbb4",
"triggerType" : "PUSH"
}, {
"hash" : "150a5be15d8605d4fe2214e2e02a97d9bd73bdf7",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "150a5be15d8605d4fe2214e2e02a97d9bd73bdf7",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c4db5e1f7e1adbb6b4c21c4dccf211728fbc2f78 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13483)
* ceba8ed8fb1209a1d2470c7d45cbce6b80e9cbb4 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13628)
* 150a5be15d8605d4fe2214e2e02a97d9bd73bdf7 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14891: [FLINK-21289][deployment] FIX missing load pipeline.classpaths in app…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14891:
URL: https://github.com/apache/flink/pull/14891#issuecomment-774628149
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "14b5a6087502e50efef5242eb44802ff45af4a47",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13051",
"triggerID" : "14b5a6087502e50efef5242eb44802ff45af4a47",
"triggerType" : "PUSH"
}, {
"hash" : "9c2009b345b3c138b83d25d2ca929a33f5918ab8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13081",
"triggerID" : "9c2009b345b3c138b83d25d2ca929a33f5918ab8",
"triggerType" : "PUSH"
}, {
"hash" : "29ddfd1a206cb8d33e1c5a0f0ca7c1097c77d327",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13088",
"triggerID" : "29ddfd1a206cb8d33e1c5a0f0ca7c1097c77d327",
"triggerType" : "PUSH"
}, {
"hash" : "1976f8fa0310d74fccbd2ccf0ccb6f7b904a60a6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13430",
"triggerID" : "1976f8fa0310d74fccbd2ccf0ccb6f7b904a60a6",
"triggerType" : "PUSH"
}, {
"hash" : "c4db5e1f7e1adbb6b4c21c4dccf211728fbc2f78",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13483",
"triggerID" : "c4db5e1f7e1adbb6b4c21c4dccf211728fbc2f78",
"triggerType" : "PUSH"
}, {
"hash" : "ceba8ed8fb1209a1d2470c7d45cbce6b80e9cbb4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13628",
"triggerID" : "ceba8ed8fb1209a1d2470c7d45cbce6b80e9cbb4",
"triggerType" : "PUSH"
}, {
"hash" : "150a5be15d8605d4fe2214e2e02a97d9bd73bdf7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13637",
"triggerID" : "150a5be15d8605d4fe2214e2e02a97d9bd73bdf7",
"triggerType" : "PUSH"
}, {
"hash" : "d520fe1077ed24965f8aa005113d2b81d5de02f1",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25493",
"triggerID" : "d520fe1077ed24965f8aa005113d2b81d5de02f1",
"triggerType" : "PUSH"
}, {
"hash" : "1d879321a186ed21b45303b0fcd0c26ebdb63e93",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25850",
"triggerID" : "1d879321a186ed21b45303b0fcd0c26ebdb63e93",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d520fe1077ed24965f8aa005113d2b81d5de02f1 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25493)
* 1d879321a186ed21b45303b0fcd0c26ebdb63e93 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25850)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14891: [FLINK-21289][deployment] FIX missing load pipeline.classpaths in app…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14891:
URL: https://github.com/apache/flink/pull/14891#issuecomment-774628149
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "14b5a6087502e50efef5242eb44802ff45af4a47",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13051",
"triggerID" : "14b5a6087502e50efef5242eb44802ff45af4a47",
"triggerType" : "PUSH"
}, {
"hash" : "9c2009b345b3c138b83d25d2ca929a33f5918ab8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13081",
"triggerID" : "9c2009b345b3c138b83d25d2ca929a33f5918ab8",
"triggerType" : "PUSH"
}, {
"hash" : "29ddfd1a206cb8d33e1c5a0f0ca7c1097c77d327",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13088",
"triggerID" : "29ddfd1a206cb8d33e1c5a0f0ca7c1097c77d327",
"triggerType" : "PUSH"
}, {
"hash" : "1976f8fa0310d74fccbd2ccf0ccb6f7b904a60a6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13430",
"triggerID" : "1976f8fa0310d74fccbd2ccf0ccb6f7b904a60a6",
"triggerType" : "PUSH"
}, {
"hash" : "c4db5e1f7e1adbb6b4c21c4dccf211728fbc2f78",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13483",
"triggerID" : "c4db5e1f7e1adbb6b4c21c4dccf211728fbc2f78",
"triggerType" : "PUSH"
}, {
"hash" : "ceba8ed8fb1209a1d2470c7d45cbce6b80e9cbb4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13628",
"triggerID" : "ceba8ed8fb1209a1d2470c7d45cbce6b80e9cbb4",
"triggerType" : "PUSH"
}, {
"hash" : "150a5be15d8605d4fe2214e2e02a97d9bd73bdf7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13637",
"triggerID" : "150a5be15d8605d4fe2214e2e02a97d9bd73bdf7",
"triggerType" : "PUSH"
}, {
"hash" : "d520fe1077ed24965f8aa005113d2b81d5de02f1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25493",
"triggerID" : "d520fe1077ed24965f8aa005113d2b81d5de02f1",
"triggerType" : "PUSH"
}, {
"hash" : "1d879321a186ed21b45303b0fcd0c26ebdb63e93",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25850",
"triggerID" : "1d879321a186ed21b45303b0fcd0c26ebdb63e93",
"triggerType" : "PUSH"
}, {
"hash" : "b4cbaa42fa0bdd50d2ce02537b5653283c48c7be",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "b4cbaa42fa0bdd50d2ce02537b5653283c48c7be",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1d879321a186ed21b45303b0fcd0c26ebdb63e93 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25850)
* b4cbaa42fa0bdd50d2ce02537b5653283c48c7be UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14891: [FLINK-21289][deployment] FIX missing load pipeline.classpaths in app…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14891:
URL: https://github.com/apache/flink/pull/14891#issuecomment-774628149
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "14b5a6087502e50efef5242eb44802ff45af4a47",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13051",
"triggerID" : "14b5a6087502e50efef5242eb44802ff45af4a47",
"triggerType" : "PUSH"
}, {
"hash" : "9c2009b345b3c138b83d25d2ca929a33f5918ab8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13081",
"triggerID" : "9c2009b345b3c138b83d25d2ca929a33f5918ab8",
"triggerType" : "PUSH"
}, {
"hash" : "29ddfd1a206cb8d33e1c5a0f0ca7c1097c77d327",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13088",
"triggerID" : "29ddfd1a206cb8d33e1c5a0f0ca7c1097c77d327",
"triggerType" : "PUSH"
}, {
"hash" : "1976f8fa0310d74fccbd2ccf0ccb6f7b904a60a6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13430",
"triggerID" : "1976f8fa0310d74fccbd2ccf0ccb6f7b904a60a6",
"triggerType" : "PUSH"
}, {
"hash" : "c4db5e1f7e1adbb6b4c21c4dccf211728fbc2f78",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13483",
"triggerID" : "c4db5e1f7e1adbb6b4c21c4dccf211728fbc2f78",
"triggerType" : "PUSH"
}, {
"hash" : "ceba8ed8fb1209a1d2470c7d45cbce6b80e9cbb4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13628",
"triggerID" : "ceba8ed8fb1209a1d2470c7d45cbce6b80e9cbb4",
"triggerType" : "PUSH"
}, {
"hash" : "150a5be15d8605d4fe2214e2e02a97d9bd73bdf7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13637",
"triggerID" : "150a5be15d8605d4fe2214e2e02a97d9bd73bdf7",
"triggerType" : "PUSH"
}, {
"hash" : "d520fe1077ed24965f8aa005113d2b81d5de02f1",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25493",
"triggerID" : "d520fe1077ed24965f8aa005113d2b81d5de02f1",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d520fe1077ed24965f8aa005113d2b81d5de02f1 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25493)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14891: [FLINK-21289][deployment] FIX missing load pipeline.classpaths in app…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14891:
URL: https://github.com/apache/flink/pull/14891#issuecomment-774628149
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "14b5a6087502e50efef5242eb44802ff45af4a47",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13051",
"triggerID" : "14b5a6087502e50efef5242eb44802ff45af4a47",
"triggerType" : "PUSH"
}, {
"hash" : "9c2009b345b3c138b83d25d2ca929a33f5918ab8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13081",
"triggerID" : "9c2009b345b3c138b83d25d2ca929a33f5918ab8",
"triggerType" : "PUSH"
}, {
"hash" : "29ddfd1a206cb8d33e1c5a0f0ca7c1097c77d327",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13088",
"triggerID" : "29ddfd1a206cb8d33e1c5a0f0ca7c1097c77d327",
"triggerType" : "PUSH"
}, {
"hash" : "1976f8fa0310d74fccbd2ccf0ccb6f7b904a60a6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13430",
"triggerID" : "1976f8fa0310d74fccbd2ccf0ccb6f7b904a60a6",
"triggerType" : "PUSH"
}, {
"hash" : "c4db5e1f7e1adbb6b4c21c4dccf211728fbc2f78",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13483",
"triggerID" : "c4db5e1f7e1adbb6b4c21c4dccf211728fbc2f78",
"triggerType" : "PUSH"
}, {
"hash" : "ceba8ed8fb1209a1d2470c7d45cbce6b80e9cbb4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13628",
"triggerID" : "ceba8ed8fb1209a1d2470c7d45cbce6b80e9cbb4",
"triggerType" : "PUSH"
}, {
"hash" : "150a5be15d8605d4fe2214e2e02a97d9bd73bdf7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13637",
"triggerID" : "150a5be15d8605d4fe2214e2e02a97d9bd73bdf7",
"triggerType" : "PUSH"
}, {
"hash" : "d520fe1077ed24965f8aa005113d2b81d5de02f1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25493",
"triggerID" : "d520fe1077ed24965f8aa005113d2b81d5de02f1",
"triggerType" : "PUSH"
}, {
"hash" : "1d879321a186ed21b45303b0fcd0c26ebdb63e93",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25850",
"triggerID" : "1d879321a186ed21b45303b0fcd0c26ebdb63e93",
"triggerType" : "PUSH"
}, {
"hash" : "b4cbaa42fa0bdd50d2ce02537b5653283c48c7be",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26142",
"triggerID" : "b4cbaa42fa0bdd50d2ce02537b5653283c48c7be",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1d879321a186ed21b45303b0fcd0c26ebdb63e93 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25850)
* b4cbaa42fa0bdd50d2ce02537b5653283c48c7be Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26142)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14891: [FLINK-21289][deployment] FIX missing load pipeline.classpaths in app…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14891:
URL: https://github.com/apache/flink/pull/14891#issuecomment-774628149
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "14b5a6087502e50efef5242eb44802ff45af4a47",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13051",
"triggerID" : "14b5a6087502e50efef5242eb44802ff45af4a47",
"triggerType" : "PUSH"
}, {
"hash" : "9c2009b345b3c138b83d25d2ca929a33f5918ab8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13081",
"triggerID" : "9c2009b345b3c138b83d25d2ca929a33f5918ab8",
"triggerType" : "PUSH"
}, {
"hash" : "29ddfd1a206cb8d33e1c5a0f0ca7c1097c77d327",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13088",
"triggerID" : "29ddfd1a206cb8d33e1c5a0f0ca7c1097c77d327",
"triggerType" : "PUSH"
}, {
"hash" : "1976f8fa0310d74fccbd2ccf0ccb6f7b904a60a6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13430",
"triggerID" : "1976f8fa0310d74fccbd2ccf0ccb6f7b904a60a6",
"triggerType" : "PUSH"
}, {
"hash" : "c4db5e1f7e1adbb6b4c21c4dccf211728fbc2f78",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13483",
"triggerID" : "c4db5e1f7e1adbb6b4c21c4dccf211728fbc2f78",
"triggerType" : "PUSH"
}, {
"hash" : "ceba8ed8fb1209a1d2470c7d45cbce6b80e9cbb4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13628",
"triggerID" : "ceba8ed8fb1209a1d2470c7d45cbce6b80e9cbb4",
"triggerType" : "PUSH"
}, {
"hash" : "150a5be15d8605d4fe2214e2e02a97d9bd73bdf7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13637",
"triggerID" : "150a5be15d8605d4fe2214e2e02a97d9bd73bdf7",
"triggerType" : "PUSH"
}, {
"hash" : "d520fe1077ed24965f8aa005113d2b81d5de02f1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25493",
"triggerID" : "d520fe1077ed24965f8aa005113d2b81d5de02f1",
"triggerType" : "PUSH"
}, {
"hash" : "1d879321a186ed21b45303b0fcd0c26ebdb63e93",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25850",
"triggerID" : "1d879321a186ed21b45303b0fcd0c26ebdb63e93",
"triggerType" : "PUSH"
}, {
"hash" : "b4cbaa42fa0bdd50d2ce02537b5653283c48c7be",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26142",
"triggerID" : "b4cbaa42fa0bdd50d2ce02537b5653283c48c7be",
"triggerType" : "PUSH"
}, {
"hash" : "4279b2e8b1e5f69f6a820b0ba3cb06df26b87142",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26231",
"triggerID" : "4279b2e8b1e5f69f6a820b0ba3cb06df26b87142",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* b4cbaa42fa0bdd50d2ce02537b5653283c48c7be Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26142)
* 4279b2e8b1e5f69f6a820b0ba3cb06df26b87142 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26231)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14891: [FLINK-21289][deployment] FIX missing load pipeline.classpaths in app…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14891:
URL: https://github.com/apache/flink/pull/14891#issuecomment-774628149
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "14b5a6087502e50efef5242eb44802ff45af4a47",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13051",
"triggerID" : "14b5a6087502e50efef5242eb44802ff45af4a47",
"triggerType" : "PUSH"
}, {
"hash" : "9c2009b345b3c138b83d25d2ca929a33f5918ab8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13081",
"triggerID" : "9c2009b345b3c138b83d25d2ca929a33f5918ab8",
"triggerType" : "PUSH"
}, {
"hash" : "29ddfd1a206cb8d33e1c5a0f0ca7c1097c77d327",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13088",
"triggerID" : "29ddfd1a206cb8d33e1c5a0f0ca7c1097c77d327",
"triggerType" : "PUSH"
}, {
"hash" : "1976f8fa0310d74fccbd2ccf0ccb6f7b904a60a6",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13430",
"triggerID" : "1976f8fa0310d74fccbd2ccf0ccb6f7b904a60a6",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 29ddfd1a206cb8d33e1c5a0f0ca7c1097c77d327 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13088)
* 1976f8fa0310d74fccbd2ccf0ccb6f7b904a60a6 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13430)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wangyang0918 commented on pull request #14891: [FLINK-21289][deployment] FIX missing load pipeline.classpaths in app…
Posted by GitBox <gi...@apache.org>.
wangyang0918 commented on pull request #14891:
URL: https://github.com/apache/flink/pull/14891#issuecomment-775610643
@PChou What I mean is adding a private method `ClassPathPackagedProgramRetriever#buildUserClassPaths`. It will be used to initialize the `userClassPaths` variable in constructor. Do we have some situations that the `pipeline.classpaths` should not be added to the user classpaths? If not, then I think merging the `pipeline.classpaths` and `usrlib` internally in `ClassPathPackagedProgramRetriever` is reasonable.
BTW, based on your current implementation, the `StandaloneApplicationClusterEntryPoint` also needs to set the pipeline classpath.
> When "other mode" access the ClassPathPackagedProgramRetriever, pipelineClassPath is empty collection by default, that will not affect the mode's behavior
So do you mean in "other mode", we do not need to set the pipeline classpaths? I am afraid I cannot agree with you. The `ClassPathPackagedProgramRetriever` always should set the pipeline classpaths.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] PChou commented on pull request #14891: [FLINK-21289][deployment] FIX missing load pipeline.classpaths in app…
Posted by GitBox <gi...@apache.org>.
PChou commented on pull request #14891:
URL: https://github.com/apache/flink/pull/14891#issuecomment-783803123
@wangyang0918 Fix. Please review
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14891: [FLINK-21289][deployment] FIX missing load pipeline.classpaths in app…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14891:
URL: https://github.com/apache/flink/pull/14891#issuecomment-774628149
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "14b5a6087502e50efef5242eb44802ff45af4a47",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13051",
"triggerID" : "14b5a6087502e50efef5242eb44802ff45af4a47",
"triggerType" : "PUSH"
}, {
"hash" : "9c2009b345b3c138b83d25d2ca929a33f5918ab8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13081",
"triggerID" : "9c2009b345b3c138b83d25d2ca929a33f5918ab8",
"triggerType" : "PUSH"
}, {
"hash" : "29ddfd1a206cb8d33e1c5a0f0ca7c1097c77d327",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13088",
"triggerID" : "29ddfd1a206cb8d33e1c5a0f0ca7c1097c77d327",
"triggerType" : "PUSH"
}, {
"hash" : "1976f8fa0310d74fccbd2ccf0ccb6f7b904a60a6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13430",
"triggerID" : "1976f8fa0310d74fccbd2ccf0ccb6f7b904a60a6",
"triggerType" : "PUSH"
}, {
"hash" : "c4db5e1f7e1adbb6b4c21c4dccf211728fbc2f78",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13483",
"triggerID" : "c4db5e1f7e1adbb6b4c21c4dccf211728fbc2f78",
"triggerType" : "PUSH"
}, {
"hash" : "ceba8ed8fb1209a1d2470c7d45cbce6b80e9cbb4",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13628",
"triggerID" : "ceba8ed8fb1209a1d2470c7d45cbce6b80e9cbb4",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c4db5e1f7e1adbb6b4c21c4dccf211728fbc2f78 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13483)
* ceba8ed8fb1209a1d2470c7d45cbce6b80e9cbb4 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13628)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] PChou commented on a change in pull request #14891: [FLINK-21289][deployment] FIX missing load pipeline.classpaths in app…
Posted by GitBox <gi...@apache.org>.
PChou commented on a change in pull request #14891:
URL: https://github.com/apache/flink/pull/14891#discussion_r580863343
##########
File path: flink-clients/src/test/java/org/apache/flink/client/deployment/application/ClassPathPackagedProgramRetrieverTest.java
##########
@@ -315,6 +327,24 @@ public void testRetrieveCorrectUserClasspathsWithSpecifiedEntryClass()
containsInAnyOrder(expectedURLs.stream().map(URL::toString).toArray()));
}
+ @Test
Review comment:
yes, it should be better.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wangyang0918 commented on a change in pull request #14891: [FLINK-21289][deployment] FIX missing load pipeline.classpaths in app…
Posted by GitBox <gi...@apache.org>.
wangyang0918 commented on a change in pull request #14891:
URL: https://github.com/apache/flink/pull/14891#discussion_r580845485
##########
File path: flink-clients/src/test/java/org/apache/flink/client/deployment/application/ClassPathPackagedProgramRetrieverTest.java
##########
@@ -315,6 +327,24 @@ public void testRetrieveCorrectUserClasspathsWithSpecifiedEntryClass()
containsInAnyOrder(expectedURLs.stream().map(URL::toString).toArray()));
}
+ @Test
Review comment:
I think the new introduced test does not cover the merging with usrlib and `pipeline.classpaths`. What do you think about making the test like this?
```
@Test
public void testRetrieveCorrectUserClasspathsWithPipelineClasspaths()
throws IOException, FlinkException, ProgramInvocationException {
final Configuration configuration = new Configuration();
final List<String> pipelineJars =
Arrays.asList("file:///path/of/p1.jar", "http://path/of/p2.jar");
configuration.set(PipelineOptions.CLASSPATHS, pipelineJars);
final ClassPathPackagedProgramRetriever retrieverUnderTest =
ClassPathPackagedProgramRetriever.newBuilder(PROGRAM_ARGUMENTS)
.setUserLibDirectory(userDirHasEntryClass)
.setJarFile(TestJob.getTestJobJar())
.setConfiguration(configuration)
.build();
final JobGraph jobGraph = retrieveJobGraph(retrieverUnderTest, new Configuration());
final List<URL> expectedMergedURLs = new ArrayList<>(expectedURLs);
expectedMergedURLs.addAll(
pipelineJars.stream()
.map(FunctionUtils.uncheckedFunction(URL::new))
.collect(Collectors.toList()));
assertThat(
jobGraph.getClasspaths().stream().map(URL::toString).collect(Collectors.toList()),
containsInAnyOrder(expectedMergedURLs.stream().map(URL::toString).toArray()));
}
```
##########
File path: flink-container/src/main/java/org/apache/flink/container/entrypoint/StandaloneApplicationClusterEntryPoint.java
##########
@@ -62,16 +62,16 @@ public static void main(String[] args) {
args,
new StandaloneApplicationClusterConfigurationParserFactory(),
StandaloneApplicationClusterEntryPoint.class);
+ Configuration configuration = loadConfigurationFromClusterConfig(clusterConfiguration);
Review comment:
Could be `final`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14891: [FLINK-21289][deployment] FIX missing load pipeline.classpaths in app…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14891:
URL: https://github.com/apache/flink/pull/14891#issuecomment-774628149
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "14b5a6087502e50efef5242eb44802ff45af4a47",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13051",
"triggerID" : "14b5a6087502e50efef5242eb44802ff45af4a47",
"triggerType" : "PUSH"
}, {
"hash" : "9c2009b345b3c138b83d25d2ca929a33f5918ab8",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "9c2009b345b3c138b83d25d2ca929a33f5918ab8",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 14b5a6087502e50efef5242eb44802ff45af4a47 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13051)
* 9c2009b345b3c138b83d25d2ca929a33f5918ab8 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14891: [FLINK-21289][deployment] FIX missing load pipeline.classpaths in app…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14891:
URL: https://github.com/apache/flink/pull/14891#issuecomment-774628149
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "14b5a6087502e50efef5242eb44802ff45af4a47",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13051",
"triggerID" : "14b5a6087502e50efef5242eb44802ff45af4a47",
"triggerType" : "PUSH"
}, {
"hash" : "9c2009b345b3c138b83d25d2ca929a33f5918ab8",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13081",
"triggerID" : "9c2009b345b3c138b83d25d2ca929a33f5918ab8",
"triggerType" : "PUSH"
}, {
"hash" : "29ddfd1a206cb8d33e1c5a0f0ca7c1097c77d327",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13088",
"triggerID" : "29ddfd1a206cb8d33e1c5a0f0ca7c1097c77d327",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 9c2009b345b3c138b83d25d2ca929a33f5918ab8 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13081)
* 29ddfd1a206cb8d33e1c5a0f0ca7c1097c77d327 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13088)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14891: [FLINK-21289][deployment] FIX missing load pipeline.classpaths in app…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14891:
URL: https://github.com/apache/flink/pull/14891#issuecomment-774628149
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "14b5a6087502e50efef5242eb44802ff45af4a47",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13051",
"triggerID" : "14b5a6087502e50efef5242eb44802ff45af4a47",
"triggerType" : "PUSH"
}, {
"hash" : "9c2009b345b3c138b83d25d2ca929a33f5918ab8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13081",
"triggerID" : "9c2009b345b3c138b83d25d2ca929a33f5918ab8",
"triggerType" : "PUSH"
}, {
"hash" : "29ddfd1a206cb8d33e1c5a0f0ca7c1097c77d327",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13088",
"triggerID" : "29ddfd1a206cb8d33e1c5a0f0ca7c1097c77d327",
"triggerType" : "PUSH"
}, {
"hash" : "1976f8fa0310d74fccbd2ccf0ccb6f7b904a60a6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13430",
"triggerID" : "1976f8fa0310d74fccbd2ccf0ccb6f7b904a60a6",
"triggerType" : "PUSH"
}, {
"hash" : "c4db5e1f7e1adbb6b4c21c4dccf211728fbc2f78",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13483",
"triggerID" : "c4db5e1f7e1adbb6b4c21c4dccf211728fbc2f78",
"triggerType" : "PUSH"
}, {
"hash" : "ceba8ed8fb1209a1d2470c7d45cbce6b80e9cbb4",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "ceba8ed8fb1209a1d2470c7d45cbce6b80e9cbb4",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c4db5e1f7e1adbb6b4c21c4dccf211728fbc2f78 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13483)
* ceba8ed8fb1209a1d2470c7d45cbce6b80e9cbb4 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wangyang0918 commented on pull request #14891: [FLINK-21289][deployment] FIX missing load pipeline.classpaths in app…
Posted by GitBox <gi...@apache.org>.
wangyang0918 commented on pull request #14891:
URL: https://github.com/apache/flink/pull/14891#issuecomment-781025442
@PChou Sorry for the late response. I think we could introduce the `setConfiguration` for `ClassPathPackagedProgramRetriever.Builder`. If you check the implementation of `PackagedProgram.Builder`, you could find that it also support set the configuration.
Actually, I believe we should also set the configuration for `PackagedProgram.Builder` in `ClassPathPackagedProgramRetriever`. It just seems that we forget to do this now.
WDYT?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] PChou commented on pull request #14891: [FLINK-21289][deployment] FIX missing load pipeline.classpaths in app…
Posted by GitBox <gi...@apache.org>.
PChou commented on pull request #14891:
URL: https://github.com/apache/flink/pull/14891#issuecomment-775638451
@wangyang0918 err...i have no idea about `StandaloneApplicationClusterEntryPoint` actually. so you mean `StandaloneApplicationClusterEntryPoint` also have the issue? and the fix should implement in `ClassPathPackagedProgramRetriever` internally?
if so, `ClassPathPackagedProgramRetriever` or `ClassPathPackagedProgramRetriever.Builder` have to access Configuration directly.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14891: [FLINK-21289][deployment] FIX missing load pipeline.classpaths in app…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14891:
URL: https://github.com/apache/flink/pull/14891#issuecomment-774628149
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "14b5a6087502e50efef5242eb44802ff45af4a47",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13051",
"triggerID" : "14b5a6087502e50efef5242eb44802ff45af4a47",
"triggerType" : "PUSH"
}, {
"hash" : "9c2009b345b3c138b83d25d2ca929a33f5918ab8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13081",
"triggerID" : "9c2009b345b3c138b83d25d2ca929a33f5918ab8",
"triggerType" : "PUSH"
}, {
"hash" : "29ddfd1a206cb8d33e1c5a0f0ca7c1097c77d327",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13088",
"triggerID" : "29ddfd1a206cb8d33e1c5a0f0ca7c1097c77d327",
"triggerType" : "PUSH"
}, {
"hash" : "1976f8fa0310d74fccbd2ccf0ccb6f7b904a60a6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13430",
"triggerID" : "1976f8fa0310d74fccbd2ccf0ccb6f7b904a60a6",
"triggerType" : "PUSH"
}, {
"hash" : "c4db5e1f7e1adbb6b4c21c4dccf211728fbc2f78",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13483",
"triggerID" : "c4db5e1f7e1adbb6b4c21c4dccf211728fbc2f78",
"triggerType" : "PUSH"
}, {
"hash" : "ceba8ed8fb1209a1d2470c7d45cbce6b80e9cbb4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13628",
"triggerID" : "ceba8ed8fb1209a1d2470c7d45cbce6b80e9cbb4",
"triggerType" : "PUSH"
}, {
"hash" : "150a5be15d8605d4fe2214e2e02a97d9bd73bdf7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13637",
"triggerID" : "150a5be15d8605d4fe2214e2e02a97d9bd73bdf7",
"triggerType" : "PUSH"
}, {
"hash" : "d520fe1077ed24965f8aa005113d2b81d5de02f1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25493",
"triggerID" : "d520fe1077ed24965f8aa005113d2b81d5de02f1",
"triggerType" : "PUSH"
}, {
"hash" : "1d879321a186ed21b45303b0fcd0c26ebdb63e93",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25850",
"triggerID" : "1d879321a186ed21b45303b0fcd0c26ebdb63e93",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1d879321a186ed21b45303b0fcd0c26ebdb63e93 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25850)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] tillrohrmann commented on a change in pull request #14891: [FLINK-21289][deployment] FIX missing load pipeline.classpaths in app…
Posted by GitBox <gi...@apache.org>.
tillrohrmann commented on a change in pull request #14891:
URL: https://github.com/apache/flink/pull/14891#discussion_r740955044
##########
File path: flink-clients/src/main/java/org/apache/flink/client/program/DefaultPackagedProgramRetriever.java
##########
@@ -217,4 +221,13 @@ public PackagedProgram getPackagedProgram() throws FlinkException {
.collect(Collectors.toList());
return Collections.unmodifiableList(relativeJarURLs);
}
+
+ private static List<URL> getPipelineClassPaths(@Nullable Configuration configuration)
Review comment:
I think the `configuration` is not `null`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14891: [FLINK-21289][deployment] FIX missing load pipeline.classpaths in app…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14891:
URL: https://github.com/apache/flink/pull/14891#issuecomment-774628149
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "14b5a6087502e50efef5242eb44802ff45af4a47",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13051",
"triggerID" : "14b5a6087502e50efef5242eb44802ff45af4a47",
"triggerType" : "PUSH"
}, {
"hash" : "9c2009b345b3c138b83d25d2ca929a33f5918ab8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13081",
"triggerID" : "9c2009b345b3c138b83d25d2ca929a33f5918ab8",
"triggerType" : "PUSH"
}, {
"hash" : "29ddfd1a206cb8d33e1c5a0f0ca7c1097c77d327",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13088",
"triggerID" : "29ddfd1a206cb8d33e1c5a0f0ca7c1097c77d327",
"triggerType" : "PUSH"
}, {
"hash" : "1976f8fa0310d74fccbd2ccf0ccb6f7b904a60a6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13430",
"triggerID" : "1976f8fa0310d74fccbd2ccf0ccb6f7b904a60a6",
"triggerType" : "PUSH"
}, {
"hash" : "c4db5e1f7e1adbb6b4c21c4dccf211728fbc2f78",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13483",
"triggerID" : "c4db5e1f7e1adbb6b4c21c4dccf211728fbc2f78",
"triggerType" : "PUSH"
}, {
"hash" : "ceba8ed8fb1209a1d2470c7d45cbce6b80e9cbb4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13628",
"triggerID" : "ceba8ed8fb1209a1d2470c7d45cbce6b80e9cbb4",
"triggerType" : "PUSH"
}, {
"hash" : "150a5be15d8605d4fe2214e2e02a97d9bd73bdf7",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13637",
"triggerID" : "150a5be15d8605d4fe2214e2e02a97d9bd73bdf7",
"triggerType" : "PUSH"
}, {
"hash" : "d520fe1077ed24965f8aa005113d2b81d5de02f1",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25493",
"triggerID" : "d520fe1077ed24965f8aa005113d2b81d5de02f1",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 150a5be15d8605d4fe2214e2e02a97d9bd73bdf7 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13637)
* d520fe1077ed24965f8aa005113d2b81d5de02f1 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25493)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org