[jira] [Commented] (CB-3384) Resource Loading API for Android

["Andrew Grieve (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CB-3384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13694129#comment-13694129 ] 

Andrew Grieve commented on CB-3384:
-----------------------------------

Okay, I've completely rewritten this to be lower risk, cleaner API (IMO), and added unit tests. 
Review request: https://reviews.apache.org/r/12114/

Still want to get this in for 3.0 since AppHarness and Chrome plugins depend on it. The new patch does not touch any plugins. Updating the plugins to use the API can come later and should be thought out on a case-by-case basis.
                
> Resource Loading API for Android
> --------------------------------
>
>                 Key: CB-3384
>                 URL: https://issues.apache.org/jira/browse/CB-3384
>             Project: Apache Cordova
>          Issue Type: Improvement
>          Components: Android
>            Reporter: Andrew Grieve
>            Assignee: Shravan Narayan
>             Fix For: 3.1.0
>
>
> Motivations:
> 1. Many plugins do not handle URLs correctly when they are in the form content: or file:///android_asset. 
> 2. For the cordova-app-harness, there needs to be a way to re-route resource load requests so that the harness can load app resources while still respecting the <content> tag.
> Short Description
> All plugins can watch the loading of any uri's Eg: opening of files, the browser making requests to load files etc etc.
> In addition to watching they may assist in loading the uri's.
> For example, a use case here is - suppose a mimetype for a hypothetical extension ".abc" doesn't exist, a plugin could check the extension of a loaded uri and set the mimetype. This would now be set for all files loaded in the system.
> Pseudo code of the mechanism:
> 1. make a request 'R' to a uri.
> 2. loop through all plugins to see if any plugins change the request
> 3. if the request changes, set 'R' to this modified request and repeat step 3
> 4. load request 'R' and return result

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira