[jira] [Commented] (OOZIE-675) checkMultipleTimeInstances doesn't work for EL extensions

["Mohammad Kamrul Islam (Commented) (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OOZIE-675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13199599#comment-13199599 ] 

Mohammad Kamrul Islam commented on OOZIE-675:
---------------------------------------------

Are you talking about "if (instanceValue.contains(",")) {" part of the method?

As of now, we expect built-in EL functions like current() and latest() or specific dates. None of those has "," and therefore it is not an issue.
However , your EL extension has multiple parameters and  hence a comma (," is there that breaks throw the exception.

Did I understand the issue correctly?

Probable resolution:
We want to make sure there is only one ultimate value per instance. We could do this checking/enforcement after the EL resolution stage where we can ensure if there are indeed multiple values or not. In general, this EL evaluation needs to be done later (not during job submission). In this resolution, job submission will be fine. However, the error will come very late stage and fail.
 
In another note:
By your short description, I think if you could instead consider to use the built-in two EL functions for your today(0, 0).

coord:formatTime(coord.nominalTime(), "The required Date  Format")

One thing, I'm not sure those functions are valid in instance tag. If not , we could allow those in that context.
 

Ref: http://yahoo.github.com/oozie/releases/3.1.0/CoordinatorFunctionalSpec.html#a6.8.2._coord:formatTimeString_ts_String_format_EL_Function_since_Oozie_2.3.2
                
> checkMultipleTimeInstances doesn't work for EL extensions
> ---------------------------------------------------------
>
>                 Key: OOZIE-675
>                 URL: https://issues.apache.org/jira/browse/OOZIE-675
>             Project: Oozie
>          Issue Type: Bug
>            Reporter: Shwetha G S
>              Labels: EL, extensions
>
> To guard against specifying multiple instances in instance tag, CoordSubmitXCommand.checkMultipleTimeInstances checks for ',' in instance tag. This breaks for EL extensions. We have EL extension today(0,0) which maps to start day of nominal time. today(0,0) resolves to a single instance and presence of ',' doesn't imply that it resolves to multiple instances
> Can you please fix this

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira