You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2021/04/30 06:55:09 UTC
[GitHub] [iotdb] wangchao316 opened a new pull request #3114: Fix reduce frequent log printing.
wangchao316 opened a new pull request #3114:
URL: https://github.com/apache/iotdb/pull/3114
The report log is printed every 10 seconds and is frequently printed. As a result, the log is updated quickly. Therefore, the log level is changed to debug.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] neuyilan edited a comment on pull request #3114: Fix reduce frequent log printing.
Posted by GitBox <gi...@apache.org>.
neuyilan edited a comment on pull request #3114:
URL: https://github.com/apache/iotdb/pull/3114#issuecomment-829913748
> > Hi， the log is reported every 10 seconds, and I think it's useful to see the cluster status like the raft groups and the log incremental, I'd like it as info level, What your opition？
>
> hi , thanks houliang.
> I feel like 10s are more frequent, and there are two ways to alleviate it.
>
> 1. Parameters can be added to set the print frequency. Hot modification is supported. If the cluster is unstable, you can set the frequency to a high value. In common scenarios, you can set the frequency to a low value.
> 2. Change the log level to debug.
> do you feel How about option 1?
Thanks for your remind, It suddenly occurred to me that the logback has support that when 60 seconds rescan the log configuration, I think changing the log level to debug maybe is enough.😁, when we encountered some problems with the cluster, we may change the info level to debug is enough.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] wangchao316 commented on pull request #3114: Fix reduce frequent log printing.
Posted by GitBox <gi...@apache.org>.
wangchao316 commented on pull request #3114:
URL: https://github.com/apache/iotdb/pull/3114#issuecomment-829916110
> > > Hi， the log is reported every 10 seconds, and I think it's useful to see the cluster status like the raft groups and the log incremental, I'd like it as info level, What your opition？
> >
> >
> > hi , thanks houliang.
> > I feel like 10s are more frequent, and there are two ways to alleviate it.
> >
> > 1. Parameters can be added to set the print frequency. Hot modification is supported. If the cluster is unstable, you can set the frequency to a high value. In common scenarios, you can set the frequency to a low value.
> > 2. Change the log level to debug.
> > do you feel How about option 1?
>
> Thanks for your remind, It suddenly occurred to me that the logback has support that when 60 seconds rescan the log configuration, I think changing the log level to debug maybe is enough.😁
yes
> > > Hi， the log is reported every 10 seconds, and I think it's useful to see the cluster status like the raft groups and the log incremental, I'd like it as info level, What your opition？
> >
> >
> > hi , thanks houliang.
> > I feel like 10s are more frequent, and there are two ways to alleviate it.
> >
> > 1. Parameters can be added to set the print frequency. Hot modification is supported. If the cluster is unstable, you can set the frequency to a high value. In common scenarios, you can set the frequency to a low value.
> > 2. Change the log level to debug.
> > do you feel How about option 1?
>
> Thanks for your remind, It suddenly occurred to me that the logback has support that when 60 seconds rescan the log configuration, I think changing the log level to debug maybe is enough.😁, when we encountered some problems with the cluster, we may change the info level to debug is enough.
yes, we alter log level when we need
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] mychaow commented on pull request #3114: [IOTDB-1349]Fix reduce frequent log printing.
Posted by GitBox <gi...@apache.org>.
mychaow commented on pull request #3114:
URL: https://github.com/apache/iotdb/pull/3114#issuecomment-830629560
> As I want to release v0.12.1. how about accepting the log level change first?
> If there is good solution to change the frequency, let's do it.
OK
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] neuyilan commented on pull request #3114: Fix reduce frequent log printing.
Posted by GitBox <gi...@apache.org>.
neuyilan commented on pull request #3114:
URL: https://github.com/apache/iotdb/pull/3114#issuecomment-829913748
> > Hi， the log is reported every 10 seconds, and I think it's useful to see the cluster status like the raft groups and the log incremental, I'd like it as info level, What your opition？
>
> hi , thanks houliang.
> I feel like 10s are more frequent, and there are two ways to alleviate it.
>
> 1. Parameters can be added to set the print frequency. Hot modification is supported. If the cluster is unstable, you can set the frequency to a high value. In common scenarios, you can set the frequency to a low value.
> 2. Change the log level to debug.
> do you feel How about option 1?
Thanks for your remind, It suddenly occurred to me that the logback has support that when 60 seconds rescan the log configuration, I think changing the log level to debug maybe is enough.😁
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] jixuan1989 commented on pull request #3114: [IOTDB-1349]Fix reduce frequent log printing.
Posted by GitBox <gi...@apache.org>.
jixuan1989 commented on pull request #3114:
URL: https://github.com/apache/iotdb/pull/3114#issuecomment-830200667
As I want to release v0.12.1. how about accepting the log level change first?
If there is good solution to change the frequency, let's do it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] wangchao316 edited a comment on pull request #3114: Fix reduce frequent log printing.
Posted by GitBox <gi...@apache.org>.
wangchao316 edited a comment on pull request #3114:
URL: https://github.com/apache/iotdb/pull/3114#issuecomment-829899599
> Hi， the log is reported every 10 seconds, and I think it's useful to see the cluster status like the raft groups and the log incremental, I'd like it as info level, What your opition？
hi , thanks houliang.
I feel like 10s are more frequent, and there are two ways to alleviate it.
1. Parameters can be added to set the print frequency. Hot modification is supported. If the cluster is unstable, you can set the frequency to a high value. In common scenarios, you can set the frequency to a low value.
2. Change the log level to debug.
do you feel How about option 1?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] wangchao316 edited a comment on pull request #3114: Fix reduce frequent log printing.
Posted by GitBox <gi...@apache.org>.
wangchao316 edited a comment on pull request #3114:
URL: https://github.com/apache/iotdb/pull/3114#issuecomment-829916110
> > > Hi， the log is reported every 10 seconds, and I think it's useful to see the cluster status like the raft groups and the log incremental, I'd like it as info level, What your opition？
> >
> >
> > hi , thanks houliang.
> > I feel like 10s are more frequent, and there are two ways to alleviate it.
> >
> > 1. Parameters can be added to set the print frequency. Hot modification is supported. If the cluster is unstable, you can set the frequency to a high value. In common scenarios, you can set the frequency to a low value.
> > 2. Change the log level to debug.
> > do you feel How about option 1?
>
> Thanks for your remind, It suddenly occurred to me that the logback has support that when 60 seconds rescan the log configuration, I think changing the log level to debug maybe is enough.😁, when we encountered some problems with the cluster, we may change the info level to debug is enough.
yes, we alter log level when we need
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] wangchao316 commented on pull request #3114: Fix reduce frequent log printing.
Posted by GitBox <gi...@apache.org>.
wangchao316 commented on pull request #3114:
URL: https://github.com/apache/iotdb/pull/3114#issuecomment-829899599
> Hi， the log is reported every 10 seconds, and I think it's useful to see the cluster status like the raft groups and the log incremental, I'd like it as info level, What your opition？
hi , thanks houliang.
I feel like 10s are more frequent, and there are two ways to alleviate it.
1. Parameters can be added to set the print frequency. Hot modification is supported. If the cluster is unstable, you can set the frequency to a high value. In common scenarios, you can set the frequency to a low value.
2. Change the log level to debug.
do you feel How about option 1?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] mychaow merged pull request #3114: [IOTDB-1349]Fix reduce frequent log printing.
Posted by GitBox <gi...@apache.org>.
mychaow merged pull request #3114:
URL: https://github.com/apache/iotdb/pull/3114
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] mychaow commented on pull request #3114: [IOTDB-1349]Fix reduce frequent log printing.
Posted by GitBox <gi...@apache.org>.
mychaow commented on pull request #3114:
URL: https://github.com/apache/iotdb/pull/3114#issuecomment-830046726
I think it's better to set the frequency, because the problem didn't happen when you found it, but happened before. If there is a more accurate fault time point, it will help us locate the problem faster.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org