You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2021/10/07 20:35:21 UTC
[GitHub] [geode] davebarnes97 opened a new pull request #6957: GEODE-9567: Geode for Redis rename, additional doc corrections
davebarnes97 opened a new pull request #6957:
URL: https://github.com/apache/geode/pull/6957
Fixed a few remaining glitches in the user guide.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] ringles commented on a change in pull request #6957: GEODE-9567: Geode for Redis rename, additional doc corrections
Posted by GitBox <gi...@apache.org>.
ringles commented on a change in pull request #6957:
URL: https://github.com/apache/geode/pull/6957#discussion_r724519330
##########
File path: geode-docs/getting_started/intro_to_clients.html.md.erb
##########
@@ -355,11 +355,11 @@ int main(int argc, char** argv) {
- [Apache Geode Native C++ Client Documentation](https://geode.apache.org/docs/)
- [Apache Geode Native Client C++ API Reference](https://geode.apache.org/releases/latest/cppdocs/hierarchy.html)
-## <a id="client-intro-redis"></a>Geode for Redis
+## <a id="client-intro-redis"></a><%=vars.product_name%> for Redis
-The <%=vars.product_name_long%> Geode for Redis allow <%=vars.product_name_long%> to function as a drop-in replacement for a
+<%=vars.product_name%> Geode for Redis allows <%=vars.product_name_long%> to function as a drop-in replacement for a
Review comment:
I think there's still a stray Geode here: "<%=vars.product_name%> Geode"
##########
File path: geode-docs/getting_started/intro_to_clients.html.md.erb
##########
@@ -355,11 +355,11 @@ int main(int argc, char** argv) {
- [Apache Geode Native C++ Client Documentation](https://geode.apache.org/docs/)
- [Apache Geode Native Client C++ API Reference](https://geode.apache.org/releases/latest/cppdocs/hierarchy.html)
-## <a id="client-intro-redis"></a>Geode for Redis
+## <a id="client-intro-redis"></a><%=vars.product_name%> for Redis
-The <%=vars.product_name_long%> Geode for Redis allow <%=vars.product_name_long%> to function as a drop-in replacement for a
+<%=vars.product_name%> Geode for Redis allows <%=vars.product_name_long%> to function as a drop-in replacement for a
Review comment:
Suckers are easy to miss, aren't they? :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] ringles commented on a change in pull request #6957: GEODE-9567: Geode for Redis rename, additional doc corrections
Posted by GitBox <gi...@apache.org>.
ringles commented on a change in pull request #6957:
URL: https://github.com/apache/geode/pull/6957#discussion_r724561285
##########
File path: geode-docs/getting_started/intro_to_clients.html.md.erb
##########
@@ -355,11 +355,11 @@ int main(int argc, char** argv) {
- [Apache Geode Native C++ Client Documentation](https://geode.apache.org/docs/)
- [Apache Geode Native Client C++ API Reference](https://geode.apache.org/releases/latest/cppdocs/hierarchy.html)
-## <a id="client-intro-redis"></a>Geode for Redis
+## <a id="client-intro-redis"></a><%=vars.product_name%> for Redis
-The <%=vars.product_name_long%> Geode for Redis allow <%=vars.product_name_long%> to function as a drop-in replacement for a
+<%=vars.product_name%> Geode for Redis allows <%=vars.product_name_long%> to function as a drop-in replacement for a
Review comment:
Suckers are easy to miss, aren't they? :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] ringles commented on a change in pull request #6957: GEODE-9567: Geode for Redis rename, additional doc corrections
Posted by GitBox <gi...@apache.org>.
ringles commented on a change in pull request #6957:
URL: https://github.com/apache/geode/pull/6957#discussion_r724519330
##########
File path: geode-docs/getting_started/intro_to_clients.html.md.erb
##########
@@ -355,11 +355,11 @@ int main(int argc, char** argv) {
- [Apache Geode Native C++ Client Documentation](https://geode.apache.org/docs/)
- [Apache Geode Native Client C++ API Reference](https://geode.apache.org/releases/latest/cppdocs/hierarchy.html)
-## <a id="client-intro-redis"></a>Geode for Redis
+## <a id="client-intro-redis"></a><%=vars.product_name%> for Redis
-The <%=vars.product_name_long%> Geode for Redis allow <%=vars.product_name_long%> to function as a drop-in replacement for a
+<%=vars.product_name%> Geode for Redis allows <%=vars.product_name_long%> to function as a drop-in replacement for a
Review comment:
I think there's still a stray Geode here: "<%=vars.product_name%> Geode"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] davebarnes97 commented on a change in pull request #6957: GEODE-9567: Geode for Redis rename, additional doc corrections
Posted by GitBox <gi...@apache.org>.
davebarnes97 commented on a change in pull request #6957:
URL: https://github.com/apache/geode/pull/6957#discussion_r724558936
##########
File path: geode-docs/getting_started/intro_to_clients.html.md.erb
##########
@@ -355,11 +355,11 @@ int main(int argc, char** argv) {
- [Apache Geode Native C++ Client Documentation](https://geode.apache.org/docs/)
- [Apache Geode Native Client C++ API Reference](https://geode.apache.org/releases/latest/cppdocs/hierarchy.html)
-## <a id="client-intro-redis"></a>Geode for Redis
+## <a id="client-intro-redis"></a><%=vars.product_name%> for Redis
-The <%=vars.product_name_long%> Geode for Redis allow <%=vars.product_name_long%> to function as a drop-in replacement for a
+<%=vars.product_name%> Geode for Redis allows <%=vars.product_name_long%> to function as a drop-in replacement for a
Review comment:
Got it, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] davebarnes97 commented on a change in pull request #6957: GEODE-9567: Geode for Redis rename, additional doc corrections
Posted by GitBox <gi...@apache.org>.
davebarnes97 commented on a change in pull request #6957:
URL: https://github.com/apache/geode/pull/6957#discussion_r724558936
##########
File path: geode-docs/getting_started/intro_to_clients.html.md.erb
##########
@@ -355,11 +355,11 @@ int main(int argc, char** argv) {
- [Apache Geode Native C++ Client Documentation](https://geode.apache.org/docs/)
- [Apache Geode Native Client C++ API Reference](https://geode.apache.org/releases/latest/cppdocs/hierarchy.html)
-## <a id="client-intro-redis"></a>Geode for Redis
+## <a id="client-intro-redis"></a><%=vars.product_name%> for Redis
-The <%=vars.product_name_long%> Geode for Redis allow <%=vars.product_name_long%> to function as a drop-in replacement for a
+<%=vars.product_name%> Geode for Redis allows <%=vars.product_name_long%> to function as a drop-in replacement for a
Review comment:
Got it, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] davebarnes97 merged pull request #6957: GEODE-9567: Geode for Redis rename, additional doc corrections
Posted by GitBox <gi...@apache.org>.
davebarnes97 merged pull request #6957:
URL: https://github.com/apache/geode/pull/6957
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] davebarnes97 merged pull request #6957: GEODE-9567: Geode for Redis rename, additional doc corrections
Posted by GitBox <gi...@apache.org>.
davebarnes97 merged pull request #6957:
URL: https://github.com/apache/geode/pull/6957
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org