You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@calcite.apache.org by "Josh Elser (JIRA)" <ji...@apache.org> on 2017/07/07 23:00:00 UTC

[jira] [Commented] (CALCITE-1879) Consistent protobuf logging for protocol analysis

    [ https://issues.apache.org/jira/browse/CALCITE-1879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16078809#comment-16078809 ] 

Josh Elser commented on CALCITE-1879:
-------------------------------------

Generalizing, we already have all of the protobuf<->pojo logic encapsulated in ProtobufTranslationImpl. This is used by both client and server -- we should just make sure all code-paths in this class have the ability to print the protobuf messages at TRACE (rather than just client or just server).

> Consistent protobuf logging for protocol analysis
> -------------------------------------------------
>
>                 Key: CALCITE-1879
>                 URL: https://issues.apache.org/jira/browse/CALCITE-1879
>             Project: Calcite
>          Issue Type: Improvement
>          Components: avatica
>            Reporter: Josh Elser
>            Assignee: Josh Elser
>            Priority: Trivial
>             Fix For: avatica-1.11.0
>
>
> I had added logging to the Avatica server for the responses about to be sent out, but it seems like I missed them for requests which were just received. We should have both so that the Avatica server can be a single place to inspect protocol issues.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)