[GitHub] [geode-native] gaussianrecurrence edited a comment on pull request #810: GEODE-9322: Fix possible race condition on new ITs

[GitBox <gi...@apache.org>]

gaussianrecurrence edited a comment on pull request #810:
URL: https://github.com/apache/geode-native/pull/810#issuecomment-880116969


   > Looks good - though I don't fully understand the nature of the race condition you mention, I trust you've been over the details and fixed.
   
   Regarding this, basically it solves race condition in which the test proceeds before the server is actually stopped. Note that gfsh command "stop server" is not synchronous, so after its execution the server could be still up. And the equivalent happens with "start server"
   
   > Quick question - this part of your description: "Modified RegisterKeysTest to use gmock_actions helper." I see no changes to RegisterKeysTest. Are they missing, or is your PR description just out of date?
   
   Thanks for noticing this. As it seems to me, I made this fix along with PR #809, so in order to make the changes work there was some duplicity on both PRs, as #809 was merged I guess the delta doesn't show the RegisterKeysTest anymore. I'll update the description.
   
   Just a comment: I would like to improve the readability for the code in general and ITs in particular. So do you think it is possible to add a comment on ITs with a short description of what it does, as well as what's the test for?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org