You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by GitBox <gi...@apache.org> on 2022/10/13 02:52:40 UTC

[GitHub] [thrift] herocms opened a new pull request, #2709: fix(sec): upgrade com.google.guava:guava to 30.0-jre

herocms opened a new pull request, #2709:
URL: https://github.com/apache/thrift/pull/2709

   ### What happened?
   There are 2 security vulnerabilities found in com.google.guava:guava 14.0.1
   - [CVE-2018-10237](https://www.oscs1024.com/hd/CVE-2018-10237)
   - [CVE-2020-8908](https://www.oscs1024.com/hd/CVE-2020-8908)
   
   
   ### What did I do?
   Upgrade com.google.guava:guava from 14.0.1 to 30.0-jre for vulnerability fix
   
   ### What did you expect to happen?
   Ideally, no insecure libs should be used.
   
   ### The specification of the pull request
   [PR Specification](https://www.oscs1024.com/docs/pr-specification/) from OSCS


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@thrift.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [thrift] Jimexist commented on a diff in pull request #2709: fix(sec): upgrade com.google.guava:guava to 30.0-jre

Posted by GitBox <gi...@apache.org>.
Jimexist commented on code in PR #2709:
URL: https://github.com/apache/thrift/pull/2709#discussion_r994163229


##########
contrib/thrift-maven-plugin/pom.xml:
##########
@@ -16,11 +16,7 @@
  KIND, either express or implied. See the License for the
  specific language governing permissions and limitations
  under the License.
- -->
-<project
-  xmlns="http://maven.apache.org/POM/4.0.0"
-  xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
-  xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+ --><project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">

Review Comment:
   ```suggestion
    -->
    <project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [thrift] Jens-G merged pull request #2709: fix(sec): upgrade com.google.guava:guava to 30.0-jre

Posted by GitBox <gi...@apache.org>.
Jens-G merged PR #2709:
URL: https://github.com/apache/thrift/pull/2709


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@thrift.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org