You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2021/02/02 09:13:24 UTC

[GitHub] [iceberg] massdosage commented on a change in pull request #1648: Move to Apache Avro 1.10.1

massdosage commented on a change in pull request #1648:
URL: https://github.com/apache/iceberg/pull/1648#discussion_r568436222



##########
File path: api/src/test/java/org/apache/iceberg/AssertHelpers.java
##########
@@ -137,4 +139,16 @@ private static void handleException(String message,
       throw e;
     }
   }
+
+  /**
+   * A convenience method to assert the cause of thrown exception.

Review comment:
       Javadoc looks wrong, cut and paste error?

##########
File path: parquet/src/test/java/org/apache/iceberg/TestHelpers.java
##########
@@ -85,4 +87,17 @@ private static void handleException(String message,
       throw e;
     }
   }
+
+  /**
+   * A convenience method to assert the cause of thrown exception.

Review comment:
       Same here.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org