You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "nodece (via GitHub)" <gi...@apache.org> on 2024/03/08 03:26:27 UTC
[PR] [fix][broker] Fix incorrect unack msk count when dup ack a message (#20990) [pulsar]
nodece opened a new pull request, #22223:
URL: https://github.com/apache/pulsar/pull/22223
### Motivation
Cherry-pick #20990 to branch-2.10
### Modifications
<!-- Describe the modifications you've done. -->
### Verifying this change
- [ ] Make sure that the change passes the CI checks.
*(Please pick either of the following options)*
This change is a trivial rework / code cleanup without any test coverage.
*(or)*
This change is already covered by existing tests, such as *(please describe tests)*.
*(or)*
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end deployment with large payloads (10MB)*
- *Extended integration test for recovery after broker failure*
### Does this pull request potentially affect one of the following parts:
<!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
*If the box was checked, please highlight the changes*
- [ ] Dependencies (add or upgrade a dependency)
- [ ] The public API
- [ ] The schema
- [ ] The default values of configurations
- [ ] The threading model
- [ ] The binary protocol
- [ ] The REST endpoints
- [ ] The admin CLI options
- [ ] The metrics
- [ ] Anything that affects deployment
### Documentation
<!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
- [ ] `doc` <!-- Your PR contains doc changes. -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
- [x] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->
### Matching PR in forked repository
PR in forked repository: <!-- ENTER URL HERE -->
<!--
After opening this PR, the build in apache/pulsar will fail and instructions will
be provided for opening a PR in the PR author's forked repository.
apache/pulsar pull requests should be first tested in your own fork since the
apache/pulsar CI based on GitHub Actions has constrained resources and quota.
GitHub Actions provides separate quota for pull requests that are executed in
a forked repository.
The tests will be run in the forked repository until all PR review comments have
been handled, the tests pass and the PR is approved by a reviewer.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [fix][broker] Fix incorrect unack msk count when dup ack a message (#20990) [pulsar]
Posted by "nodece (via GitHub)" <gi...@apache.org>.
nodece commented on PR #22223:
URL: https://github.com/apache/pulsar/pull/22223#issuecomment-1985122323
/pulsarbot rerun-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [fix][broker] Fix incorrect unack msk count when dup ack a message (#20990) [pulsar]
Posted by "nodece (via GitHub)" <gi...@apache.org>.
nodece commented on PR #22223:
URL: https://github.com/apache/pulsar/pull/22223#issuecomment-1991301359
@lhotari Do you have any suggestions about `com.github.dockerjava.api.exception.DockerClientException: Could not pull image: failed to register layer: write /u01/app/oracle-product/12.2.0/SE/suptools/orachk/collections.dat: no space left on device`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [fix][broker] Fix incorrect unack msk count when dup ack a message (#20990) [pulsar]
Posted by "nodece (via GitHub)" <gi...@apache.org>.
nodece commented on PR #22223:
URL: https://github.com/apache/pulsar/pull/22223#issuecomment-1991671639
@lhotari Please see https://github.com/apache/pulsar/actions/runs/8198597389/job/22484858052?pr=22223#step:13:1352
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [fix][broker] Fix incorrect unack msk count when dup ack a message (#20990) [pulsar]
Posted by "Technoboy- (via GitHub)" <gi...@apache.org>.
Technoboy- merged PR #22223:
URL: https://github.com/apache/pulsar/pull/22223
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [fix][broker] Fix incorrect unack msk count when dup ack a message (#20990) [pulsar]
Posted by "nodece (via GitHub)" <gi...@apache.org>.
nodece commented on PR #22223:
URL: https://github.com/apache/pulsar/pull/22223#issuecomment-1985290808
This image works fine locally:
```
❯ docker pull quay.io/maksymbilenko/oracle-12c:master
master: Pulling from maksymbilenko/oracle-12c
8ba884070f61: Downloading [===========================> ] 40.77MB/75.4MB
ef9513b81046: Pulling fs layer
6f1de349e202: Download complete
5376ebfa0fa3: Waiting
5f632c3633d2: Waiting
3e74293031d2: Waiting
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [fix][broker] Fix incorrect unack msk count when dup ack a message (#20990) [pulsar]
Posted by "lhotari (via GitHub)" <gi...@apache.org>.
lhotari commented on PR #22223:
URL: https://github.com/apache/pulsar/pull/22223#issuecomment-1991449238
> @lhotari Do you have any suggestions about `com.github.dockerjava.api.exception.DockerClientException: Could not pull image: failed to register layer: write /u01/app/oracle-product/12.2.0/SE/suptools/orachk/collections.dat: no space left on device`?
@nodece where did that happen?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [fix][broker] Fix incorrect unack msk count when dup ack a message (#20990) [pulsar]
Posted by "nodece (via GitHub)" <gi...@apache.org>.
nodece commented on PR #22223:
URL: https://github.com/apache/pulsar/pull/22223#issuecomment-1985260230
CI failed:
```
Caused by: org.testcontainers.containers.ContainerFetchException: Failed to get Docker client for quay.io/maksymbilenko/oracle-12c:master
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org