You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2020/12/24 20:39:10 UTC
[GitHub] [maven-deploy-plugin] michael-o opened a new pull request #16: Revert "[MDEPLOY-231] - Move checksum generation from install to depl…
michael-o opened a new pull request #16:
URL: https://github.com/apache/maven-deploy-plugin/pull/16
…oy plugin"
This reverts commit 83b2d51cb3427a54ea465ff836c68da18accd426.
Following this checklist to help us incorporate your
contribution quickly and easily:
- [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MPH) filed
for the change (usually before you start working on it). Trivial changes like typos do not
require a JIRA issue. Your pull request should address just this issue, without
pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line and body.
- [ ] Format the pull request title like `[MPH-XXX] - Fixes bug in ApproximateQuantiles`,
where you replace `MPH-XXX` with the appropriate JIRA issue. Best practice
is to use the JIRA issue title in the pull request title and in the first line of the
commit message.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will
be performed on your pull request automatically.
- [ ] You have run the integration tests successfully (`mvn -Prun-its clean verify`).
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [ ] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-deploy-plugin] michael-o edited a comment on pull request #16: Revert "[MDEPLOY-231] - Move checksum generation from install to depl…
Posted by GitBox <gi...@apache.org>.
michael-o edited a comment on pull request #16:
URL: https://github.com/apache/maven-deploy-plugin/pull/16#issuecomment-751288717
The problem with this is that it is not portable. It does not know which checksums are generated. It is assumed, but nothing else. This especially depends on the Resolver version used...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-deploy-plugin] rfscholte commented on pull request #16: Revert "[MDEPLOY-231] - Move checksum generation from install to depl…
Posted by GitBox <gi...@apache.org>.
rfscholte commented on pull request #16:
URL: https://github.com/apache/maven-deploy-plugin/pull/16#issuecomment-751231372
I think the description is wrong, because MDEPLOY-231 is still valid to me. It looks like you're only restoring an IT, which is not the same.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-deploy-plugin] michael-o commented on pull request #16: Revert "[MDEPLOY-231] - Move checksum generation from install to depl…
Posted by GitBox <gi...@apache.org>.
michael-o commented on pull request #16:
URL: https://github.com/apache/maven-deploy-plugin/pull/16#issuecomment-751288717
The problem with this is that it is not portable. It does not know which checksums are generated. It is assumed, but nothing else.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-deploy-plugin] michael-o commented on pull request #16: Revert "[MDEPLOY-231] - Move checksum generation from install to depl…
Posted by GitBox <gi...@apache.org>.
michael-o commented on pull request #16:
URL: https://github.com/apache/maven-deploy-plugin/pull/16#issuecomment-751253385
Your understanding is that the commit title should read: "Revert IT of MDEPLOY-231"?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-deploy-plugin] michael-o commented on pull request #16: Revert "[MDEPLOY-231] - Move checksum generation from install to depl…
Posted by GitBox <gi...@apache.org>.
michael-o commented on pull request #16:
URL: https://github.com/apache/maven-deploy-plugin/pull/16#issuecomment-751289417
>
>
> But based on the Maven version we know the default generated checksum right?
Theoretically, yes. You could add this to the configuration somehow.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-deploy-plugin] michael-o commented on pull request #16: Revert "[MDEPLOY-231] - Move checksum generation from install to depl…
Posted by GitBox <gi...@apache.org>.
michael-o commented on pull request #16:
URL: https://github.com/apache/maven-deploy-plugin/pull/16#issuecomment-751247730
I am confused by your statement. I do not restore the IT, I am removing it. Please explain how you understand the issue is still valid.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-deploy-plugin] rfscholte commented on pull request #16: Revert "[MDEPLOY-231] - Move checksum generation from install to depl…
Posted by GitBox <gi...@apache.org>.
rfscholte commented on pull request #16:
URL: https://github.com/apache/maven-deploy-plugin/pull/16#issuecomment-751289327
But based on the Maven version we know the default generated checksum right?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-deploy-plugin] michael-o commented on pull request #16: Revert "[MDEPLOY-231] - Move checksum generation from install to depl…
Posted by GitBox <gi...@apache.org>.
michael-o commented on pull request #16:
URL: https://github.com/apache/maven-deploy-plugin/pull/16#issuecomment-751289154
See my comment: https://issues.apache.org/jira/browse/MDEPLOY-231?focusedCommentId=17253097&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17253097
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-deploy-plugin] rfscholte commented on pull request #16: Revert "[MDEPLOY-231] - Move checksum generation from install to depl…
Posted by GitBox <gi...@apache.org>.
rfscholte commented on pull request #16:
URL: https://github.com/apache/maven-deploy-plugin/pull/16#issuecomment-751288561
I was a bit confused, but it is not a complete revert, just partial.
However, I think it is valid to keep this IT. It in an _integration test_ that ensures the checksums are generated. If Artifact Resolver is being refactored or this plugin switches to a different implementation, it is good to verify the checksums will still be there.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org