You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/01/20 23:57:03 UTC
[GitHub] [superset] betodealmeida opened a new pull request #12635: feat: add decorator to guard public APIs
betodealmeida opened a new pull request #12635:
URL: https://github.com/apache/superset/pull/12635
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
This PR adds a decorator called `guard`, used to protect public APIs from breaking changes without a major version bump (see https://github.com/apache/superset/issues/12566). if the API is changed the user receives a warning.
For example, we allow people to specify a custom function called `SQL_QUERY_MUTATOR`. This is already broken, since the signature described in `superset/config.py` is out-of-sync with how it's actually called:
```python
# superset/config.py
# A function that intercepts the SQL to be executed and can alter it.
# The use case is can be around adding some sort of comment header
# with information such as the username and worker node information
#
# def SQL_QUERY_MUTATOR(sql, username, security_manager):
# dttm = datetime.now().isoformat()
# return f"-- [SQL LAB] {username} {dttm}\n{sql}"
SQL_QUERY_MUTATOR = None
```
If we look at where the function is called we can see that the signature should be slightly different:
```python
SQL_QUERY_MUTATOR = config["SQL_QUERY_MUTATOR"]
...
if SQL_QUERY_MUTATOR:
sql = SQL_QUERY_MUTATOR(sql, user_name, security_manager, database)
```
Notice the extra `database` argument, and the small difference between `username` and `user_name`. This was probably changed at some point without updating the config, breaking and any existing `SQL_QUERY_MUTATOR` that don't expect the `database` argument!
To prevent this in the future, we create a dummy function and protect it:
```python
@guard("W}V8JTUVzx4ur~{CEhT?")
def dummy_sql_query_mutator(
sql: str,
user_name: str,
security_manager: SupersetSecurityManager,
database: Database,
) -> str:
"""A no-op version of SQL_QUERY_MUTATOR"""
return sql
```
We change the code a little bit so that the function is always called (either the custom or the dummy one):
```python
SQL_QUERY_MUTATOR = config.get("SQL_QUERY_MUTATOR") or dummy_sql_query_mutator
...
sql = SQL_QUERY_MUTATOR(sql, user_name, security_manager, database)
```
Now what happens if we change the signature of the function? Let's try it:
```python
@guard("W}V8JTUVzx4ur~{CEhT?")
def dummy_sql_query_mutator(
sql: str,
user_name: str,
security_manager: SupersetSecurityManager,
database: Database,
foo: int,
) -> str:
"""A no-op version of SQL_QUERY_MUTATOR"""
return sql
```
Changing the code like this will print the following warning:
```
/Users/beto/Projects/incubator-superset/superset/utils/decorators.py:125: UserWarning: The decorated object
`dummy_sql_query_mutator` (in /Users/beto/Projects/incubator-superset/superset/sql_lab.py line 54) has a
public interface which has currently been modified. This MUST only be released in a new major version of
Superset according to SIP-57. To remove this warning message update the hash in the `guard` decorator to
';>K{8wd)&8!=9?1qR@Ja'.
@guard("W}V8JTUVzx4ur~{CEhT?")
def dummy_sql_query_mutator(
sql: str,
user_name: str,
security_manager: SupersetSecurityManager,
database: Database,
foo: int,
) -> str:
"""A no-op version of SQL_QUERY_MUTATOR"""
return sql
```
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
N/A
### TEST PLAN
<!--- What steps should be taken to verify the changes -->
Changed signature and run unit tests, it printed the warning message above.
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] ktmud commented on a change in pull request #12635: feat: add decorator to guard public APIs
Posted by GitBox <gi...@apache.org>.
ktmud commented on a change in pull request #12635:
URL: https://github.com/apache/superset/pull/12635#discussion_r562282841
##########
File path: tests/utils/public_interfaces_test.py
##########
@@ -0,0 +1,39 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+# pylint: disable=no-self-use
+from superset.sql_lab import dummy_sql_query_mutator
+from superset.utils.public_interfaces import compute_hash, get_warning_message
+from tests.base_tests import SupersetTestCase
+
+# These are public interfaces exposed by Superset. Make sure
+# to only change the interfaces and update the hashes in new
+# major versions of Superset.
+hashes = {
+ dummy_sql_query_mutator: "?1Y~;3l_|ss3^<`P;lWt",
+}
+
+
+class PublicInterfacesTest(SupersetTestCase):
+
+ """Test that public interfaces have not been accidentally changed."""
+
+ def test_dummy_sql_query_mutator(self):
Review comment:
For simplicity, maybe we can just do this without a map.
```python
assert compute_hash(dummy_sql_query_mutator) == "?1Y~;3l_|ss3^<`P;lWt"
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12635: feat: add decorator to guard public APIs
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12635:
URL: https://github.com/apache/superset/pull/12635#issuecomment-764087241
# [Codecov](https://codecov.io/gh/apache/superset/pull/12635?src=pr&el=h1) Report
> Merging [#12635](https://codecov.io/gh/apache/superset/pull/12635?src=pr&el=desc) (29bf532) into [master](https://codecov.io/gh/apache/superset/commit/e7def7e0e25caf09fbe33f8019db413686e349bc?el=desc) (e7def7e) will **decrease** coverage by `3.41%`.
> The diff coverage is `95.65%`.
[](https://codecov.io/gh/apache/superset/pull/12635?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12635 +/- ##
==========================================
- Coverage 66.80% 63.38% -3.42%
==========================================
Files 1017 487 -530
Lines 49730 30026 -19704
Branches 4864 0 -4864
==========================================
- Hits 33221 19032 -14189
+ Misses 16386 10994 -5392
+ Partials 123 0 -123
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.38% <95.65%> (-0.60%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12635?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/config.py](https://codecov.io/gh/apache/superset/pull/12635/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.61% <ø> (ø)` | |
| [superset/utils/decorators.py](https://codecov.io/gh/apache/superset/pull/12635/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGVjb3JhdG9ycy5weQ==) | `97.61% <90.90%> (-2.39%)` | :arrow_down: |
| [superset/utils/public\_interfaces.py](https://codecov.io/gh/apache/superset/pull/12635/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvcHVibGljX2ludGVyZmFjZXMucHk=) | `96.55% <96.55%> (ø)` | |
| [superset/sql\_lab.py](https://codecov.io/gh/apache/superset/pull/12635/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX2xhYi5weQ==) | `80.18% <100.00%> (+0.74%)` | :arrow_up: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/12635/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/superset/pull/12635/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/12635/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.61% <0.00%> (-29.24%)` | :arrow_down: |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/superset/pull/12635/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `83.67% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/databases/commands/update.py](https://codecov.io/gh/apache/superset/pull/12635/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `85.71% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/12635/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `84.31% <0.00%> (-6.28%)` | :arrow_down: |
| ... and [550 more](https://codecov.io/gh/apache/superset/pull/12635/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12635?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12635?src=pr&el=footer). Last update [e7def7e...0be108a](https://codecov.io/gh/apache/superset/pull/12635?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io commented on pull request #12635: feat: add decorator to guard public APIs
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #12635:
URL: https://github.com/apache/superset/pull/12635#issuecomment-764087241
# [Codecov](https://codecov.io/gh/apache/superset/pull/12635?src=pr&el=h1) Report
> Merging [#12635](https://codecov.io/gh/apache/superset/pull/12635?src=pr&el=desc) (d660d9c) into [master](https://codecov.io/gh/apache/superset/commit/e7def7e0e25caf09fbe33f8019db413686e349bc?el=desc) (e7def7e) will **decrease** coverage by `3.60%`.
> The diff coverage is `68.18%`.
[](https://codecov.io/gh/apache/superset/pull/12635?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12635 +/- ##
==========================================
- Coverage 66.80% 63.19% -3.61%
==========================================
Files 1017 486 -531
Lines 49730 30022 -19708
Branches 4864 0 -4864
==========================================
- Hits 33221 18972 -14249
+ Misses 16386 11050 -5336
+ Partials 123 0 -123
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.19% <68.18%> (-0.80%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12635?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/config.py](https://codecov.io/gh/apache/superset/pull/12635/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.61% <ø> (ø)` | |
| [superset/utils/decorators.py](https://codecov.io/gh/apache/superset/pull/12635/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGVjb3JhdG9ycy5weQ==) | `79.10% <61.11%> (-20.90%)` | :arrow_down: |
| [superset/sql\_lab.py](https://codecov.io/gh/apache/superset/pull/12635/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX2xhYi5weQ==) | `80.27% <100.00%> (+0.83%)` | :arrow_up: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/12635/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/superset/pull/12635/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/12635/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.61% <0.00%> (-29.24%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/superset/pull/12635/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/superset/pull/12635/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `83.67% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/databases/commands/update.py](https://codecov.io/gh/apache/superset/pull/12635/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `85.71% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/12635/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `84.31% <0.00%> (-6.28%)` | :arrow_down: |
| ... and [544 more](https://codecov.io/gh/apache/superset/pull/12635/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12635?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12635?src=pr&el=footer). Last update [e7def7e...5759363](https://codecov.io/gh/apache/superset/pull/12635?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12635: feat: add decorator to guard public APIs
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12635:
URL: https://github.com/apache/superset/pull/12635#issuecomment-764087241
# [Codecov](https://codecov.io/gh/apache/superset/pull/12635?src=pr&el=h1) Report
> Merging [#12635](https://codecov.io/gh/apache/superset/pull/12635?src=pr&el=desc) (b310ffc) into [master](https://codecov.io/gh/apache/superset/commit/e7def7e0e25caf09fbe33f8019db413686e349bc?el=desc) (e7def7e) will **decrease** coverage by `3.50%`.
> The diff coverage is `97.72%`.
[](https://codecov.io/gh/apache/superset/pull/12635?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12635 +/- ##
==========================================
- Coverage 66.80% 63.29% -3.51%
==========================================
Files 1017 486 -531
Lines 49730 30024 -19706
Branches 4864 0 -4864
==========================================
- Hits 33221 19005 -14216
+ Misses 16386 11019 -5367
+ Partials 123 0 -123
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.29% <97.72%> (-0.69%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12635?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/config.py](https://codecov.io/gh/apache/superset/pull/12635/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.61% <ø> (ø)` | |
| [superset/utils/decorators.py](https://codecov.io/gh/apache/superset/pull/12635/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGVjb3JhdG9ycy5weQ==) | `98.50% <97.22%> (-1.50%)` | :arrow_down: |
| [superset/sql\_lab.py](https://codecov.io/gh/apache/superset/pull/12635/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX2xhYi5weQ==) | `80.27% <100.00%> (+0.83%)` | :arrow_up: |
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/superset/pull/12635/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/views/database/views.py](https://codecov.io/gh/apache/superset/pull/12635/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2Uvdmlld3MucHk=) | `62.69% <0.00%> (-24.88%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/superset/pull/12635/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/superset/pull/12635/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `83.67% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/databases/commands/update.py](https://codecov.io/gh/apache/superset/pull/12635/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `85.71% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/12635/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `73.37% <0.00%> (-8.01%)` | :arrow_down: |
| [superset/sql\_validators/base.py](https://codecov.io/gh/apache/superset/pull/12635/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvYmFzZS5weQ==) | `93.33% <0.00%> (-6.67%)` | :arrow_down: |
| ... and [545 more](https://codecov.io/gh/apache/superset/pull/12635/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12635?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12635?src=pr&el=footer). Last update [e7def7e...5759363](https://codecov.io/gh/apache/superset/pull/12635?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] betodealmeida commented on pull request #12635: feat: add decorator to guard public APIs
Posted by GitBox <gi...@apache.org>.
betodealmeida commented on pull request #12635:
URL: https://github.com/apache/superset/pull/12635#issuecomment-765620687
> Should we clean up the decorator?
We should. I'm emotionally attached to it, but I'll remove it. :-P
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] ktmud commented on a change in pull request #12635: feat: add decorator to guard public APIs
Posted by GitBox <gi...@apache.org>.
ktmud commented on a change in pull request #12635:
URL: https://github.com/apache/superset/pull/12635#discussion_r562838642
##########
File path: tests/utils/public_interfaces_test.py
##########
@@ -0,0 +1,36 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+# pylint: disable=no-self-use
+import pytest
+
+from superset.sql_lab import dummy_sql_query_mutator
+from superset.utils.public_interfaces import compute_hash, get_warning_message
+from tests.base_tests import SupersetTestCase
+
+# These are public interfaces exposed by Superset. Make sure
+# to only change the interfaces and update the hashes in new
+# major versions of Superset.
+hashes = {
+ dummy_sql_query_mutator: "?1Y~;3l_|ss3^<`P;lWt",
+}
+
+
+@pytest.mark.parametrize("interface,expected_hash", list(hashes.items()))
+def test_public_interfaces(interface, expected_hash):
+ """Test that public interfaces have not been accidentally changed."""
+ current_hash = compute_hash(interface)
+ assert current_hash == expected_hash, get_warning_message(interface, current_hash)
Review comment:
Nice. Not that it matters much, but can pytest display which parameter failed the test in case of assertion errors?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] ktmud commented on a change in pull request #12635: feat: add decorator to guard public APIs
Posted by GitBox <gi...@apache.org>.
ktmud commented on a change in pull request #12635:
URL: https://github.com/apache/superset/pull/12635#discussion_r562282841
##########
File path: tests/utils/public_interfaces_test.py
##########
@@ -0,0 +1,39 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+# pylint: disable=no-self-use
+from superset.sql_lab import dummy_sql_query_mutator
+from superset.utils.public_interfaces import compute_hash, get_warning_message
+from tests.base_tests import SupersetTestCase
+
+# These are public interfaces exposed by Superset. Make sure
+# to only change the interfaces and update the hashes in new
+# major versions of Superset.
+hashes = {
+ dummy_sql_query_mutator: "?1Y~;3l_|ss3^<`P;lWt",
+}
+
+
+class PublicInterfacesTest(SupersetTestCase):
+
+ """Test that public interfaces have not been accidentally changed."""
+
+ def test_dummy_sql_query_mutator(self):
Review comment:
For simplicity, maybe we can just do this without a map.
```python
assert compute_hash(dummy_sql_query_mutator) == "?1Y~;3l_|ss3^<`P;lWt"
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] betodealmeida commented on pull request #12635: feat: add decorator to guard public APIs
Posted by GitBox <gi...@apache.org>.
betodealmeida commented on pull request #12635:
URL: https://github.com/apache/superset/pull/12635#issuecomment-764064463
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12635: feat: add decorator to guard public APIs
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12635:
URL: https://github.com/apache/superset/pull/12635#issuecomment-764087241
# [Codecov](https://codecov.io/gh/apache/superset/pull/12635?src=pr&el=h1) Report
> Merging [#12635](https://codecov.io/gh/apache/superset/pull/12635?src=pr&el=desc) (cdaf06b) into [master](https://codecov.io/gh/apache/superset/commit/e7def7e0e25caf09fbe33f8019db413686e349bc?el=desc) (e7def7e) will **decrease** coverage by `3.30%`.
> The diff coverage is `96.07%`.
[](https://codecov.io/gh/apache/superset/pull/12635?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12635 +/- ##
==========================================
- Coverage 66.80% 63.49% -3.31%
==========================================
Files 1017 487 -530
Lines 49730 30017 -19713
Branches 4864 0 -4864
==========================================
- Hits 33221 19059 -14162
+ Misses 16386 10958 -5428
+ Partials 123 0 -123
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.49% <96.07%> (-0.50%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12635?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/config.py](https://codecov.io/gh/apache/superset/pull/12635/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.61% <ø> (ø)` | |
| [superset/utils/decorators.py](https://codecov.io/gh/apache/superset/pull/12635/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGVjb3JhdG9ycy5weQ==) | `97.82% <93.33%> (-2.18%)` | :arrow_down: |
| [superset/utils/public\_interfaces.py](https://codecov.io/gh/apache/superset/pull/12635/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvcHVibGljX2ludGVyZmFjZXMucHk=) | `96.55% <96.55%> (ø)` | |
| [superset/sql\_lab.py](https://codecov.io/gh/apache/superset/pull/12635/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX2xhYi5weQ==) | `80.27% <100.00%> (+0.83%)` | :arrow_up: |
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/superset/pull/12635/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/views/database/views.py](https://codecov.io/gh/apache/superset/pull/12635/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2Uvdmlld3MucHk=) | `62.69% <0.00%> (-24.88%)` | :arrow_down: |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/superset/pull/12635/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `83.67% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/databases/commands/update.py](https://codecov.io/gh/apache/superset/pull/12635/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `85.71% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/sql\_validators/base.py](https://codecov.io/gh/apache/superset/pull/12635/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvYmFzZS5weQ==) | `93.33% <0.00%> (-6.67%)` | :arrow_down: |
| [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/superset/pull/12635/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `79.59% <0.00%> (-6.38%)` | :arrow_down: |
| ... and [556 more](https://codecov.io/gh/apache/superset/pull/12635/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12635?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12635?src=pr&el=footer). Last update [e7def7e...be5077d](https://codecov.io/gh/apache/superset/pull/12635?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] betodealmeida commented on a change in pull request #12635: feat: add decorator to guard public APIs
Posted by GitBox <gi...@apache.org>.
betodealmeida commented on a change in pull request #12635:
URL: https://github.com/apache/superset/pull/12635#discussion_r562802102
##########
File path: tests/utils/public_interfaces_test.py
##########
@@ -0,0 +1,39 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+# pylint: disable=no-self-use
+from superset.sql_lab import dummy_sql_query_mutator
+from superset.utils.public_interfaces import compute_hash, get_warning_message
+from tests.base_tests import SupersetTestCase
+
+# These are public interfaces exposed by Superset. Make sure
+# to only change the interfaces and update the hashes in new
+# major versions of Superset.
+hashes = {
+ dummy_sql_query_mutator: "?1Y~;3l_|ss3^<`P;lWt",
+}
+
+
+class PublicInterfacesTest(SupersetTestCase):
+
+ """Test that public interfaces have not been accidentally changed."""
+
+ def test_dummy_sql_query_mutator(self):
Review comment:
Ah, my bad... I actually wanted to parameterize this, let me fix it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] betodealmeida commented on a change in pull request #12635: feat: add decorator to guard public APIs
Posted by GitBox <gi...@apache.org>.
betodealmeida commented on a change in pull request #12635:
URL: https://github.com/apache/superset/pull/12635#discussion_r562843182
##########
File path: tests/utils/public_interfaces_test.py
##########
@@ -0,0 +1,36 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+# pylint: disable=no-self-use
+import pytest
+
+from superset.sql_lab import dummy_sql_query_mutator
+from superset.utils.public_interfaces import compute_hash, get_warning_message
+from tests.base_tests import SupersetTestCase
+
+# These are public interfaces exposed by Superset. Make sure
+# to only change the interfaces and update the hashes in new
+# major versions of Superset.
+hashes = {
+ dummy_sql_query_mutator: "?1Y~;3l_|ss3^<`P;lWt",
+}
+
+
+@pytest.mark.parametrize("interface,expected_hash", list(hashes.items()))
+def test_public_interfaces(interface, expected_hash):
+ """Test that public interfaces have not been accidentally changed."""
+ current_hash = compute_hash(interface)
+ assert current_hash == expected_hash, get_warning_message(interface, current_hash)
Review comment:
It does, it treats each parameter as a separate test called `unit_test_name[parameters]`: https://docs.pytest.org/en/stable/parametrize.html#pytest-mark-parametrize
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] ktmud commented on pull request #12635: feat: add decorator to guard public APIs
Posted by GitBox <gi...@apache.org>.
ktmud commented on pull request #12635:
URL: https://github.com/apache/superset/pull/12635#issuecomment-764061252
I know hashing is fast for most cases, but I'm wondering whether we can move this to be an offline job in some way?
I.e. instead of a decorator, store the hash for all public APIs in a separate file and run the checks in CI.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12635: feat: add decorator to guard public APIs
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12635:
URL: https://github.com/apache/superset/pull/12635#issuecomment-764087241
# [Codecov](https://codecov.io/gh/apache/superset/pull/12635?src=pr&el=h1) Report
> Merging [#12635](https://codecov.io/gh/apache/superset/pull/12635?src=pr&el=desc) (b310ffc) into [master](https://codecov.io/gh/apache/superset/commit/e7def7e0e25caf09fbe33f8019db413686e349bc?el=desc) (e7def7e) will **decrease** coverage by `3.49%`.
> The diff coverage is `97.72%`.
[](https://codecov.io/gh/apache/superset/pull/12635?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12635 +/- ##
==========================================
- Coverage 66.80% 63.30% -3.50%
==========================================
Files 1017 486 -531
Lines 49730 30009 -19721
Branches 4864 0 -4864
==========================================
- Hits 33221 18998 -14223
+ Misses 16386 11011 -5375
+ Partials 123 0 -123
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.30% <97.72%> (-0.68%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12635?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/config.py](https://codecov.io/gh/apache/superset/pull/12635/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.61% <ø> (ø)` | |
| [superset/utils/decorators.py](https://codecov.io/gh/apache/superset/pull/12635/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGVjb3JhdG9ycy5weQ==) | `98.50% <97.22%> (-1.50%)` | :arrow_down: |
| [superset/sql\_lab.py](https://codecov.io/gh/apache/superset/pull/12635/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX2xhYi5weQ==) | `80.27% <100.00%> (+0.83%)` | :arrow_up: |
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/superset/pull/12635/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/views/database/views.py](https://codecov.io/gh/apache/superset/pull/12635/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2Uvdmlld3MucHk=) | `62.69% <0.00%> (-24.88%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/superset/pull/12635/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/superset/pull/12635/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `83.67% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/databases/commands/update.py](https://codecov.io/gh/apache/superset/pull/12635/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `85.71% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/12635/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `73.37% <0.00%> (-8.01%)` | :arrow_down: |
| [superset/sql\_validators/base.py](https://codecov.io/gh/apache/superset/pull/12635/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvYmFzZS5weQ==) | `93.33% <0.00%> (-6.67%)` | :arrow_down: |
| ... and [552 more](https://codecov.io/gh/apache/superset/pull/12635/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12635?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12635?src=pr&el=footer). Last update [e7def7e...5759363](https://codecov.io/gh/apache/superset/pull/12635?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io commented on pull request #12635: feat: add decorator to guard public APIs
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #12635:
URL: https://github.com/apache/superset/pull/12635#issuecomment-764087241
# [Codecov](https://codecov.io/gh/apache/superset/pull/12635?src=pr&el=h1) Report
> Merging [#12635](https://codecov.io/gh/apache/superset/pull/12635?src=pr&el=desc) (d660d9c) into [master](https://codecov.io/gh/apache/superset/commit/e7def7e0e25caf09fbe33f8019db413686e349bc?el=desc) (e7def7e) will **decrease** coverage by `3.60%`.
> The diff coverage is `68.18%`.
[](https://codecov.io/gh/apache/superset/pull/12635?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12635 +/- ##
==========================================
- Coverage 66.80% 63.19% -3.61%
==========================================
Files 1017 486 -531
Lines 49730 30022 -19708
Branches 4864 0 -4864
==========================================
- Hits 33221 18972 -14249
+ Misses 16386 11050 -5336
+ Partials 123 0 -123
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.19% <68.18%> (-0.80%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12635?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/config.py](https://codecov.io/gh/apache/superset/pull/12635/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.61% <ø> (ø)` | |
| [superset/utils/decorators.py](https://codecov.io/gh/apache/superset/pull/12635/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGVjb3JhdG9ycy5weQ==) | `79.10% <61.11%> (-20.90%)` | :arrow_down: |
| [superset/sql\_lab.py](https://codecov.io/gh/apache/superset/pull/12635/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX2xhYi5weQ==) | `80.27% <100.00%> (+0.83%)` | :arrow_up: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/12635/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/superset/pull/12635/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/12635/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.61% <0.00%> (-29.24%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/superset/pull/12635/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/superset/pull/12635/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `83.67% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/databases/commands/update.py](https://codecov.io/gh/apache/superset/pull/12635/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `85.71% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/12635/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `84.31% <0.00%> (-6.28%)` | :arrow_down: |
| ... and [544 more](https://codecov.io/gh/apache/superset/pull/12635/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12635?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12635?src=pr&el=footer). Last update [e7def7e...5759363](https://codecov.io/gh/apache/superset/pull/12635?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12635: feat: add decorator to guard public APIs
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12635:
URL: https://github.com/apache/superset/pull/12635#issuecomment-764087241
# [Codecov](https://codecov.io/gh/apache/superset/pull/12635?src=pr&el=h1) Report
> Merging [#12635](https://codecov.io/gh/apache/superset/pull/12635?src=pr&el=desc) (47214aa) into [master](https://codecov.io/gh/apache/superset/commit/e7def7e0e25caf09fbe33f8019db413686e349bc?el=desc) (e7def7e) will **decrease** coverage by `4.39%`.
> The diff coverage is `95.65%`.
[](https://codecov.io/gh/apache/superset/pull/12635?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12635 +/- ##
==========================================
- Coverage 66.80% 62.40% -4.40%
==========================================
Files 1017 1019 +2
Lines 49730 49795 +65
Branches 4864 4874 +10
==========================================
- Hits 33221 31074 -2147
- Misses 16386 18523 +2137
- Partials 123 198 +75
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `60.93% <ø> (+0.13%)` | :arrow_up: |
| python | `63.37% <95.65%> (-0.62%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12635?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/config.py](https://codecov.io/gh/apache/superset/pull/12635/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.61% <ø> (ø)` | |
| [superset/utils/decorators.py](https://codecov.io/gh/apache/superset/pull/12635/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGVjb3JhdG9ycy5weQ==) | `97.61% <90.90%> (-2.39%)` | :arrow_down: |
| [superset/utils/public\_interfaces.py](https://codecov.io/gh/apache/superset/pull/12635/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvcHVibGljX2ludGVyZmFjZXMucHk=) | `96.55% <96.55%> (ø)` | |
| [superset/sql\_lab.py](https://codecov.io/gh/apache/superset/pull/12635/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX2xhYi5weQ==) | `80.18% <100.00%> (+0.74%)` | :arrow_up: |
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/superset/pull/12635/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/superset/pull/12635/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/superset/pull/12635/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/chart/ChartContainer.jsx](https://codecov.io/gh/apache/superset/pull/12635/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0Q29udGFpbmVyLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/reducers/index.js](https://codecov.io/gh/apache/superset/pull/12635/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvcmVkdWNlcnMvaW5kZXguanM=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...et-frontend/src/dashboard/containers/Dashboard.jsx](https://codecov.io/gh/apache/superset/pull/12635/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL0Rhc2hib2FyZC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [231 more](https://codecov.io/gh/apache/superset/pull/12635/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12635?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12635?src=pr&el=footer). Last update [e7def7e...47214aa](https://codecov.io/gh/apache/superset/pull/12635?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] betodealmeida edited a comment on pull request #12635: feat: add decorator to guard public APIs
Posted by GitBox <gi...@apache.org>.
betodealmeida edited a comment on pull request #12635:
URL: https://github.com/apache/superset/pull/12635#issuecomment-764064463
> I know hashing is fast for most cases, but I'm wondering whether we can move this to be an offline job in some way?
>
> I.e. instead of a decorator, store the hash for all public APIs in a separate file and run the checks in CI.
Good point... we could also just add unit tests that import the functions and compare their signature hashes to hard coded values, that might be a more efficient approach.
(Also, the hashes are computed just once when the files are "compiled", not when the functions are called.)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] betodealmeida merged pull request #12635: feat: add decorator to guard public APIs
Posted by GitBox <gi...@apache.org>.
betodealmeida merged pull request #12635:
URL: https://github.com/apache/superset/pull/12635
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12635: feat: add decorator to guard public APIs
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12635:
URL: https://github.com/apache/superset/pull/12635#issuecomment-764087241
# [Codecov](https://codecov.io/gh/apache/superset/pull/12635?src=pr&el=h1) Report
> Merging [#12635](https://codecov.io/gh/apache/superset/pull/12635?src=pr&el=desc) (0be108a) into [master](https://codecov.io/gh/apache/superset/commit/e7def7e0e25caf09fbe33f8019db413686e349bc?el=desc) (e7def7e) will **decrease** coverage by `3.31%`.
> The diff coverage is `95.65%`.
[](https://codecov.io/gh/apache/superset/pull/12635?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12635 +/- ##
==========================================
- Coverage 66.80% 63.48% -3.32%
==========================================
Files 1017 487 -530
Lines 49730 30013 -19717
Branches 4864 0 -4864
==========================================
- Hits 33221 19055 -14166
+ Misses 16386 10958 -5428
+ Partials 123 0 -123
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.48% <95.65%> (-0.50%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12635?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/config.py](https://codecov.io/gh/apache/superset/pull/12635/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.61% <ø> (ø)` | |
| [superset/utils/decorators.py](https://codecov.io/gh/apache/superset/pull/12635/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGVjb3JhdG9ycy5weQ==) | `97.61% <90.90%> (-2.39%)` | :arrow_down: |
| [superset/utils/public\_interfaces.py](https://codecov.io/gh/apache/superset/pull/12635/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvcHVibGljX2ludGVyZmFjZXMucHk=) | `96.55% <96.55%> (ø)` | |
| [superset/sql\_lab.py](https://codecov.io/gh/apache/superset/pull/12635/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX2xhYi5weQ==) | `80.18% <100.00%> (+0.74%)` | :arrow_up: |
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/superset/pull/12635/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/views/database/views.py](https://codecov.io/gh/apache/superset/pull/12635/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2Uvdmlld3MucHk=) | `62.69% <0.00%> (-24.88%)` | :arrow_down: |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/superset/pull/12635/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `83.67% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/databases/commands/update.py](https://codecov.io/gh/apache/superset/pull/12635/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `85.71% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/sql\_validators/base.py](https://codecov.io/gh/apache/superset/pull/12635/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvYmFzZS5weQ==) | `93.33% <0.00%> (-6.67%)` | :arrow_down: |
| [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/superset/pull/12635/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `79.59% <0.00%> (-6.38%)` | :arrow_down: |
| ... and [557 more](https://codecov.io/gh/apache/superset/pull/12635/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12635?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12635?src=pr&el=footer). Last update [e7def7e...d12e0ed](https://codecov.io/gh/apache/superset/pull/12635?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] betodealmeida commented on pull request #12635: feat: add decorator to guard public APIs
Posted by GitBox <gi...@apache.org>.
betodealmeida commented on pull request #12635:
URL: https://github.com/apache/superset/pull/12635#issuecomment-764064463
> I know hashing is fast for most cases, but I'm wondering whether we can move this to be an offline job in some way?
>
> I.e. instead of a decorator, store the hash for all public APIs in a separate file and run the checks in CI.
Good point... we could also just add unit tests that import the functions and compare their signature hashes to hard coded values, that might be a more efficient approach.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12635: feat: add decorator to guard public APIs
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12635:
URL: https://github.com/apache/superset/pull/12635#issuecomment-764087241
# [Codecov](https://codecov.io/gh/apache/superset/pull/12635?src=pr&el=h1) Report
> Merging [#12635](https://codecov.io/gh/apache/superset/pull/12635?src=pr&el=desc) (be5077d) into [master](https://codecov.io/gh/apache/superset/commit/e7def7e0e25caf09fbe33f8019db413686e349bc?el=desc) (e7def7e) will **decrease** coverage by `3.41%`.
> The diff coverage is `95.74%`.
[](https://codecov.io/gh/apache/superset/pull/12635?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12635 +/- ##
==========================================
- Coverage 66.80% 63.38% -3.42%
==========================================
Files 1017 487 -530
Lines 49730 30026 -19704
Branches 4864 0 -4864
==========================================
- Hits 33221 19032 -14189
+ Misses 16386 10994 -5392
+ Partials 123 0 -123
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.38% <95.74%> (-0.60%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12635?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/config.py](https://codecov.io/gh/apache/superset/pull/12635/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.61% <ø> (ø)` | |
| [superset/utils/decorators.py](https://codecov.io/gh/apache/superset/pull/12635/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGVjb3JhdG9ycy5weQ==) | `97.61% <90.90%> (-2.39%)` | :arrow_down: |
| [superset/utils/public\_interfaces.py](https://codecov.io/gh/apache/superset/pull/12635/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvcHVibGljX2ludGVyZmFjZXMucHk=) | `96.55% <96.55%> (ø)` | |
| [superset/sql\_lab.py](https://codecov.io/gh/apache/superset/pull/12635/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX2xhYi5weQ==) | `80.27% <100.00%> (+0.83%)` | :arrow_up: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/12635/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/superset/pull/12635/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/12635/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.61% <0.00%> (-29.24%)` | :arrow_down: |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/superset/pull/12635/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `83.67% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/databases/commands/update.py](https://codecov.io/gh/apache/superset/pull/12635/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `85.71% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/12635/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `84.31% <0.00%> (-6.28%)` | :arrow_down: |
| ... and [549 more](https://codecov.io/gh/apache/superset/pull/12635/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12635?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12635?src=pr&el=footer). Last update [e7def7e...be5077d](https://codecov.io/gh/apache/superset/pull/12635?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12635: feat: add decorator to guard public APIs
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12635:
URL: https://github.com/apache/superset/pull/12635#issuecomment-764087241
# [Codecov](https://codecov.io/gh/apache/superset/pull/12635?src=pr&el=h1) Report
> Merging [#12635](https://codecov.io/gh/apache/superset/pull/12635?src=pr&el=desc) (cdaf06b) into [master](https://codecov.io/gh/apache/superset/commit/e7def7e0e25caf09fbe33f8019db413686e349bc?el=desc) (e7def7e) will **decrease** coverage by `2.91%`.
> The diff coverage is `96.07%`.
[](https://codecov.io/gh/apache/superset/pull/12635?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12635 +/- ##
==========================================
- Coverage 66.80% 63.89% -2.92%
==========================================
Files 1017 487 -530
Lines 49730 30032 -19698
Branches 4864 0 -4864
==========================================
- Hits 33221 19188 -14033
+ Misses 16386 10844 -5542
+ Partials 123 0 -123
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.89% <96.07%> (-0.10%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12635?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/config.py](https://codecov.io/gh/apache/superset/pull/12635/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.61% <ø> (ø)` | |
| [superset/utils/decorators.py](https://codecov.io/gh/apache/superset/pull/12635/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGVjb3JhdG9ycy5weQ==) | `97.82% <93.33%> (-2.18%)` | :arrow_down: |
| [superset/utils/public\_interfaces.py](https://codecov.io/gh/apache/superset/pull/12635/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvcHVibGljX2ludGVyZmFjZXMucHk=) | `96.55% <96.55%> (ø)` | |
| [superset/sql\_lab.py](https://codecov.io/gh/apache/superset/pull/12635/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX2xhYi5weQ==) | `80.27% <100.00%> (+0.83%)` | :arrow_up: |
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/superset/pull/12635/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/superset/pull/12635/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `83.67% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/databases/commands/update.py](https://codecov.io/gh/apache/superset/pull/12635/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `85.71% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/databases/commands/test\_connection.py](https://codecov.io/gh/apache/superset/pull/12635/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3Rlc3RfY29ubmVjdGlvbi5weQ==) | `84.78% <0.00%> (-4.35%)` | :arrow_down: |
| [superset/utils/celery.py](https://codecov.io/gh/apache/superset/pull/12635/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2VsZXJ5LnB5) | `96.42% <0.00%> (-3.58%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/superset/pull/12635/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `85.86% <0.00%> (-2.99%)` | :arrow_down: |
| ... and [546 more](https://codecov.io/gh/apache/superset/pull/12635/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12635?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12635?src=pr&el=footer). Last update [e7def7e...47214aa](https://codecov.io/gh/apache/superset/pull/12635?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12635: feat: add decorator to guard public APIs
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12635:
URL: https://github.com/apache/superset/pull/12635#issuecomment-764087241
# [Codecov](https://codecov.io/gh/apache/superset/pull/12635?src=pr&el=h1) Report
> Merging [#12635](https://codecov.io/gh/apache/superset/pull/12635?src=pr&el=desc) (0be108a) into [master](https://codecov.io/gh/apache/superset/commit/e7def7e0e25caf09fbe33f8019db413686e349bc?el=desc) (e7def7e) will **decrease** coverage by `2.91%`.
> The diff coverage is `95.65%`.
[](https://codecov.io/gh/apache/superset/pull/12635?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12635 +/- ##
==========================================
- Coverage 66.80% 63.88% -2.92%
==========================================
Files 1017 487 -530
Lines 49730 30028 -19702
Branches 4864 0 -4864
==========================================
- Hits 33221 19184 -14037
+ Misses 16386 10844 -5542
+ Partials 123 0 -123
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.88% <95.65%> (-0.10%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12635?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/config.py](https://codecov.io/gh/apache/superset/pull/12635/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.61% <ø> (ø)` | |
| [superset/utils/decorators.py](https://codecov.io/gh/apache/superset/pull/12635/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGVjb3JhdG9ycy5weQ==) | `97.61% <90.90%> (-2.39%)` | :arrow_down: |
| [superset/utils/public\_interfaces.py](https://codecov.io/gh/apache/superset/pull/12635/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvcHVibGljX2ludGVyZmFjZXMucHk=) | `96.55% <96.55%> (ø)` | |
| [superset/sql\_lab.py](https://codecov.io/gh/apache/superset/pull/12635/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX2xhYi5weQ==) | `80.18% <100.00%> (+0.74%)` | :arrow_up: |
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/superset/pull/12635/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/superset/pull/12635/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `83.67% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/databases/commands/update.py](https://codecov.io/gh/apache/superset/pull/12635/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `85.71% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/databases/commands/test\_connection.py](https://codecov.io/gh/apache/superset/pull/12635/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3Rlc3RfY29ubmVjdGlvbi5weQ==) | `84.78% <0.00%> (-4.35%)` | :arrow_down: |
| [superset/utils/celery.py](https://codecov.io/gh/apache/superset/pull/12635/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2VsZXJ5LnB5) | `96.42% <0.00%> (-3.58%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/superset/pull/12635/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `85.86% <0.00%> (-2.99%)` | :arrow_down: |
| ... and [547 more](https://codecov.io/gh/apache/superset/pull/12635/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12635?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12635?src=pr&el=footer). Last update [e7def7e...beef427](https://codecov.io/gh/apache/superset/pull/12635?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12635: feat: add decorator to guard public APIs
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12635:
URL: https://github.com/apache/superset/pull/12635#issuecomment-764087241
# [Codecov](https://codecov.io/gh/apache/superset/pull/12635?src=pr&el=h1) Report
> Merging [#12635](https://codecov.io/gh/apache/superset/pull/12635?src=pr&el=desc) (beef427) into [master](https://codecov.io/gh/apache/superset/commit/e7def7e0e25caf09fbe33f8019db413686e349bc?el=desc) (e7def7e) will **decrease** coverage by `3.44%`.
> The diff coverage is `82.35%`.
[](https://codecov.io/gh/apache/superset/pull/12635?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12635 +/- ##
==========================================
- Coverage 66.80% 63.35% -3.45%
==========================================
Files 1017 487 -530
Lines 49730 30014 -19716
Branches 4864 0 -4864
==========================================
- Hits 33221 19016 -14205
+ Misses 16386 10998 -5388
+ Partials 123 0 -123
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.35% <82.35%> (-0.63%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12635?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/config.py](https://codecov.io/gh/apache/superset/pull/12635/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.61% <ø> (ø)` | |
| [superset/utils/public\_interfaces.py](https://codecov.io/gh/apache/superset/pull/12635/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvcHVibGljX2ludGVyZmFjZXMucHk=) | `78.57% <78.57%> (ø)` | |
| [superset/sql\_lab.py](https://codecov.io/gh/apache/superset/pull/12635/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX2xhYi5weQ==) | `80.18% <100.00%> (+0.74%)` | :arrow_up: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/12635/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/superset/pull/12635/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/12635/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.61% <0.00%> (-29.24%)` | :arrow_down: |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/superset/pull/12635/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `83.67% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/databases/commands/update.py](https://codecov.io/gh/apache/superset/pull/12635/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `85.71% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/12635/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `84.31% <0.00%> (-6.28%)` | :arrow_down: |
| [superset/databases/commands/test\_connection.py](https://codecov.io/gh/apache/superset/pull/12635/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3Rlc3RfY29ubmVjdGlvbi5weQ==) | `84.78% <0.00%> (-4.35%)` | :arrow_down: |
| ... and [549 more](https://codecov.io/gh/apache/superset/pull/12635/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12635?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12635?src=pr&el=footer). Last update [e7def7e...beef427](https://codecov.io/gh/apache/superset/pull/12635?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12635: feat: add decorator to guard public APIs
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12635:
URL: https://github.com/apache/superset/pull/12635#issuecomment-764087241
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12635: feat: add decorator to guard public APIs
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12635:
URL: https://github.com/apache/superset/pull/12635#issuecomment-764087241
# [Codecov](https://codecov.io/gh/apache/superset/pull/12635?src=pr&el=h1) Report
> Merging [#12635](https://codecov.io/gh/apache/superset/pull/12635?src=pr&el=desc) (b310ffc) into [master](https://codecov.io/gh/apache/superset/commit/e7def7e0e25caf09fbe33f8019db413686e349bc?el=desc) (e7def7e) will **decrease** coverage by `7.95%`.
> The diff coverage is `97.72%`.
[](https://codecov.io/gh/apache/superset/pull/12635?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12635 +/- ##
==========================================
- Coverage 66.80% 58.85% -7.96%
==========================================
Files 1017 960 -57
Lines 49730 46994 -2736
Branches 4864 4375 -489
==========================================
- Hits 33221 27657 -5564
- Misses 16386 19337 +2951
+ Partials 123 0 -123
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `50.98% <ø> (+<0.01%)` | :arrow_up: |
| javascript | `?` | |
| python | `63.29% <97.72%> (-0.69%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12635?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/config.py](https://codecov.io/gh/apache/superset/pull/12635/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.61% <ø> (ø)` | |
| [superset/utils/decorators.py](https://codecov.io/gh/apache/superset/pull/12635/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGVjb3JhdG9ycy5weQ==) | `98.50% <97.22%> (-1.50%)` | :arrow_down: |
| [superset/sql\_lab.py](https://codecov.io/gh/apache/superset/pull/12635/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX2xhYi5weQ==) | `80.27% <100.00%> (+0.83%)` | :arrow_up: |
| [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/superset/pull/12635/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...rset-frontend/src/dashboard/util/getEmptyLayout.js](https://codecov.io/gh/apache/superset/pull/12635/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEVtcHR5TGF5b3V0Lmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...dashboard/components/resizable/ResizableHandle.jsx](https://codecov.io/gh/apache/superset/pull/12635/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL3Jlc2l6YWJsZS9SZXNpemFibGVIYW5kbGUuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [.../src/dashboard/util/getFilterScopeFromNodesTree.js](https://codecov.io/gh/apache/superset/pull/12635/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEZpbHRlclNjb3BlRnJvbU5vZGVzVHJlZS5qcw==) | `0.00% <0.00%> (-93.48%)` | :arrow_down: |
| [...set-frontend/src/views/CRUD/alert/ExecutionLog.tsx](https://codecov.io/gh/apache/superset/pull/12635/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvYWxlcnQvRXhlY3V0aW9uTG9nLnRzeA==) | `11.76% <0.00%> (-88.24%)` | :arrow_down: |
| [...src/dashboard/components/gridComponents/Header.jsx](https://codecov.io/gh/apache/superset/pull/12635/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0hlYWRlci5qc3g=) | `10.52% <0.00%> (-86.85%)` | :arrow_down: |
| [superset-frontend/src/components/IconTooltip.tsx](https://codecov.io/gh/apache/superset/pull/12635/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSWNvblRvb2x0aXAudHN4) | `13.33% <0.00%> (-86.67%)` | :arrow_down: |
| ... and [407 more](https://codecov.io/gh/apache/superset/pull/12635/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12635?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12635?src=pr&el=footer). Last update [e7def7e...5759363](https://codecov.io/gh/apache/superset/pull/12635?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] ktmud commented on pull request #12635: feat: add decorator to guard public APIs
Posted by GitBox <gi...@apache.org>.
ktmud commented on pull request #12635:
URL: https://github.com/apache/superset/pull/12635#issuecomment-764061252
I know hashing is fast for most cases, but I'm wondering whether we can move this to be an offline job in some way?
I.e. instead of a decorator, store the hash for all public APIs in a separate file and run the checks in CI.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12635: feat: add decorator to guard public APIs
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12635:
URL: https://github.com/apache/superset/pull/12635#issuecomment-764087241
# [Codecov](https://codecov.io/gh/apache/superset/pull/12635?src=pr&el=h1) Report
> Merging [#12635](https://codecov.io/gh/apache/superset/pull/12635?src=pr&el=desc) (5759363) into [master](https://codecov.io/gh/apache/superset/commit/e7def7e0e25caf09fbe33f8019db413686e349bc?el=desc) (e7def7e) will **decrease** coverage by `3.07%`.
> The diff coverage is `97.72%`.
[](https://codecov.io/gh/apache/superset/pull/12635?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12635 +/- ##
==========================================
- Coverage 66.80% 63.73% -3.08%
==========================================
Files 1017 486 -531
Lines 49730 30024 -19706
Branches 4864 0 -4864
==========================================
- Hits 33221 19135 -14086
+ Misses 16386 10889 -5497
+ Partials 123 0 -123
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.73% <97.72%> (-0.26%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12635?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/config.py](https://codecov.io/gh/apache/superset/pull/12635/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.61% <ø> (ø)` | |
| [superset/utils/decorators.py](https://codecov.io/gh/apache/superset/pull/12635/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGVjb3JhdG9ycy5weQ==) | `98.50% <97.22%> (-1.50%)` | :arrow_down: |
| [superset/sql\_lab.py](https://codecov.io/gh/apache/superset/pull/12635/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX2xhYi5weQ==) | `80.27% <100.00%> (+0.83%)` | :arrow_up: |
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/superset/pull/12635/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/superset/pull/12635/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/superset/pull/12635/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `83.67% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/databases/commands/update.py](https://codecov.io/gh/apache/superset/pull/12635/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `85.71% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/databases/commands/test\_connection.py](https://codecov.io/gh/apache/superset/pull/12635/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3Rlc3RfY29ubmVjdGlvbi5weQ==) | `84.78% <0.00%> (-4.35%)` | :arrow_down: |
| [superset/utils/celery.py](https://codecov.io/gh/apache/superset/pull/12635/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2VsZXJ5LnB5) | `96.42% <0.00%> (-3.58%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/superset/pull/12635/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `85.86% <0.00%> (-2.99%)` | :arrow_down: |
| ... and [541 more](https://codecov.io/gh/apache/superset/pull/12635/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12635?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12635?src=pr&el=footer). Last update [e7def7e...5759363](https://codecov.io/gh/apache/superset/pull/12635?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] betodealmeida commented on pull request #12635: feat: add decorator to guard public APIs
Posted by GitBox <gi...@apache.org>.
betodealmeida commented on pull request #12635:
URL: https://github.com/apache/superset/pull/12635#issuecomment-764145247
I reviewed `superset/config.py` today with @eschutho, and it looks like we need to guard a good number of objects:
- STATS_LOGGER
- EVENT_LOGGER
- CUSTOM_SECURITY_MANAGER
- SQLALCHEMY_CUSTOM_PASSWORD_STORE
- GET_FEATURE_FLAGS_FUNC
- LOGGING_CONFIGURATOR
- SQLLAB_CTAS_SCHEMA_NAME_FUNC
- CSV_TO_HIVE_UPLOAD_DIRECTORY_FUNC
- ALLOWED_USER_CSV_SCHEMA_FUNC
- FLASK_APP_MUTATOR
- TRACKING_URL_TRANSFORMER
- DB_CONNECTION_MUTATOR
- SQL_QUERY_MUTATOR
- WEBDRIVER_AUTH_FUNC
- SQLA_TABLE_MUTATOR
- QUERY_COST_FORMATTERS_BY_ENGINE
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12635: feat: add decorator to guard public APIs
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12635:
URL: https://github.com/apache/superset/pull/12635#issuecomment-764087241
# [Codecov](https://codecov.io/gh/apache/superset/pull/12635?src=pr&el=h1) Report
> Merging [#12635](https://codecov.io/gh/apache/superset/pull/12635?src=pr&el=desc) (47214aa) into [master](https://codecov.io/gh/apache/superset/commit/e7def7e0e25caf09fbe33f8019db413686e349bc?el=desc) (e7def7e) will **decrease** coverage by `3.43%`.
> The diff coverage is `95.65%`.
[](https://codecov.io/gh/apache/superset/pull/12635?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12635 +/- ##
==========================================
- Coverage 66.80% 63.37% -3.44%
==========================================
Files 1017 487 -530
Lines 49730 30012 -19718
Branches 4864 0 -4864
==========================================
- Hits 33221 19019 -14202
+ Misses 16386 10993 -5393
+ Partials 123 0 -123
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.37% <95.65%> (-0.62%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12635?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/config.py](https://codecov.io/gh/apache/superset/pull/12635/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.61% <ø> (ø)` | |
| [superset/utils/decorators.py](https://codecov.io/gh/apache/superset/pull/12635/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGVjb3JhdG9ycy5weQ==) | `97.61% <90.90%> (-2.39%)` | :arrow_down: |
| [superset/utils/public\_interfaces.py](https://codecov.io/gh/apache/superset/pull/12635/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvcHVibGljX2ludGVyZmFjZXMucHk=) | `96.55% <96.55%> (ø)` | |
| [superset/sql\_lab.py](https://codecov.io/gh/apache/superset/pull/12635/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX2xhYi5weQ==) | `80.18% <100.00%> (+0.74%)` | :arrow_up: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/12635/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/superset/pull/12635/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `32.65% <0.00%> (-59.19%)` | :arrow_down: |
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/superset/pull/12635/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/12635/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.61% <0.00%> (-29.24%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/12635/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `59.64% <0.00%> (-22.81%)` | :arrow_down: |
| [superset/databases/commands/update.py](https://codecov.io/gh/apache/superset/pull/12635/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `85.71% <0.00%> (-8.17%)` | :arrow_down: |
| ... and [559 more](https://codecov.io/gh/apache/superset/pull/12635/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12635?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12635?src=pr&el=footer). Last update [e7def7e...47214aa](https://codecov.io/gh/apache/superset/pull/12635?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12635: feat: add decorator to guard public APIs
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12635:
URL: https://github.com/apache/superset/pull/12635#issuecomment-764087241
# [Codecov](https://codecov.io/gh/apache/superset/pull/12635?src=pr&el=h1) Report
> Merging [#12635](https://codecov.io/gh/apache/superset/pull/12635?src=pr&el=desc) (b310ffc) into [master](https://codecov.io/gh/apache/superset/commit/e7def7e0e25caf09fbe33f8019db413686e349bc?el=desc) (e7def7e) will **decrease** coverage by `7.66%`.
> The diff coverage is `97.72%`.
[](https://codecov.io/gh/apache/superset/pull/12635?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12635 +/- ##
==========================================
- Coverage 66.80% 59.13% -7.67%
==========================================
Files 1017 960 -57
Lines 49730 46994 -2736
Branches 4864 4375 -489
==========================================
- Hits 33221 27790 -5431
- Misses 16386 19204 +2818
+ Partials 123 0 -123
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `50.98% <ø> (+<0.01%)` | :arrow_up: |
| javascript | `?` | |
| python | `63.74% <97.72%> (-0.25%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12635?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/config.py](https://codecov.io/gh/apache/superset/pull/12635/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.61% <ø> (ø)` | |
| [superset/utils/decorators.py](https://codecov.io/gh/apache/superset/pull/12635/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGVjb3JhdG9ycy5weQ==) | `98.50% <97.22%> (-1.50%)` | :arrow_down: |
| [superset/sql\_lab.py](https://codecov.io/gh/apache/superset/pull/12635/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX2xhYi5weQ==) | `80.27% <100.00%> (+0.83%)` | :arrow_up: |
| [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/superset/pull/12635/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...rset-frontend/src/dashboard/util/getEmptyLayout.js](https://codecov.io/gh/apache/superset/pull/12635/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEVtcHR5TGF5b3V0Lmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...dashboard/components/resizable/ResizableHandle.jsx](https://codecov.io/gh/apache/superset/pull/12635/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL3Jlc2l6YWJsZS9SZXNpemFibGVIYW5kbGUuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [.../src/dashboard/util/getFilterScopeFromNodesTree.js](https://codecov.io/gh/apache/superset/pull/12635/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEZpbHRlclNjb3BlRnJvbU5vZGVzVHJlZS5qcw==) | `0.00% <0.00%> (-93.48%)` | :arrow_down: |
| [...set-frontend/src/views/CRUD/alert/ExecutionLog.tsx](https://codecov.io/gh/apache/superset/pull/12635/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvYWxlcnQvRXhlY3V0aW9uTG9nLnRzeA==) | `11.76% <0.00%> (-88.24%)` | :arrow_down: |
| [...src/dashboard/components/gridComponents/Header.jsx](https://codecov.io/gh/apache/superset/pull/12635/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0hlYWRlci5qc3g=) | `10.52% <0.00%> (-86.85%)` | :arrow_down: |
| [superset-frontend/src/components/IconTooltip.tsx](https://codecov.io/gh/apache/superset/pull/12635/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSWNvblRvb2x0aXAudHN4) | `13.33% <0.00%> (-86.67%)` | :arrow_down: |
| ... and [404 more](https://codecov.io/gh/apache/superset/pull/12635/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12635?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12635?src=pr&el=footer). Last update [e7def7e...5759363](https://codecov.io/gh/apache/superset/pull/12635?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12635: feat: add decorator to guard public APIs
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12635:
URL: https://github.com/apache/superset/pull/12635#issuecomment-764087241
# [Codecov](https://codecov.io/gh/apache/superset/pull/12635?src=pr&el=h1) Report
> Merging [#12635](https://codecov.io/gh/apache/superset/pull/12635?src=pr&el=desc) (5759363) into [master](https://codecov.io/gh/apache/superset/commit/e7def7e0e25caf09fbe33f8019db413686e349bc?el=desc) (e7def7e) will **decrease** coverage by `3.50%`.
> The diff coverage is `97.72%`.
[](https://codecov.io/gh/apache/superset/pull/12635?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12635 +/- ##
==========================================
- Coverage 66.80% 63.29% -3.51%
==========================================
Files 1017 486 -531
Lines 49730 30024 -19706
Branches 4864 0 -4864
==========================================
- Hits 33221 19005 -14216
+ Misses 16386 11019 -5367
+ Partials 123 0 -123
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.29% <97.72%> (-0.69%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12635?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/config.py](https://codecov.io/gh/apache/superset/pull/12635/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.61% <ø> (ø)` | |
| [superset/utils/decorators.py](https://codecov.io/gh/apache/superset/pull/12635/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGVjb3JhdG9ycy5weQ==) | `98.50% <97.22%> (-1.50%)` | :arrow_down: |
| [superset/sql\_lab.py](https://codecov.io/gh/apache/superset/pull/12635/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX2xhYi5weQ==) | `80.27% <100.00%> (+0.83%)` | :arrow_up: |
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/superset/pull/12635/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/views/database/views.py](https://codecov.io/gh/apache/superset/pull/12635/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2Uvdmlld3MucHk=) | `62.69% <0.00%> (-24.88%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/superset/pull/12635/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/superset/pull/12635/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `83.67% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/databases/commands/update.py](https://codecov.io/gh/apache/superset/pull/12635/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `85.71% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/12635/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `73.37% <0.00%> (-8.01%)` | :arrow_down: |
| [superset/sql\_validators/base.py](https://codecov.io/gh/apache/superset/pull/12635/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvYmFzZS5weQ==) | `93.33% <0.00%> (-6.67%)` | :arrow_down: |
| ... and [545 more](https://codecov.io/gh/apache/superset/pull/12635/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12635?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12635?src=pr&el=footer). Last update [e7def7e...5759363](https://codecov.io/gh/apache/superset/pull/12635?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] betodealmeida commented on a change in pull request #12635: feat: add decorator to guard public APIs
Posted by GitBox <gi...@apache.org>.
betodealmeida commented on a change in pull request #12635:
URL: https://github.com/apache/superset/pull/12635#discussion_r562837665
##########
File path: tests/utils/public_interfaces_test.py
##########
@@ -0,0 +1,36 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+# pylint: disable=no-self-use
+import pytest
+
+from superset.sql_lab import dummy_sql_query_mutator
+from superset.utils.public_interfaces import compute_hash, get_warning_message
+from tests.base_tests import SupersetTestCase
+
+# These are public interfaces exposed by Superset. Make sure
+# to only change the interfaces and update the hashes in new
+# major versions of Superset.
+hashes = {
+ dummy_sql_query_mutator: "?1Y~;3l_|ss3^<`P;lWt",
+}
+
+
+@pytest.mark.parametrize("interface,expected_hash", list(hashes.items()))
+def test_public_interfaces(interface, expected_hash):
+ """Test that public interfaces have not been accidentally changed."""
+ current_hash = compute_hash(interface)
+ assert current_hash == expected_hash, get_warning_message(interface, current_hash)
Review comment:
@ktmud this is what I had in mind; now we can just update `hashes` and each one will get its own unit test.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12635: feat: add decorator to guard public APIs
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12635:
URL: https://github.com/apache/superset/pull/12635#issuecomment-764087241
# [Codecov](https://codecov.io/gh/apache/superset/pull/12635?src=pr&el=h1) Report
> Merging [#12635](https://codecov.io/gh/apache/superset/pull/12635?src=pr&el=desc) (d660d9c) into [master](https://codecov.io/gh/apache/superset/commit/e7def7e0e25caf09fbe33f8019db413686e349bc?el=desc) (e7def7e) will **decrease** coverage by `3.60%`.
> The diff coverage is `68.18%`.
[](https://codecov.io/gh/apache/superset/pull/12635?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12635 +/- ##
==========================================
- Coverage 66.80% 63.19% -3.61%
==========================================
Files 1017 486 -531
Lines 49730 30022 -19708
Branches 4864 0 -4864
==========================================
- Hits 33221 18972 -14249
+ Misses 16386 11050 -5336
+ Partials 123 0 -123
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.19% <68.18%> (-0.80%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12635?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/config.py](https://codecov.io/gh/apache/superset/pull/12635/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.61% <ø> (ø)` | |
| [superset/utils/decorators.py](https://codecov.io/gh/apache/superset/pull/12635/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGVjb3JhdG9ycy5weQ==) | `79.10% <61.11%> (-20.90%)` | :arrow_down: |
| [superset/sql\_lab.py](https://codecov.io/gh/apache/superset/pull/12635/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX2xhYi5weQ==) | `80.27% <100.00%> (+0.83%)` | :arrow_up: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/12635/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/superset/pull/12635/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/12635/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.61% <0.00%> (-29.24%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/superset/pull/12635/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/superset/pull/12635/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `83.67% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/databases/commands/update.py](https://codecov.io/gh/apache/superset/pull/12635/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `85.71% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/12635/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `84.31% <0.00%> (-6.28%)` | :arrow_down: |
| ... and [544 more](https://codecov.io/gh/apache/superset/pull/12635/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12635?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12635?src=pr&el=footer). Last update [e7def7e...5759363](https://codecov.io/gh/apache/superset/pull/12635?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12635: feat: add decorator to guard public APIs
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12635:
URL: https://github.com/apache/superset/pull/12635#issuecomment-764087241
# [Codecov](https://codecov.io/gh/apache/superset/pull/12635?src=pr&el=h1) Report
> Merging [#12635](https://codecov.io/gh/apache/superset/pull/12635?src=pr&el=desc) (b310ffc) into [master](https://codecov.io/gh/apache/superset/commit/e7def7e0e25caf09fbe33f8019db413686e349bc?el=desc) (e7def7e) will **decrease** coverage by `8.08%`.
> The diff coverage is `97.72%`.
[](https://codecov.io/gh/apache/superset/pull/12635?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12635 +/- ##
==========================================
- Coverage 66.80% 58.71% -8.09%
==========================================
Files 1017 960 -57
Lines 49730 46994 -2736
Branches 4864 4375 -489
==========================================
- Hits 33221 27593 -5628
- Misses 16386 19401 +3015
+ Partials 123 0 -123
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `50.60% <ø> (-0.38%)` | :arrow_down: |
| javascript | `?` | |
| python | `63.29% <97.72%> (-0.69%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12635?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/config.py](https://codecov.io/gh/apache/superset/pull/12635/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.61% <ø> (ø)` | |
| [superset/utils/decorators.py](https://codecov.io/gh/apache/superset/pull/12635/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGVjb3JhdG9ycy5weQ==) | `98.50% <97.22%> (-1.50%)` | :arrow_down: |
| [superset/sql\_lab.py](https://codecov.io/gh/apache/superset/pull/12635/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX2xhYi5weQ==) | `80.27% <100.00%> (+0.83%)` | :arrow_up: |
| [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/superset/pull/12635/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...rset-frontend/src/dashboard/util/getEmptyLayout.js](https://codecov.io/gh/apache/superset/pull/12635/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEVtcHR5TGF5b3V0Lmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...dashboard/components/resizable/ResizableHandle.jsx](https://codecov.io/gh/apache/superset/pull/12635/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL3Jlc2l6YWJsZS9SZXNpemFibGVIYW5kbGUuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [.../src/dashboard/util/getFilterScopeFromNodesTree.js](https://codecov.io/gh/apache/superset/pull/12635/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEZpbHRlclNjb3BlRnJvbU5vZGVzVHJlZS5qcw==) | `0.00% <0.00%> (-93.48%)` | :arrow_down: |
| [...set-frontend/src/views/CRUD/alert/ExecutionLog.tsx](https://codecov.io/gh/apache/superset/pull/12635/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvYWxlcnQvRXhlY3V0aW9uTG9nLnRzeA==) | `11.76% <0.00%> (-88.24%)` | :arrow_down: |
| [...src/dashboard/components/gridComponents/Header.jsx](https://codecov.io/gh/apache/superset/pull/12635/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0hlYWRlci5qc3g=) | `10.52% <0.00%> (-86.85%)` | :arrow_down: |
| [superset-frontend/src/components/IconTooltip.tsx](https://codecov.io/gh/apache/superset/pull/12635/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSWNvblRvb2x0aXAudHN4) | `13.33% <0.00%> (-86.67%)` | :arrow_down: |
| ... and [407 more](https://codecov.io/gh/apache/superset/pull/12635/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12635?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12635?src=pr&el=footer). Last update [e7def7e...5759363](https://codecov.io/gh/apache/superset/pull/12635?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12635: feat: add decorator to guard public APIs
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12635:
URL: https://github.com/apache/superset/pull/12635#issuecomment-764087241
# [Codecov](https://codecov.io/gh/apache/superset/pull/12635?src=pr&el=h1) Report
> Merging [#12635](https://codecov.io/gh/apache/superset/pull/12635?src=pr&el=desc) (5759363) into [master](https://codecov.io/gh/apache/superset/commit/e7def7e0e25caf09fbe33f8019db413686e349bc?el=desc) (e7def7e) will **decrease** coverage by `3.50%`.
> The diff coverage is `97.72%`.
[](https://codecov.io/gh/apache/superset/pull/12635?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12635 +/- ##
==========================================
- Coverage 66.80% 63.29% -3.51%
==========================================
Files 1017 486 -531
Lines 49730 30024 -19706
Branches 4864 0 -4864
==========================================
- Hits 33221 19005 -14216
+ Misses 16386 11019 -5367
+ Partials 123 0 -123
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.29% <97.72%> (-0.69%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12635?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/config.py](https://codecov.io/gh/apache/superset/pull/12635/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.61% <ø> (ø)` | |
| [superset/utils/decorators.py](https://codecov.io/gh/apache/superset/pull/12635/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGVjb3JhdG9ycy5weQ==) | `98.50% <97.22%> (-1.50%)` | :arrow_down: |
| [superset/sql\_lab.py](https://codecov.io/gh/apache/superset/pull/12635/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX2xhYi5weQ==) | `80.27% <100.00%> (+0.83%)` | :arrow_up: |
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/superset/pull/12635/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/views/database/views.py](https://codecov.io/gh/apache/superset/pull/12635/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2Uvdmlld3MucHk=) | `62.69% <0.00%> (-24.88%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/superset/pull/12635/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/superset/pull/12635/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `83.67% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/databases/commands/update.py](https://codecov.io/gh/apache/superset/pull/12635/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `85.71% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/12635/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `73.37% <0.00%> (-8.01%)` | :arrow_down: |
| [superset/sql\_validators/base.py](https://codecov.io/gh/apache/superset/pull/12635/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvYmFzZS5weQ==) | `93.33% <0.00%> (-6.67%)` | :arrow_down: |
| ... and [545 more](https://codecov.io/gh/apache/superset/pull/12635/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12635?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12635?src=pr&el=footer). Last update [e7def7e...5759363](https://codecov.io/gh/apache/superset/pull/12635?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] betodealmeida edited a comment on pull request #12635: feat: add decorator to guard public APIs
Posted by GitBox <gi...@apache.org>.
betodealmeida edited a comment on pull request #12635:
URL: https://github.com/apache/superset/pull/12635#issuecomment-764064463
> I know hashing is fast for most cases, but I'm wondering whether we can move this to be an offline job in some way?
>
> I.e. instead of a decorator, store the hash for all public APIs in a separate file and run the checks in CI.
Good point... we could also just add unit tests that import the functions and compare their signature hashes to hard coded values, that might be a more efficient approach.
(Also, the hashes are computed just once when the files are "compiled", not when the functions are called.)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12635: feat: add decorator to guard public APIs
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12635:
URL: https://github.com/apache/superset/pull/12635#issuecomment-764087241
# [Codecov](https://codecov.io/gh/apache/superset/pull/12635?src=pr&el=h1) Report
> Merging [#12635](https://codecov.io/gh/apache/superset/pull/12635?src=pr&el=desc) (5759363) into [master](https://codecov.io/gh/apache/superset/commit/e7def7e0e25caf09fbe33f8019db413686e349bc?el=desc) (e7def7e) will **decrease** coverage by `3.49%`.
> The diff coverage is `97.72%`.
[](https://codecov.io/gh/apache/superset/pull/12635?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12635 +/- ##
==========================================
- Coverage 66.80% 63.30% -3.50%
==========================================
Files 1017 486 -531
Lines 49730 30009 -19721
Branches 4864 0 -4864
==========================================
- Hits 33221 18998 -14223
+ Misses 16386 11011 -5375
+ Partials 123 0 -123
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.30% <97.72%> (-0.68%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12635?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/config.py](https://codecov.io/gh/apache/superset/pull/12635/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.61% <ø> (ø)` | |
| [superset/utils/decorators.py](https://codecov.io/gh/apache/superset/pull/12635/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGVjb3JhdG9ycy5weQ==) | `98.50% <97.22%> (-1.50%)` | :arrow_down: |
| [superset/sql\_lab.py](https://codecov.io/gh/apache/superset/pull/12635/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX2xhYi5weQ==) | `80.27% <100.00%> (+0.83%)` | :arrow_up: |
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/superset/pull/12635/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/views/database/views.py](https://codecov.io/gh/apache/superset/pull/12635/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2Uvdmlld3MucHk=) | `62.69% <0.00%> (-24.88%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/superset/pull/12635/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/superset/pull/12635/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `83.67% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/databases/commands/update.py](https://codecov.io/gh/apache/superset/pull/12635/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `85.71% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/12635/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `73.37% <0.00%> (-8.01%)` | :arrow_down: |
| [superset/sql\_validators/base.py](https://codecov.io/gh/apache/superset/pull/12635/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvYmFzZS5weQ==) | `93.33% <0.00%> (-6.67%)` | :arrow_down: |
| ... and [552 more](https://codecov.io/gh/apache/superset/pull/12635/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12635?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12635?src=pr&el=footer). Last update [e7def7e...5759363](https://codecov.io/gh/apache/superset/pull/12635?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org