You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/04/28 18:36:28 UTC

[GitHub] [arrow-datafusion] Dandandan opened a new issue #218: Move DataFusion cli/repl to own

Dandandan opened a new issue #218:
URL: https://github.com/apache/arrow-datafusion/issues/218


   **Is your feature request related to a problem or challenge? Please describe what you are trying to do.**
   The Datafusion cli/repl functionality now lives inside the DataFusion tree.
   This has two main implications:
   
   * Building DataFusion fetches extra dependencies (`clap` and transient dependencies) unneeded for the rest of DataFusion, slowing the development cycle down a bit.
   * Installing the binary using cargo is a bit more cumbersome, `cargo install datafusion --bin datafusion-cli --release`
   
   **Describe the solution you'd like**
   Move the `datafusion-cli` to the root dir.
   Publish the crate to `crates.io` as `datafusion-cli`. The tool now can be installed using `cargo install datafusion-cli --release` and now lives outside of the DataFusion crate.
   
   **Describe alternatives you've considered**
   Keep structure as is.
   
   **Additional context**
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow-datafusion] andygrove commented on issue #218: Move DataFusion cli/repl to own crate

Posted by GitBox <gi...@apache.org>.
andygrove commented on issue #218:
URL: https://github.com/apache/arrow-datafusion/issues/218#issuecomment-830116699


   I also filed https://github.com/apache/arrow-datafusion/issues/228 for publishing the DataFusion CLI as a Docker image


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow-datafusion] alamb commented on issue #218: Move DataFusion cli/repl to own crate

Posted by GitBox <gi...@apache.org>.
alamb commented on issue #218:
URL: https://github.com/apache/arrow-datafusion/issues/218#issuecomment-829997823


   I think this is a good idea. We might even get away without publishing the cli as a separate crate unless we have people who use it (perhaps we can pull the binary out and then publish a new crate if anyone wants it)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow-datafusion] Dandandan commented on issue #218: Move DataFusion cli/repl to own crate

Posted by GitBox <gi...@apache.org>.
Dandandan commented on issue #218:
URL: https://github.com/apache/arrow-datafusion/issues/218#issuecomment-828721811


   That's a good one @houqp I'll add that as well.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow-datafusion] houqp commented on issue #218: Move DataFusion cli/repl to own crate

Posted by GitBox <gi...@apache.org>.
houqp commented on issue #218:
URL: https://github.com/apache/arrow-datafusion/issues/218#issuecomment-828721140


   +1 these cli dependencies could cause unnecessary dependency conflicts for downstream datafusion consumers as well.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org