You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2018/12/05 01:25:24 UTC
[GitHub] WithLin commented on a change in pull request #2000: Fix support
rabbitmq plugin
WithLin commented on a change in pull request #2000: Fix support rabbitmq plugin
URL: https://github.com/apache/incubator-skywalking/pull/2000#discussion_r238902362
##########
File path: apm-protocol/apm-network/src/main/java/org/apache/skywalking/apm/network/trace/component/ComponentsDefine.java
##########
@@ -100,6 +100,10 @@
public static final OfficialComponent UNDERTOW = new OfficialComponent(49, "Undertow");
+ public static final OfficialComponent RABBITMQ_PRODUCER = new OfficialComponent(52,"rabbitmq-producer");
Review comment:
First of all, we define all components in the component-libraries.yml file. 50 is already defined in the component-libraries.yml file, which is not my modification. The definition of 51 has also been defined in the component-libraries.yml file, just like the Kafka component, the same.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services