You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/10/30 23:51:37 UTC

[GitHub] [spark] srowen commented on a change in pull request #26332: [SPARK-29674][CORE] Update dropwizard metrics to 4.1.x for JDK 9+

srowen commented on a change in pull request #26332: [SPARK-29674][CORE] Update dropwizard metrics to 4.1.x for JDK 9+
URL: https://github.com/apache/spark/pull/26332#discussion_r340909782
 
 

 ##########
 File path: core/pom.xml
 ##########
 @@ -292,6 +292,16 @@
     <dependency>
       <groupId>io.dropwizard.metrics</groupId>
       <artifactId>metrics-graphite</artifactId>
+      <exclusions>
+        <exclusion>
+          <groupId>com.rabbitmq</groupId>
+          <artifactId>amqp-client</artifactId>
 
 Review comment:
   This would otherwise be a new dependency on RabbitMQ, but, my hunch is that it is not necessary for Spark.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org