You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2022/08/27 04:50:24 UTC

[GitHub] [calcite] goldmedal commented on a diff in pull request #2883: [CALCITE-5245] Array element accessing in BigQuery should invoke `ORDINAL` operator

goldmedal commented on code in PR #2883:
URL: https://github.com/apache/calcite/pull/2883#discussion_r956537645


##########
core/src/main/java/org/apache/calcite/sql/dialect/BigQuerySqlDialect.java:
##########
@@ -183,6 +183,15 @@ public BigQuerySqlDialect(SqlDialect.Context context) {
     case TRIM:
       unparseTrim(writer, call, leftPrec, rightPrec);
       break;
+    case ITEM:

Review Comment:
   `ORIDANL` is an [Array subscript operator](https://cloud.google.com/bigquery/docs/reference/standard-sql/operators#array_subscript_operator) in BigQuery. I didn't see any other places needs this operator.
   
   BTW, because `arrray subscript operator` has `ORDIANL`, `SAFE_ORDINAL`, `OFFST` and `SAFE_OFFSET`, should we offer a config for the user to switch which one is preferred?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org