You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@groovy.apache.org by "paulk-asert (via GitHub)" <gi...@apache.org> on 2026/09/04 05:18:20 UTC
[PR] GROOVY-12351: @SafeRegex should handle regexes in nested and anonymou… [groovy]
paulk-asert opened a new pull request, #2874:
URL: https://github.com/apache/groovy/pull/2874
…s inner classes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@groovy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GROOVY-12351: @SafeRegex should handle regexes in nested and anonymou… [groovy]
Posted by "testlens-app[bot] (via GitHub)" <gi...@apache.org>.
testlens-app[bot] commented on PR #2874:
URL: https://github.com/apache/groovy/pull/2874#issuecomment-5536185924
## 🚨 TestLens detected 1 failed test 🚨
Here is what you can do:
1) Inspect the test failures carefully.
2) If you are convinced that some of the tests are flaky, you can mute them below.
3) Finally, trigger a rerun by checking the rerun checkbox.
### Test Summary
#### [Build and test / lts \(21, ubuntu-latest\)](https://github.com/apache/groovy/actions/runs/33839998496/job/100920178375?pr=2874) > :test
| Test | Runs | Flakiness |
|---|---|--:|
| ChannelSelectTest > testTimerCreatedOnceIsAFixedDeadlineAcrossSelects\(\) | ❌ | 6% 🟠 |
🏷️ Commit: c0e4fa5a2015fce5c18513f048dfe83bb0a1ebc7
▶️ Tests: 43130 executed
🟡 Checks: 5/29 completed
### Test Failures
<details><summary><strong>ChannelSelectTest > testTimerCreatedOnceIsAFixedDeadlineAcrossSelects()</strong> (:test in <a href="https://github.com/apache/groovy/actions/runs/33839998496/job/100920178375?pr=2874">Build and test / lts (21, ubuntu-latest)</a>)</summary>
```
Assertion failed:
assert deadline.closed
| |
| false
AsyncChannel{capacity=1, buffered=0, waitingSenders=0, waitingReceivers=0, closed=true}
at org.codehaus.groovy.runtime.InvokerHelper.createAssertError(InvokerHelper.java:409)
at TestScript38.run(TestScript38.groovy:20)
at groovy.lang.GroovyShell.evaluate(GroovyShell.java:552)
at groovy.lang.GroovyShell.evaluate(GroovyShell.java:587)
at groovy.lang.GroovyShell.evaluate(GroovyShell.java:571)
at groovy.test.GroovyAssert.assertScript(GroovyAssert.java:106)
at groovy.test.GroovyAssert.assertScript(GroovyAssert.java:96)
at groovy.concurrent.ChannelSelectTest.testTimerCreatedOnceIsAFixedDeadlineAcrossSelects(ChannelSelectTest.groovy:1179)
```
</details>
### Rerun Controls
> [!NOTE]
> Checks are currently running using the configuration below.
Select tests to mute in this pull request:
🔲 ChannelSelectTest > testTimerCreatedOnceIsAFixedDeadlineAcrossSelects\(\) <!-- uniqueId=[engine:junit-jupiter]/[class:groovy.concurrent.ChannelSelectTest]/[method:testTimerCreatedOnceIsAFixedDeadlineAcrossSelects()] -->
Reuse successful test results:
🔲 ♻️ Only rerun the tests that failed or were muted before
Click the checkbox to trigger a rerun:
🔲 **Rerun jobs**
---
_Learn more about TestLens at [testlens.app/docs](https://testlens.app/docs/features/pr-comment/)._
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@groovy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GROOVY-12351: @SafeRegex should handle regexes in nested and anonymou… [groovy]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #2874:
URL: https://github.com/apache/groovy/pull/2874#issuecomment-5536329603
## [Codecov](https://app.codecov.io/gh/apache/groovy/pull/2874?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 71.0787%. Comparing base ([`f344d76`](https://app.codecov.io/gh/apache/groovy/commit/f344d76c69477397c8e3ddc25e5a7e7d795a2447?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`c0e4fa5`](https://app.codecov.io/gh/apache/groovy/commit/c0e4fa5a2015fce5c18513f048dfe83bb0a1ebc7?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
<details><summary>Additional details and impacted files</summary>
[](https://app.codecov.io/gh/apache/groovy/pull/2874?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
```diff
@@ Coverage Diff @@
## master #2874 +/- ##
==================================================
+ Coverage 71.0741% 71.0787% +0.0046%
- Complexity 37300 37307 +7
==================================================
Files 1578 1578
Lines 135384 135388 +4
Branches 25084 25085 +1
==================================================
+ Hits 96223 96232 +9
+ Misses 30477 30475 -2
+ Partials 8684 8681 -3
```
| [Files with missing lines](https://app.codecov.io/gh/apache/groovy/pull/2874?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...s/groovy/transform/SafeRegexASTTransformation.java](https://app.codecov.io/gh/apache/groovy/pull/2874?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Ftransform%2FSafeRegexASTTransformation.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L3RyYW5zZm9ybS9TYWZlUmVnZXhBU1RUcmFuc2Zvcm1hdGlvbi5qYXZh) | `80.4348% <100.0000%> (+1.8633%)` | :arrow_up: |
... and [9 files with indirect coverage changes](https://app.codecov.io/gh/apache/groovy/pull/2874/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@groovy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GROOVY-12351: @SafeRegex should handle regexes in nested and anonymou… [groovy]
Posted by "paulk-asert (via GitHub)" <gi...@apache.org>.
paulk-asert merged PR #2874:
URL: https://github.com/apache/groovy/pull/2874
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@groovy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org