You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2021/09/09 06:37:37 UTC

[GitHub] [bookkeeper] eolivelli edited a comment on pull request #2788: fix-npe-when-pulsar-ZkBookieRackAffinityMapping-getBookieAddressResolver

eolivelli edited a comment on pull request #2788:
URL: https://github.com/apache/bookkeeper/pull/2788#issuecomment-915805174


   Sorry I meant:
   
   **I would NOT prefer** to refactor interfaces or pluggable components in order to not introduce API changes, in that case it would be harder to upgrade BK
   
   So this change in this current form works for me.
   That said, adding a simple test case that reproduces the NPE will be better, otherwise we could break ZkBookieRackAffinityMapping again
   
   If you have the error on ZkBookieRackAffinityMapping you could try to use the bookieAddressResolver in the way that ZkBookieRackAffinityMapping does, but in a dummy implementation


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org