You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hbase.apache.org by ap...@apache.org on 2017/11/10 08:10:28 UTC

hbase git commit: HBASE-16459 Remove unused hbase shell --format option

Repository: hbase
Updated Branches:
  refs/heads/master 35a1e4334 -> 31234eb86


HBASE-16459 Remove unused hbase shell --format option


Project: http://git-wip-us.apache.org/repos/asf/hbase/repo
Commit: http://git-wip-us.apache.org/repos/asf/hbase/commit/31234eb8
Tree: http://git-wip-us.apache.org/repos/asf/hbase/tree/31234eb8
Diff: http://git-wip-us.apache.org/repos/asf/hbase/diff/31234eb8

Branch: refs/heads/master
Commit: 31234eb862fdd7ee4917a2f74001182565ffbfd9
Parents: 35a1e43
Author: Apekshit Sharma <ap...@apache.org>
Authored: Thu Nov 9 15:03:13 2017 -0800
Committer: Apekshit Sharma <ap...@apache.org>
Committed: Fri Nov 10 00:08:02 2017 -0800

----------------------------------------------------------------------
 bin/hirb.rb | 17 +----------------
 1 file changed, 1 insertion(+), 16 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/hbase/blob/31234eb8/bin/hirb.rb
----------------------------------------------------------------------
diff --git a/bin/hirb.rb b/bin/hirb.rb
index c06c83b..35895f8 100644
--- a/bin/hirb.rb
+++ b/bin/hirb.rb
@@ -54,10 +54,6 @@ $LOAD_PATH.unshift Pathname.new(sources)
 cmdline_help = <<HERE # HERE document output as shell usage
 Usage: shell [OPTIONS] [SCRIPTFILE [ARGUMENTS]]
 
- --format=OPTION                Formatter for outputting results.
-                                Valid options are: console, html.
-                                (Default: console)
-
  -d | --debug                   Set DEBUG log levels.
  -h | --help                    This help.
  -n | --noninteractive          Do not run within an IRB session
@@ -65,23 +61,12 @@ Usage: shell [OPTIONS] [SCRIPTFILE [ARGUMENTS]]
                                 first error.
 HERE
 found = []
-format = 'console'
 script2run = nil
 log_level = org.apache.log4j.Level::ERROR
 @shell_debug = false
 interactive = true
 for arg in ARGV
-  if arg =~ /^--format=(.+)/i
-    format = Regexp.last_match(1)
-    if format =~ /^html$/i
-      raise NoMethodError, 'Not yet implemented'
-    elsif format =~ /^console$/i
-      # This is default
-    else
-      raise ArgumentError, 'Unsupported format ' + arg
-    end
-    found.push(arg)
-  elsif arg == '-h' || arg == '--help'
+  if arg == '-h' || arg == '--help'
     puts cmdline_help
     exit
   elsif arg == '-d' || arg == '--debug'