[GitHub] [lucene-solr] uschindler commented on a change in pull request #644: SOLR-13394: Change default GC from CMS to G1

[GitBox <gi...@apache.org>]

uschindler commented on a change in pull request #644: SOLR-13394: Change default GC from CMS to G1
URL: https://github.com/apache/lucene-solr/pull/644#discussion_r276282835
 
 

 ##########
 File path: solr/bin/solr.cmd
 ##########
 @@ -1167,20 +1167,14 @@ set SOLR_OPTS=%SOLR_JAVA_STACK_SIZE% %SOLR_OPTS%
 IF "%SOLR_TIMEZONE%"=="" set SOLR_TIMEZONE=UTC
 
 IF "%GC_TUNE%"=="" (
-  set GC_TUNE=-XX:NewRatio=3 ^
-   -XX:SurvivorRatio=4 ^
-   -XX:TargetSurvivorRatio=90 ^
-   -XX:MaxTenuringThreshold=8 ^
-   -XX:+UseConcMarkSweepGC ^
-   -XX:ConcGCThreads=4 -XX:ParallelGCThreads=4 ^
-   -XX:+CMSScavengeBeforeRemark ^
-   -XX:PretenureSizeThreshold=64m ^
-   -XX:+UseCMSInitiatingOccupancyOnly ^
-   -XX:CMSInitiatingOccupancyFraction=50 ^
-   -XX:CMSMaxAbortablePrecleanTime=6000 ^
-   -XX:+CMSParallelRemarkEnabled ^
-   -XX:+ParallelRefProcEnabled ^
-   -XX:-OmitStackTraceInFastThrow
+  set GC_TUNE=-XX:+UseG1GC ^
+    -XX:+PerfDisableSharedMem ^
+    -XX:+ParallelRefProcEnabled ^
+    -XX:G1HeapRegionSize=16m ^
+    -XX:MaxGCPauseMillis=250 ^
+    -XX:InitiatingHeapOccupancyPercent=45 ^
+    -XX:+UseLargePages ^
+    -XX:+AggressiveOpts
 
 Review comment:
   Don't enable aggressive opts!

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org