You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "Yicong-Huang (via GitHub)" <gi...@apache.org> on 2026/10/15 22:48:51 UTC
[PR] [SPARK-60273][CONNECT] Avoid binding the default Connect port in SparkConnectClientSuite URI check [spark]
Yicong-Huang opened a new pull request, #59530:
URL: https://github.com/apache/spark/pull/59530
### What changes were proposed in this pull request?
In `SparkConnectClientSuite`, the `sc://localhost/` URI check now asserts that the client resolves to `localhost` and `ConnectCommon.CONNECT_GRPC_BINDING_PORT` on `client.configuration`, instead of starting a dummy server on port 15002 and connecting to it. `testClientConnection` no longer takes a server port and always binds to a random port.
### Why are the changes needed?
The test is flaky: if anything else on the CI runner holds 15002, it fails with `java.io.IOException: Failed to bind to address 0.0.0.0/0.0.0.0:15002` (e.g. https://github.com/Yicong-Huang/spark/actions/runs/38784975930/job/116603715779). Checking the parsed port covers the same intent without depending on a fixed port being free.
### Does this PR introduce _any_ user-facing change?
No, test-only.
### How was this patch tested?
`build/sbt 'connect-client-jvm/testOnly *SparkConnectClientSuite'` passes, including with port 15002 held by another process.
### Was this patch authored or co-authored using generative AI tooling?
Generated-by: Claude Opus 5.5
This pull request and its description were written by Isaac.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-60273][CONNECT][TEST] Avoid binding the default Connect port in SparkConnectClientSuite URI check [spark]
Posted by "Yicong-Huang (via GitHub)" <gi...@apache.org>.
Yicong-Huang commented on PR #59530:
URL: https://github.com/apache/spark/pull/59530#issuecomment-6274998654
**Merge Summary:**
- merged into master https://github.com/apache/spark/commit/92bd4647cc963f0e3929d7d09f9bf833afde578e
- merged into branch-4.x https://github.com/apache/spark/commit/e81a47775c610a8f2ac4668d52d7d05757fe0f97
*Posted by `merge_spark_pr.py`*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-60273][CONNECT][TEST] Avoid binding the default Connect port in SparkConnectClientSuite URI check [spark]
Posted by "Yicong-Huang (via GitHub)" <gi...@apache.org>.
Yicong-Huang commented on PR #59530:
URL: https://github.com/apache/spark/pull/59530#issuecomment-6203907636
this to fix a flaky test.
cc @zhengruifeng
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-60273][CONNECT][TEST] Avoid binding the default Connect port in SparkConnectClientSuite URI check [spark]
Posted by "Yicong-Huang (via GitHub)" <gi...@apache.org>.
Yicong-Huang closed pull request #59530: [SPARK-60273][CONNECT][TEST] Avoid binding the default Connect port in SparkConnectClientSuite URI check
URL: https://github.com/apache/spark/pull/59530
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-60273][CONNECT][TEST] Avoid binding the default Connect port in SparkConnectClientSuite URI check [spark]
Posted by "uros-b (via GitHub)" <gi...@apache.org>.
uros-b commented on PR #59530:
URL: https://github.com/apache/spark/pull/59530#issuecomment-6238735631
Thank you @Yicong-Huang and @zhengruifeng!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org