[GitHub] [ignite-3] ibessonov commented on a change in pull request #161: IGNITE-14819 Propagate exceptions from NettyServer and NettyClient

[GitBox <gi...@apache.org>]

ibessonov commented on a change in pull request #161:
URL: https://github.com/apache/ignite-3/pull/161#discussion_r644862722



##########
File path: modules/network/src/main/java/org/apache/ignite/network/MessageSerializationRegistryImpl.java
##########
@@ -78,9 +78,10 @@ else if (groupFactories[messageType] != null)
 
         MessageSerializationFactory<?> provider = groupFactories == null ? null : groupFactories[messageType];
 
-        assert provider != null :
-            String.format("No serializer provider defined for group type %d and message type %d",
-                groupType, messageType);
+        if (provider == null)

Review comment:
       I know you're tired of these comments, but here we need braces, because next statement is multi-line.

##########
File path: modules/network/src/main/java/org/apache/ignite/network/internal/netty/ConnectionManager.java
##########
@@ -116,11 +117,17 @@ public ConnectionManager(
      */
     public void start() throws IgniteInternalException {
         try {
-            server.start().join();
+            server.start().get(3, TimeUnit.SECONDS);

Review comment:
       We don't have any failover timeout in network configuration right now. Please link this part with TODO to some ticket that we'll use to create such configuration.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org