You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@activemq.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2021/08/03 17:54:00 UTC
[jira] [Work logged] (ARTEMIS-3367) The verifyHost parameter
default value should be changed
[ https://issues.apache.org/jira/browse/ARTEMIS-3367?focusedWorklogId=633078&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-633078 ]
ASF GitHub Bot logged work on ARTEMIS-3367:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 03/Aug/21 17:53
Start Date: 03/Aug/21 17:53
Worklog Time Spent: 10m
Work Description: jbertram commented on a change in pull request #3667:
URL: https://github.com/apache/activemq-artemis/pull/3667#discussion_r681978852
##########
File path: tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/amqp/AmqpFailoverEndpointDiscoveryTest.java
##########
@@ -90,9 +93,9 @@ private JmsConnectionFactory getJmsConnectionFactory() {
if (protocol == 0) {
return new JmsConnectionFactory("failover:(amqp://localhost:61616)");
} else {
- String keystore = this.getClass().getClassLoader().getResource("client-side-keystore.jks").getFile();
- String truststore = this.getClass().getClassLoader().getResource("client-side-truststore.jks").getFile();
- return new JmsConnectionFactory("failover:(amqps://localhost:61616?transport.keyStoreLocation=" + keystore + "&transport.keyStorePassword=secureexample&transport.trustStoreLocation=" + truststore + "&transport.trustStorePassword=secureexample&transport.verifyHost=false)");
+ String keystore = this.getClass().getClassLoader().getResource("examples/features/standard/jmx-ssl/src/main/resources/activemq/server0/client-keystore.jks").getFile();
+ String truststore = this.getClass().getClassLoader().getResource("examples/features/standard/jmx-ssl/src/main/resources/activemq/server0/server-ca-truststore.jks").getFile();
Review comment:
Why not reference the resources in `tests/security-resources` like the comment at the beginning of the class suggests? Are the example resources unique in some way?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 633078)
Time Spent: 50m (was: 40m)
> The verifyHost parameter default value should be changed
> --------------------------------------------------------
>
> Key: ARTEMIS-3367
> URL: https://issues.apache.org/jira/browse/ARTEMIS-3367
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Components: Configuration
> Affects Versions: 2.17.0
> Reporter: Emmanuel Hugonnet
> Assignee: Domenico Francesco Bruscino
> Priority: Major
> Time Spent: 50m
> Remaining Estimate: 0h
>
> Currently the acceptor/connector *verifyHost* parameter is set to 'false' per default. We should provide a better out of the box experience by setting it to true per default for connectors.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)