You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nifi.apache.org by "Joseph Witt (JIRA)" <ji...@apache.org> on 2015/03/20 20:56:38 UTC
[jira] [Commented] (NIFI-418) PutEmail should support TLS (optional
property)
[ https://issues.apache.org/jira/browse/NIFI-418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14371977#comment-14371977 ]
Joseph Witt commented on NIFI-418:
----------------------------------
Brian,
First, thanks for contributing a patch! Very cool.
Just doing a quick look through and applying patch locally for testing. One thing that pops out to me as funny is our PropertyDescriptor concept when the value is sensitive but also supports expression language:
{code:java}
public static final PropertyDescriptor SMTP_PASSWORD = new PropertyDescriptor.Builder()
.name("SMTP Password")
.description("Password for the SMTP account")
.expressionLanguageSupported(true)
.addValidator(StandardValidators.NON_EMPTY_VALIDATOR)
.required(false)
.sensitive(true)
.build();
{code}
Definitely not a case I considered. The usability in that case is somewhat tricky to sort out in terms of 'to show' or 'not to show'. The user will not know or even be able to see the property after they enter it the first time. So they might forget or not realize it is an expression language statement. I wonder if the better approach in such a case is to offer two properties and just document which one is preferred. For example you can allow them to enter the password in one that accepts expression language statements and is not sensitive and another that does not allow expression language but is sensitive. To be clear sensitive just means it will be encrypted after the first entry and will never again end up going to the client side. So you could say if the property which allows EL statements is there you'll prefer that for determining password otherwise you'll fallback to the other one. Or if both are there you'll use one or the other... I dont know.
Ok - looking at the results of the patch applied...will have more.
Thanks
Joe
> PutEmail should support TLS (optional property)
> -----------------------------------------------
>
> Key: NIFI-418
> URL: https://issues.apache.org/jira/browse/NIFI-418
> Project: Apache NiFi
> Issue Type: Bug
> Components: Extensions
> Reporter: Mark Payne
> Labels: beginner, newbie
> Attachments: NIFI-418-Email-TLS-Support.patch
>
>
> Currently, the PutEmail processor will not work with an SMTP server that requires that TLS be enabled. We need to enable this by setting the "smtp.mail.starttls.enable" property when we set the "smtp.mail.host".
> There may be other interesting properties that we should expose, as well.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)