[GitHub] azagrebin commented on issue #6735: [FLINK-9126] New CassandraPojoInputFormat to output data as a custom annotated Cassandra Pojo

[GitBox <gi...@apache.org>]

azagrebin commented on issue #6735: [FLINK-9126] New CassandraPojoInputFormat to output data as a custom annotated Cassandra Pojo
URL: https://github.com/apache/flink/pull/6735#issuecomment-424658491
 
 
   Great, looks good! I think committer will do it but rebasing on master is always a good thing.
   
   The `CassandraPojoSink` is actually for streaming API. Unless we want to extend `CassandraOutputFormatBase` with `CassandraPojoOutputFormat`, I think it is better to use `CassandraTupleOutputFormat` for batch example in this PR, as it was. 
   
   Sorry for confusion, can we roll it back to `CassandraTupleOutputFormat` for batch example before merge (with `execute("write")` after `output`)? `CassandraOutputFormatBase` can be extended with `CassandraPojoOutputFormat` in other PR if needed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services